Skip to content

Commit 5e0b9db

Browse files
committed
Add separate target to the build system for checksum backend linkage. This
eliminates the need of adding openssl directly (which acted in the same way before), only it's more convinient for other backends like Windows BCrypt. * CMakeLists.txt (checksum backend): Setup backends via external-checksum-libs target. * build/generator/gen_win_dependencies.py (GenDependenciesBase): Ignore 'checksum-libs'. * build.conf (libsvn_subr): Link against checksum-libs (checksum-libs): New target. git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1931390 13f79535-47bb-0310-9956-ffa450edef68
1 parent 2f080d3 commit 5e0b9db

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -386,14 +386,14 @@ if (SVN_ENABLE_RA_SERF)
386386
endif()
387387

388388
if (SVN_CHECKSUM_BACKEND STREQUAL "apr")
389-
add_library(external-openssl INTERFACE)
389+
add_library(external-checksum-libs INTERFACE)
390390
add_private_config_definition(
391391
"Defined if svn should use APR to compute checksums."
392392
"SVN_CHECKSUM_BACKEND_APR" "1"
393393
)
394394
elseif (SVN_CHECKSUM_BACKEND STREQUAL "openssl")
395395
find_package(OpenSSL REQUIRED)
396-
add_library(external-openssl ALIAS OpenSSL::Crypto)
396+
add_library(external-checksum-libs ALIAS OpenSSL::Crypto)
397397
add_private_config_definition(
398398
"Defined if svn should use OpenSSL to compute checksums."
399399
"SVN_CHECKSUM_BACKEND_OPENSSL" "1"
@@ -403,8 +403,8 @@ elseif (SVN_CHECKSUM_BACKEND STREQUAL "bcrypt")
403403
message(SEND_ERROR "BCrypt checksum backend is only available on Win32 platform.")
404404
endif()
405405

406-
add_library(external-openssl INTERFACE)
407-
target_link_libraries(external-openssl INTERFACE Bcrypt.lib)
406+
add_library(external-checksum-libs INTERFACE)
407+
target_link_libraries(external-checksum-libs INTERFACE Bcrypt.lib)
408408

409409
add_private_config_definition(
410410
"Defined if svn should use BCrypt to compute checksums."

build.conf

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ install = fsmod-lib
394394
path = subversion/libsvn_subr
395395
sources = *.c lz4/*.c
396396
libs = aprutil apriconv apr xml zlib apr_memcache
397-
sqlite magic intl lz4 utf8proc macos-plist macos-keychain openssl
397+
sqlite magic intl lz4 utf8proc macos-plist macos-keychain checksum-libs
398398
msvc-libs = kernel32.lib advapi32.lib shfolder.lib ole32.lib
399399
crypt32.lib version.lib ws2_32.lib
400400
msvc-export =
@@ -1505,6 +1505,10 @@ external-lib = $(SVN_SASL_LIBS)
15051505
type = lib
15061506
external-lib = $(SVN_OPENSSL_LIBS) $(SVN_LIBCRYPTO_LIBS)
15071507

1508+
[checksum-libs]
1509+
type = lib
1510+
external-lib = $(SVN_CHECKSUM_LIBS)
1511+
15081512
[intl]
15091513
type = lib
15101514
external-lib = $(SVN_INTL_LIBS)

build/generator/gen_win_dependencies.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ class GenDependenciesBase(gen_base.GeneratorBase):
125125
'java_sdk',
126126
'openssl',
127127
'apr_memcache',
128+
'checksum-libs',
128129

129130
# So optional, we don't even have any code to detect them on Windows
130131
'magic',

0 commit comments

Comments
 (0)