Clarify the meaning of db.instance tag #9672
lujiajing1126
started this conversation in
General
Replies: 2 comments 5 replies
-
|
The cache has been changed, please take a check again. |
Beta Was this translation helpful? Give feedback.
3 replies
-
|
Do you have any concerns about this? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
In the Java agent,
db.instancetag is extensively used in many plugins,But I found in the
redissonwhich is a high level Redis SDK,ip:portis used for this tag. As I understand, database number should be used in all redis client cases, e.g. Jedis, Lettuce, Redisson, etc.Also, the semantics of this tag is not clearly documented, https://github.com/apache/skywalking-java/blob/6fce184cfe95b3a4b7cf97421ee4efdb03d2c7cc/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/tag/Tags.java#L53
Beta Was this translation helpful? Give feedback.
All reactions