Replies: 7 comments
-
This is general guidance, not a strict rule. Usually, it is also common to intercept or implement filters to get the same purpose. The key point is, your plugin should be auto instrumentation, don't need to change the target service's source codes. |
Beta Was this translation helpful? Give feedback.
-
If I understand correctly, you mean you have interceptors that users can use in their code, but SkyWalking Python agent aims to do the interception automatically, so I think what you need is to find out a proper point and insert your interceptors (automatically) into the process chain |
Beta Was this translation helpful? Give feedback.
-
|
@kehuili you can see the same method in our Java agent, we have interceptor and a point to insert that interceptor automatically. |
Beta Was this translation helpful? Give feedback.
-
|
Got it. Gonna find a proper way to implement it. |
Beta Was this translation helpful? Give feedback.
-
If this is not ready yet, should we move this to the discussion channel? |
Beta Was this translation helpful? Give feedback.
-
Sure. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @kehuili, I'm interested to see the gRPC plugin, is it ready yet? Let me know if there's any blocking issues, I can help. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Search before asking
Description
I have implemented a gRPC plugin for python, and interceptors(client-side and server-side) were used to achieve this.
But in developer guide and plugins already implemented, it seems to be a different way to implement a plugin.
I was wondering if I make a PR, is interceptors acceptable, or it is a better way to follow what's said in developer guide.
Use case
Use python gRPC plugin to track gRPC requests
Related issues
No response
Are you willing to submit a PR?
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions