Skip to content

Commit 4353db1

Browse files
committed
fix
1 parent 63679b6 commit 4353db1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

oap-server/server-query-plugin/traceql-plugin/src/main/java/org/apache/skywalking/oap/query/traceql/handler/ZipkinTraceQLApiHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ private void parseTagsParameter(Optional<String> tags, QueryRequest.Builder quer
326326
*/
327327
private Long parseDurationToMicros(String durationStr) {
328328
if (durationStr == null || durationStr.isEmpty()) {
329-
return null;
329+
throw new IllegalArgumentException("Duration string cannot be null or empty");
330330
}
331331

332332
try {

test/e2e-v2/cases/traceql/zipkin/expected/tag-values-service.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@
1414
# limitations under the License.
1515

1616
tagValues:
17+
{{- contains .tagValues }}
1718
- type: string
1819
value: backend
1920
- type: string
2021
value: frontend
22+
{{- end }}

0 commit comments

Comments
 (0)