PDFBOX-5660: refactor, avoid leaking this in constructor

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1934019 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java

@@ -420,13 +420,8 @@ public void windowClosing(WindowEvent evt)
         documentScroller.setViewportView(documentPanel);
 
         statusPane = new TreeStatusPane(tree);
-        statusPane.getPanel().setBorder(new BevelBorder(BevelBorder.RAISED));
-        Dimension preferredTreePathSize = statusPane.getPanel().getPreferredSize();
-        int treePathHeight = (int) Math.round(preferredTreePathSize.getHeight());
-        treePathHeight = Integer.parseInt(
-                configuration.getProperty("treePathHeight", Integer.toString(treePathHeight)));
-        preferredTreePathSize.height = treePathHeight;
-        statusPane.getPanel().setPreferredSize(preferredTreePathSize);
+        statusPane.init();
+
         getContentPane().add(statusPane.getPanel(), BorderLayout.PAGE_START);
 
         getContentPane().add(jSplitPane, BorderLayout.CENTER);

debugger/src/main/java/org/apache/pdfbox/debugger/treestatus/TreeStatusPane.java

@@ -19,6 +19,7 @@
 
 import java.awt.BorderLayout;
 import java.awt.Color;
+import java.awt.Dimension;
 import java.awt.event.ActionEvent;
 import javax.swing.AbstractAction;
 import javax.swing.Action;
@@ -72,10 +73,12 @@ public void actionPerformed(ActionEvent actionEvent)
     public TreeStatusPane(JTree targetTree)
     {
         tree = targetTree;
-        init();
     }
 
-    private void init()
+    /**
+     * Initialization, to be called immediately after construction.
+     */
+    public void init()
     {
         panel = new JPanel(new BorderLayout());
         statusField = new JTextField();
@@ -88,6 +91,13 @@ private void init()
         errorBorder = new BevelBorder(BevelBorder.LOWERED, Color.RED, Color.RED);
         statusField.setAction(textInputAction);
         tree.addTreeSelectionListener(this);
+        panel.setBorder(new BevelBorder(BevelBorder.RAISED));
+        Dimension preferredTreePathSize = panel.getPreferredSize();
+        int treePathHeight = (int) Math.round(preferredTreePathSize.getHeight());
+        treePathHeight = Integer.parseInt(
+                PDFDebugger.configuration.getProperty("treePathHeight", Integer.toString(treePathHeight)));
+        preferredTreePathSize.height = treePathHeight;
+        panel.setPreferredSize(preferredTreePathSize);
     }
 
     /**