Skip to content

Commit 16df3de

Browse files
authored
[MNG-8582] Keep stdout/stderr functioning (#2112)
This call has severe implications (re-ties logger, and in case is invoked multiple times, causes "loop"). Make sure it happens only once, This changes does not affect mvn and mvnd (it installs own stdout/stderr), but does affects mvnsh and resident maven, --- https://issues.apache.org/jira/browse/MNG-8582
1 parent d50b7cd commit 16df3de

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -284,11 +284,6 @@ protected void configureLogging(C context) throws Exception {
284284
context.slf4jConfiguration.setRootLoggerLevel(context.loggerLevel);
285285
// else fall back to default log level specified in conf
286286
// see https://issues.apache.org/jira/browse/MNG-2570
287-
288-
// Create the build log appender; also sets MavenSimpleLogger sink
289-
ProjectBuildLogAppender projectBuildLogAppender =
290-
new ProjectBuildLogAppender(determineBuildEventListener(context));
291-
context.closeables.add(projectBuildLogAppender);
292287
}
293288

294289
protected BuildEventListener determineBuildEventListener(C context) {
@@ -305,6 +300,11 @@ protected BuildEventListener doDetermineBuildEventListener(C context) {
305300

306301
protected void createTerminal(C context) {
307302
if (context.terminal == null) {
303+
// Create the build log appender; also sets MavenSimpleLogger sink
304+
ProjectBuildLogAppender projectBuildLogAppender =
305+
new ProjectBuildLogAppender(determineBuildEventListener(context));
306+
context.closeables.add(projectBuildLogAppender);
307+
308308
MessageUtils.systemInstall(
309309
builder -> {
310310
if (context.invokerRequest.embedded()) {

0 commit comments

Comments
 (0)