Skip to content

Commit 1848fb1

Browse files
review changes
1 parent 97b15fc commit 1848fb1

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1403,20 +1403,24 @@ private void publishOnEventBus(AsyncJob job, String jobEvent) {
14031403
_eventBusPublisher.submit(new ManagedContextRunnable() {
14041404
@Override
14051405
protected void runInContext() {
1406-
try {
1407-
_messageBus.publish(null, AsyncJob.Topics.JOB_EVENT_PUBLISH, PublishScope.LOCAL,
1408-
new Pair<>(job, jobEvent));
1409-
} catch (Throwable t) {
1410-
logger.warn("Failed to publish async job event on message bus. jobId={}, jobEvent={}",
1411-
job != null ? job.getId() : null, jobEvent, t);
1412-
}
1406+
publishJobEvent(job, jobEvent);
14131407
}
14141408
});
14151409
} catch (RejectedExecutionException e) {
14161410
logger.warn("Failed to publish async job event, event bus publisher is shut down", e);
14171411
}
14181412
}
14191413

1414+
private void publishJobEvent(AsyncJob job, String jobEvent) {
1415+
try {
1416+
_messageBus.publish(null, AsyncJob.Topics.JOB_EVENT_PUBLISH, PublishScope.LOCAL,
1417+
new Pair<>(job, jobEvent));
1418+
} catch (Throwable t) {
1419+
logger.warn("Failed to publish async job event on message bus. jobId={}, jobEvent={}",
1420+
job != null ? job.getId() : null, jobEvent, t);
1421+
}
1422+
}
1423+
14201424
@Override
14211425
public List<AsyncJobVO> findFailureAsyncJobs(String... cmds) {
14221426
return _jobDao.getFailureJobsSinceLastMsStart(getMsid(), cmds);

0 commit comments

Comments
 (0)