Skip to content

Commit 81352c2

Browse files
authored
Merge pull request #3435 from apache/3973-backport.layout.switch
CAUSEWAY-3973: [v2] Backport Layout Switching Fixes
2 parents eda2d7f + fbfe54d commit 81352c2

File tree

172 files changed

+6671
-7192
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

172 files changed

+6671
-7192
lines changed

adoc/changelog.adoc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
🐞 Bug Fixes
44

55
- [Commons] Internal OneShot Util may deadlock https://issues.apache.org/jira/browse/CAUSEWAY-3972[CAUSEWAY-3972] (potentially preventing App from startup)
6-
6+
- Switching between Layout Variants may result in Members staying hidden
7+
https://issues.apache.org/jira/browse/CAUSEWAY-3971[CAUSEWAY-3971], https://issues.apache.org/jira/browse/CAUSEWAY-3973[CAUSEWAY-3973]
78
89
= Feb 2016
910

api/applib/src/main/java/module-info.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
exports org.apache.causeway.applib.jaxb;
3838
exports org.apache.causeway.applib.layout.component;
3939
exports org.apache.causeway.applib.layout.grid.bootstrap;
40-
exports org.apache.causeway.applib.layout.grid;
40+
exports org.apache.causeway.applib.layout.resource;
4141
exports org.apache.causeway.applib.layout.links;
4242
exports org.apache.causeway.applib.layout.menubars.bootstrap;
4343
exports org.apache.causeway.applib.layout.menubars;
@@ -151,7 +151,6 @@
151151
opens org.apache.causeway.applib.annotation;
152152
opens org.apache.causeway.applib.layout.component;
153153
opens org.apache.causeway.applib.layout.grid.bootstrap;
154-
opens org.apache.causeway.applib.layout.grid;
155154
opens org.apache.causeway.applib.layout.links;
156155
opens org.apache.causeway.applib.layout.menubars.bootstrap;
157156
opens org.apache.causeway.applib.layout.menubars;

api/applib/src/main/java/org/apache/causeway/applib/layout/grid/Grid.java

Lines changed: 0 additions & 108 deletions
This file was deleted.

api/applib/src/main/java/org/apache/causeway/applib/layout/grid/GridAbstract.java

Lines changed: 0 additions & 218 deletions
This file was deleted.

api/applib/src/main/java/org/apache/causeway/applib/layout/grid/bootstrap/BSElement.java

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@
2020

2121
import java.io.Serializable;
2222

23+
import org.apache.causeway.applib.layout.component.ActionLayoutData;
24+
import org.apache.causeway.applib.layout.component.CollectionLayoutData;
25+
import org.apache.causeway.applib.layout.component.DomainObjectLayoutData;
26+
import org.apache.causeway.applib.layout.component.FieldSet;
27+
import org.apache.causeway.applib.layout.component.PropertyLayoutData;
28+
2329
/**
2430
* @since 1.x {@index}
2531
*/
@@ -31,8 +37,26 @@ public interface BSElement extends WithinGrid, Serializable {
3137
* custom styling.
3238
*/
3339
String getCssClass();
34-
3540
void setCssClass(final String cssClass);
3641

42+
public interface BSElementVisitor {
43+
default void enter(final BSGrid bsGrid) {}
44+
default void exit(final BSGrid bsGrid) {}
45+
default void enter(final BSRow bsRow) {}
46+
default void exit(final BSRow bsRow) {}
47+
default void enter(final BSCol bsCol) {}
48+
default void exit(final BSCol bsCol) {}
49+
default void visit(final BSClearFix bsClearFix) {}
50+
default void enter(final BSTabGroup bsTabGroup) {}
51+
default void exit(final BSTabGroup bsTabGroup) {}
52+
default void enter(final BSTab bsTab) {}
53+
default void exit(final BSTab bsTab) {}
54+
55+
default void visit(final DomainObjectLayoutData domainObjectLayoutData) {}
56+
default void visit(final ActionLayoutData actionLayoutData) {}
57+
default void visit(final PropertyLayoutData propertyLayoutData) {}
58+
default void visit(final CollectionLayoutData collectionLayoutData) {}
59+
default void visit(final FieldSet fieldSet) {}
60+
}
3761

3862
}

0 commit comments

Comments
 (0)