fix

qunzhong · qunzhong · commit 0a243957639a · 2024-07-26T10:50:21.000+08:00
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java
@@ -698,14 +698,13 @@ private void fillReadAheadCache(long originalLedgerId, long firstEntryId, long f
                     ReferenceCountUtil.release(entry);
                 }
             }
+            dbLedgerStorageStats.getReadAheadBatchCountStats().registerSuccessfulValue(count);
+            dbLedgerStorageStats.getReadAheadBatchSizeStats().registerSuccessfulValue(size);
+            recordSuccessfulEvent(dbLedgerStorageStats.getReadAheadTime(),readAheadStartNano);
         } catch (Exception e) {
             if (log.isDebugEnabled()) {
                 log.debug("Exception during read ahead for ledger: {}: e", originalLedgerId, e);
             }
-            dbLedgerStorageStats.getReadAheadBatchCountStats().registerSuccessfulValue(count);
-            dbLedgerStorageStats.getReadAheadBatchSizeStats().registerSuccessfulValue(size);
-            recordSuccessfulEvent(dbLedgerStorageStats.getReadAheadTime(),readAheadStartNano);
-        } finally {
             dbLedgerStorageStats.getReadAheadBatchCountStats().registerFailedValue(count);
             dbLedgerStorageStats.getReadAheadBatchSizeStats().registerFailedValue(size);
             recordFailedEvent(dbLedgerStorageStats.getReadAheadTime(),readAheadStartNano);

Original file line number	Diff line number	Diff line change
`@@ -698,14 +698,13 @@ private void fillReadAheadCache(long originalLedgerId, long firstEntryId, long f`
`698`	`698`	`ReferenceCountUtil.release(entry);`
`699`	`699`	`}`
`700`	`700`	`}`
	`701`	`+ dbLedgerStorageStats.getReadAheadBatchCountStats().registerSuccessfulValue(count);`
	`702`	`+ dbLedgerStorageStats.getReadAheadBatchSizeStats().registerSuccessfulValue(size);`
	`703`	`+ recordSuccessfulEvent(dbLedgerStorageStats.getReadAheadTime(),readAheadStartNano);`
`701`	`704`	`} catch (Exception e) {`
`702`	`705`	`if (log.isDebugEnabled()) {`
`703`	`706`	`log.debug("Exception during read ahead for ledger: {}: e", originalLedgerId, e);`
`704`	`707`	`}`
`705`		`- dbLedgerStorageStats.getReadAheadBatchCountStats().registerSuccessfulValue(count);`
`706`		`- dbLedgerStorageStats.getReadAheadBatchSizeStats().registerSuccessfulValue(size);`
`707`		`- recordSuccessfulEvent(dbLedgerStorageStats.getReadAheadTime(),readAheadStartNano);`
`708`		`- } finally {`
`709`	`708`	`dbLedgerStorageStats.getReadAheadBatchCountStats().registerFailedValue(count);`
`710`	`709`	`dbLedgerStorageStats.getReadAheadBatchSizeStats().registerFailedValue(size);`
`711`	`710`	`recordFailedEvent(dbLedgerStorageStats.getReadAheadTime(),readAheadStartNano);`