Skip to content

Commit d580030

Browse files
authored
BIGTOP-4508: Fix datanode and nodemanager unable to create multi disk directories (#280)
1 parent 6e907c4 commit d580030

File tree

1 file changed

+22
-14
lines changed
  • bigtop-manager-stack/bigtop-manager-stack-bigtop/src/main/java/org/apache/bigtop/manager/stack/bigtop/v3_3_0/hadoop

1 file changed

+22
-14
lines changed

bigtop-manager-stack/bigtop-manager-stack-bigtop/src/main/java/org/apache/bigtop/manager/stack/bigtop/v3_3_0/hadoop/HadoopSetup.java

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -82,22 +82,30 @@ public static ShellResult configure(Params params, String componentName) {
8282
hadoopGroup,
8383
Constants.PERMISSION_755,
8484
true);
85-
LinuxFileUtils.createDirectories(
86-
hadoopParams.getDfsDataDir(), hadoopUser, hadoopGroup, Constants.PERMISSION_755, true);
85+
if (StringUtils.isNotBlank(hadoopParams.getDfsDataDir())) {
86+
String[] dfsDataDirs = hadoopParams.getDfsDataDir().split("\\s*,\\s*");
87+
for (String dir : dfsDataDirs) {
88+
LinuxFileUtils.createDirectories(
89+
dir, hadoopUser, hadoopGroup, Constants.PERMISSION_755, true);
90+
}
91+
}
8792
}
8893
case "nodemanager": {
89-
LinuxFileUtils.createDirectories(
90-
hadoopParams.getNodeManagerLogDir(),
91-
hadoopUser,
92-
hadoopGroup,
93-
Constants.PERMISSION_755,
94-
true);
95-
LinuxFileUtils.createDirectories(
96-
hadoopParams.getNodeManagerLocalDir(),
97-
hadoopUser,
98-
hadoopGroup,
99-
Constants.PERMISSION_755,
100-
true);
94+
if (StringUtils.isNotBlank(hadoopParams.getNodeManagerLogDir())) {
95+
String[] nmLogDirs = hadoopParams.getNodeManagerLogDir().split("\\s*,\\s*");
96+
for (String dir : nmLogDirs) {
97+
LinuxFileUtils.createDirectories(
98+
dir, hadoopUser, hadoopGroup, Constants.PERMISSION_755, true);
99+
}
100+
}
101+
if (StringUtils.isNotBlank(hadoopParams.getNodeManagerLocalDir())) {
102+
String[] nmLocalDirs =
103+
hadoopParams.getNodeManagerLocalDir().split("\\s*,\\s*");
104+
for (String dir : nmLocalDirs) {
105+
LinuxFileUtils.createDirectories(
106+
dir, hadoopUser, hadoopGroup, Constants.PERMISSION_755, true);
107+
}
108+
}
101109
}
102110
}
103111
}

0 commit comments

Comments
 (0)