fix(client): simplify MessageProducer send calls by removing redundant destination parameter

calling send(destination, message) on fixed-destination producers — a JMS spec violation that the old code silently allowed

Author: jeanouii

activemq-broker/src/test/java/org/apache/activemq/bugs/AMQ7085Test.java

@@ -62,7 +62,7 @@ public void setUp() throws Exception {
             final Message toSend = session.createMessage();
             toSend.setStringProperty("foo", "bar");
             final MessageProducer producer = session.createProducer(queue);
-            producer.send(queue, toSend);
+            producer.send(toSend);
         } finally {
             conn.close();
         }

activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ4361Test.java

@@ -113,7 +113,7 @@ public void run() {
                         lastLoop.set(System.currentTimeMillis());
                         ObjectMessage objMsg = session.createObjectMessage();
                         objMsg.setObject(data);
-                        producer.send(destination, objMsg);
+                        producer.send(objMsg);
                     }
                 } catch (Exception e) {
                     publishException.set(e);

activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ6059Test.java

@@ -173,7 +173,7 @@ private void sendMessage(Destination destination) throws Exception {
         connection.start();
         Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
         MessageProducer producer = session.createProducer(destination);
-        producer.send(destination, session.createTextMessage("DLQ message"), DeliveryMode.PERSISTENT, 4, 1000);
+        producer.send(session.createTextMessage("DLQ message"), DeliveryMode.PERSISTENT, 4, 1000);
         connection.stop();
         LOG.info("### Send message that will expire.");
     }

activemq-unit-tests/src/test/java/org/apache/activemq/bugs/MemoryUsageBlockResumeTest.java

@@ -112,7 +112,7 @@ public void run() {
                     producer.setDeliveryMode(deliveryMode);
                     for (int idx = 0; idx < toSend; ++idx) {
                         Message message = session.createTextMessage(new String(buf) + idx);
-                        producer.send(destination, message);
+                        producer.send(message);
                         messagesSent.incrementAndGet();
                         LOG.info("After little:" + idx + ", System Memory Usage " + broker.getSystemUsage().getMemoryUsage().getPercentUsage());
                     }
@@ -132,7 +132,7 @@ public void run() {
                     producer.setDeliveryMode(deliveryMode);
                     for (int idx = 0; idx < toSend; ++idx) {
                         Message message = session.createTextMessage(new String(buf) + idx);
-                        producer.send(destination, message);
+                        producer.send(message);
                         messagesSent.incrementAndGet();
                         LOG.info("After little:" + idx + ", System Memory Usage " + broker.getSystemUsage().getMemoryUsage().getPercentUsage());
                     }

activemq-unit-tests/src/test/java/org/apache/activemq/transport/failover/InitalReconnectDelayTest.java

@@ -129,7 +129,7 @@ public void transportResumed() {
 
         LOG.info("Attempting to send... failover should throw on disconnect");
         try {
-            producer.send(destination, message);
+            producer.send(message);
             fail("Expect IOException to bubble up on send");
         } catch (jakarta.jms.IllegalStateException producerClosed) {
         }