fix(client): validate inputs before UnsupportedOperationException in shared consumer methods (#1719)

The shared consumer methods (createSharedConsumer, createSharedDurableConsumer)
threw UnsupportedOperationException immediately without validating inputs.
Per the JMS spec, parameter validation must happen first:

- Session: null topic now throws InvalidDestinationException, invalid
  selector now throws InvalidSelectorException
- JMSContext: null topic now throws InvalidDestinationRuntimeException

This fixes the TCK invalidDestinationExceptionTests and
invalidSelectorExceptionTopicTests for Session, and the corresponding
JMSContext tests.

Author: jeanouii

activemq-client/src/main/java/org/apache/activemq/ActiveMQContext.java

@@ -25,6 +25,7 @@
 import jakarta.jms.Destination;
 import jakarta.jms.ExceptionListener;
 import jakarta.jms.IllegalStateRuntimeException;
+import jakarta.jms.InvalidDestinationRuntimeException;
 import jakarta.jms.JMSConsumer;
 import jakarta.jms.JMSContext;
 import jakarta.jms.JMSException;
@@ -442,21 +443,37 @@ public JMSConsumer createDurableConsumer(Topic topic, String name, String messag
 
     @Override
     public JMSConsumer createSharedDurableConsumer(Topic topic, String name) {
+        checkContextState();
+        if (topic == null) {
+            throw new InvalidDestinationRuntimeException("Topic cannot be null");
+        }
         throw new UnsupportedOperationException("createSharedDurableConsumer(topic, name) is not supported");
     }
 
     @Override
     public JMSConsumer createSharedDurableConsumer(Topic topic, String name, String messageSelector) {
-        throw new UnsupportedOperationException("createDurableConsumer(topic, name, messageSelector) is not supported");
+        checkContextState();
+        if (topic == null) {
+            throw new InvalidDestinationRuntimeException("Topic cannot be null");
+        }
+        throw new UnsupportedOperationException("createSharedDurableConsumer(topic, name, messageSelector) is not supported");
     }
 
     @Override
     public JMSConsumer createSharedConsumer(Topic topic, String sharedSubscriptionName) {
+        checkContextState();
+        if (topic == null) {
+            throw new InvalidDestinationRuntimeException("Topic cannot be null");
+        }
         throw new UnsupportedOperationException("createSharedConsumer(topic, sharedSubscriptionName) is not supported");
     }
 
     @Override
     public JMSConsumer createSharedConsumer(Topic topic, String sharedSubscriptionName, String messageSelector) {
+        checkContextState();
+        if (topic == null) {
+            throw new InvalidDestinationRuntimeException("Topic cannot be null");
+        }
         throw new UnsupportedOperationException("createSharedConsumer(topic, sharedSubscriptionName, messageSelector) is not supported");
     }
 

activemq-client/src/main/java/org/apache/activemq/ActiveMQSession.java

@@ -58,6 +58,7 @@
 import jakarta.jms.TopicSubscriber;
 import jakarta.jms.TransactionRolledBackException;
 
+import org.apache.activemq.selector.SelectorParser;
 import org.apache.activemq.blob.BlobDownloader;
 import org.apache.activemq.blob.BlobTransferPolicy;
 import org.apache.activemq.blob.BlobUploader;
@@ -1386,11 +1387,22 @@ public Topic createTopic(String topicName) throws JMSException {
 
     @Override
     public MessageConsumer createSharedConsumer(Topic topic, String sharedSubscriptionName) throws JMSException {
+        checkClosed();
+        if (topic == null) {
+            throw new InvalidDestinationException("Topic cannot be null");
+        }
         throw new UnsupportedOperationException("createSharedConsumer(Topic, sharedSubscriptionName) is not supported");
     }
 
     @Override
     public MessageConsumer createSharedConsumer(Topic topic, String sharedSubscriptionName, String messageSelector) throws JMSException {
+        checkClosed();
+        if (topic == null) {
+            throw new InvalidDestinationException("Topic cannot be null");
+        }
+        if (messageSelector != null && !messageSelector.trim().isEmpty()) {
+            SelectorParser.parse(messageSelector);
+        }
         throw new UnsupportedOperationException("createSharedConsumer(Topic, sharedSubscriptionName, messageSelector) is not supported");
     }
 
@@ -1408,11 +1420,22 @@ public MessageConsumer createDurableConsumer(Topic topic, String name, String me
 
     @Override
     public MessageConsumer createSharedDurableConsumer(Topic topic, String name) throws JMSException {
+        checkClosed();
+        if (topic == null) {
+            throw new InvalidDestinationException("Topic cannot be null");
+        }
         throw new UnsupportedOperationException("createSharedDurableConsumer(Topic, name) is not supported");
     }
 
     @Override
     public MessageConsumer createSharedDurableConsumer(Topic topic, String name, String messageSelector) throws JMSException {
+        checkClosed();
+        if (topic == null) {
+            throw new InvalidDestinationException("Topic cannot be null");
+        }
+        if (messageSelector != null && !messageSelector.trim().isEmpty()) {
+            SelectorParser.parse(messageSelector);
+        }
         throw new UnsupportedOperationException("createSharedDurableConsumer(Topic, name, messageSelector) is not supported");
     }