Skip to content

Commit 6ac42a6

Browse files
committed
upd agents.md
1 parent 5fb3230 commit 6ac42a6

1 file changed

Lines changed: 41 additions & 20 deletions

File tree

.github/AGENTS.md

Lines changed: 41 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Use this file to drive an AI assistant that helps authors meet **Ansys developer
1313

1414
### Finding severity
1515

16-
Compliance reviews, narrative feedback, and **`documentation-compliance-report.md`** must apply **§0.7** consistently: each **issue** and each **action item** gets one severity; optional **category** labels supplement but do not replace severity.
16+
Compliance reviews, narrative feedback, and **`documentation-compliance-report.md`** must apply **§0.7** consistently: each **issue** and each **action item** gets one severity; optional **category** labels supplement but do not replace severity. For findings tied to a tagged guideline requirement, use that item’s **Must have** / **Should have** / **Nice to have** tag (see **§0.7** tagged sources) and map it to **Must fix** / **Should fix** / **Nice to fix**.
1717

1818
### Recording pass vs fail (reports and chat)
1919

@@ -171,13 +171,33 @@ When in doubt, state **ambiguous** classification in **`documentation-compliance
171171

172172
Assign **exactly one severity** per issue and per action item. Do not mix severities for a single bullet (split into separate items if needed).
173173

174+
**Requirement priority in guidelines**
175+
176+
Tagged sources (use the tag on the matching requirement when reporting a finding):
177+
178+
- [Documentation compliance checklist](https://github.com/ansys-internal/developer-documentation-guidelines/blob/main/content/docs/common-practices/documentation-checklist.md) — every checklist item
179+
- [Metadata configuration](https://github.com/ansys-internal/developer-documentation-guidelines/blob/main/content/docs/migrate-dev-portal/migrate-package/metadata.md) — mandatory fields, REST structure, metadata table **Priority** column
180+
- [Writing guidelines](https://github.com/ansys-internal/developer-documentation-guidelines/tree/main/content/docs/writing-guidelines) — API and library/SDK descriptive and reference pages
181+
- [Migrate package guides](https://github.com/ansys-internal/developer-documentation-guidelines/tree/main/content/docs/migrate-dev-portal/migrate-package)`package-type-matrix`, `md-package`, `http-package`, `doxygen-package`
182+
- [Markdown guide](https://github.com/ansys-internal/developer-documentation-guidelines/blob/main/content/docs/common-practices/markdown-guide.md) and [Style guide](https://github.com/ansys-internal/developer-documentation-guidelines/blob/main/content/docs/common-practices/styleguide.md) — tagged structural and style rules
183+
184+
When a tagged requirement is not met, use the matching review severity:
185+
186+
| Guideline tag | Review severity when not met |
187+
|---------------|------------------------------|
188+
| **Must have** | **Must fix** |
189+
| **Should have** | **Should fix** |
190+
| **Nice to have** | **Nice to fix** |
191+
192+
If a finding is not covered by a tagged checklist line (for example, a defect found only in Part 2 of this file), apply the severities table below. When both apply, the checklist tag takes precedence for that requirement.
193+
174194
**Severities**
175195

176196
| Severity | Use when | Effect on overall summary |
177197
|----------|----------|---------------------------|
178-
| **Must fix** | Violates an explicit rubric or portal requirement; breaks build, metadata, or taxonomy contracts; invalid or missing OpenAPI where required; or would **materially mislead** developers (wrong auth, wrong endpoints, contradictory versions, unsafe guidance). | **Not Approved** / **Needs Major Revisions** while any **Must fix** remains open. |
179-
| **Should fix** | Misses rubric expectations or clearly hurts completeness, accuracy, or usability; authors should resolve before release when practical. | Drives **Needs Major Revisions** if widespread or blocking key flows; otherwise **Needs Minor Revisions**. |
180-
| **Nice to fix** | Polish, consistency, or optional improvements; does not block policy or correctness. | Cited under **Needs Minor Revisions** or recommendations; does not block **Approved** by itself. |
198+
| **Must fix** | An unmet **Must have** checklist item; violates an explicit rubric or portal requirement; breaks build, metadata, or taxonomy contracts; invalid or missing OpenAPI where required; or would **materially mislead** developers (wrong auth, wrong endpoints, contradictory versions, unsafe guidance). | **Not Approved** / **Needs Major Revisions** while any **Must fix** remains open. |
199+
| **Should fix** | An unmet **Should have** checklist item; misses rubric expectations or clearly hurts completeness, accuracy, or usability; authors should resolve before release when practical. | Drives **Needs Major Revisions** if widespread or blocking key flows; otherwise **Needs Minor Revisions**. |
200+
| **Nice to fix** | An unmet **Nice to have** checklist item; polish, consistency, or optional improvements; does not block policy or correctness. | Cited under **Needs Minor Revisions** or recommendations; does not block **Approved** by itself. |
181201

182202
**Default mapping to summary line**
183203

@@ -316,7 +336,7 @@ Assign **exactly one severity** per issue and per action item. Do not mix severi
316336
- [ ] **`description/index.md`** for REST API descriptive content (introduction, how to call the API, examples, and related guidance)
317337
- [ ] **`changelog/changelog.md`** for release history
318338

319-
**Not required** for **REST API-only** packages: **`toc.yml`**, a root-level **`index.md`**, and an **`index.md`** in every subdirectory. Do not treat their absence as a defect unless **§0** also classifies the package as **API** (prose-only) or **Library/SDK** where those files apply.
339+
**Not required** for **REST API-only** packages: **`toc.yml`**, a root-level **`index.md`**, and **`index.md` in every subdirectory**. For **API** (prose) and **Library/SDK** packages, root **`index.md`** is required; **`index.md` in each subdirectory** is **Nice to have** only—do not report missing subsection `index.md` files as **Must fix** or **Should fix**.
320340

321341
**Review Actions:**
322342
- Confirm `docfx.json` and OpenAPI/Swagger spec file are present at package root
@@ -356,18 +376,18 @@ Assign **exactly one severity** per issue and per action item. Do not mix severi
356376
- Check that protocol is explicitly stated and accurately described
357377
- Confirm testing information is complete and actionable
358378

359-
#### 3.2.2 Platform Overview Section
379+
#### 3.2.2 Platform Overview Section (**Nice to have** for **API** and **REST API**)
360380

361-
**Required elements:**
381+
The **Platform overview** section is optional. Do not report a missing section as **Must fix** or **Should fix**. If the section is present, apply the guidance below (**Nice to fix** at most when content is thin or unclear).
382+
383+
**When present, recommended content:**
362384
- [ ] **Explanatory diagram**: Visual showing API relationships with applications and services
363385
- [ ] **Application development**: Description of applications developers can create
364386
- [ ] **Communication flow**: Explicit explanation of communication pathways between applications and API/services
365387

366388
**Review Actions:**
367-
- Verify diagram exists and clearly illustrates architecture
368-
- Check that diagram uses consistent terminology with text
369-
- Ensure application development section provides concrete examples
370-
- Verify communication flow describes data exchange patterns
389+
- If **Platform overview** is absent, omit from **Issues** or note only under **Recommendations** as **Nice to fix**
390+
- When the section exists, verify diagram, application development, and communication flow quality as optional improvements
371391

372392
#### 3.2.3 Resources Section (REST APIs only)
373393

@@ -546,7 +566,7 @@ Assign **exactly one severity** per issue and per action item. Do not mix severi
546566
- [ ] Sections separated with descriptive comments
547567
- [ ] Comments use `//` or `/** */` syntax (compatible with protoc-gen-doc)
548568
- [ ] Markdown syntax used in comments where appropriate (bold, italic, lists, code)
549-
- [ ] Mathematical formulas formatted correctly if used
569+
- [ ] **Must have**Mathematical formulas use correct LaTeX syntax per [Markdown guide — Formulas](/docs/common-practices/markdown-guide#formulas) when present (block `$$`, inline `$`; **Must fix** if used and invalid)
550570

551571
#### 3.5.3 Message Documentation
552572

@@ -697,7 +717,7 @@ service UserService {
697717
- [ ] `index.md` exists at root level (landing page with introduction)
698718
- [ ] Changelog file exists (`changelog.md` at root or `changelog/changelog.md`)
699719

700-
**Recommended structure:**
720+
**Recommended structure** (subdirectory `index.md` files are **Nice to have**, not mandatory):
701721
```
702722
Documentation-package/
703723
|-- index.md
@@ -727,7 +747,7 @@ Documentation-package/
727747
**Review Actions:**
728748
- Verify required files exist
729749
- Check directory structure is logical and organized
730-
- Ensure each subdirectory has `index.md`
750+
- Optionally note missing subdirectory `index.md` files as **Nice to fix** only (not required in every folder)
731751
- Verify file names use lowercase with hyphens
732752

733753
### 4.2 Index.md Content Review
@@ -748,18 +768,19 @@ Documentation-package/
748768
- Check that supported languages/OS are explicitly listed
749769
- Ensure installation requirements are mentioned
750770

751-
#### 4.2.2 Platform Overview
771+
#### 4.2.2 Platform overview in Introduction (**Nice to have** for **Library/SDK**)
752772

753-
**Required elements:**
773+
Platform overview content is optional and is usually part of the **Introduction** in `index.md`, not a separate mandatory section. Do not report missing platform overview material as **Must fix** or **Should fix**.
774+
775+
**When present in the introduction, recommended content:**
754776
- [ ] Context and relationship with other services
755777
- [ ] Explanatory diagram showing architecture
756778
- [ ] Application development description (what can be built)
757779
- [ ] Integration explanation (how library fits in ecosystem)
758780

759781
**Review Actions:**
760-
- Verify diagram exists and is clear
761-
- Check architecture explanation is complete
762-
- Ensure integration guidance is provided
782+
- If platform overview content is absent, omit from **Issues** or note only under **Recommendations** as **Nice to fix**
783+
- When present, review diagram, architecture, and integration content as optional improvements
763784

764785
### 4.3 Getting Started Section
765786

@@ -920,7 +941,7 @@ Same requirements as API changelog (see section 3.3)
920941
- [ ] `index.md` at root level (required for **API** / **Library/SDK**; for **REST API-only**, use `description/index.md` per §3.1.1)
921942
- [ ] Changelog file exists (required for **API** / **Library/SDK** at `changelog.md` root or `changelog/changelog.md`; for **REST API-only**, use `changelog/changelog.md` per §3.1.1)
922943
- [ ] Related content in logical subdirectories
923-
- [ ] Each subdirectory has `index.md` (expectation for **Library/SDK**-style trees; not for **REST API-only**)
944+
- [ ] Each subdirectory has `index.md` (**Nice to have** for **Library/SDK**-style trees; not for **REST API-only**—absence is **Nice to fix** at most, not **Must fix** / **Should fix**)
924945
- [ ] Images in dedicated `images/` directory
925946
- [ ] File names use lowercase with hyphens (e.g., `getting-started.md`)
926947

0 commit comments

Comments
 (0)