Skip to content

Commit 9aa4252

Browse files
committed
fix(data): address PR review feedback for AC/TA entries
- Change AC and TA partOf from 'GB' to 'SH' (subdivision of Saint Helena) - Change TA currency from GBP to SHP for consistency with SH/AC - Add partOf: 'GB' to SH to complete territory hierarchy (AC/TA → SH → GB) - Update test description to reflect Latin Extended character support
1 parent 9cc59a9 commit 9aa4252

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/countries/src/data/countries.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export const countries = {
99
capital: 'Georgetown',
1010
currency: ['SHP'],
1111
languages: ['en'],
12-
partOf: 'GB',
12+
partOf: 'SH',
1313
},
1414
AD: {
1515
name: 'Andorra',
@@ -1808,6 +1808,7 @@ export const countries = {
18081808
capital: 'Jamestown',
18091809
currency: ['SHP'],
18101810
languages: ['en'],
1811+
partOf: 'GB',
18111812
},
18121813
SI: {
18131814
name: 'Slovenia',
@@ -1941,9 +1942,9 @@ export const countries = {
19411942
phone: [290],
19421943
continent: 'AF',
19431944
capital: 'Edinburgh of the Seven Seas',
1944-
currency: ['GBP'],
1945+
currency: ['SHP'],
19451946
languages: ['en'],
1946-
partOf: 'GB',
1947+
partOf: 'SH',
19471948
},
19481949
TC: {
19491950
name: 'Turks and Caicos Islands',

packages/test-js/index.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe('dist', () => {
3636
}
3737
})
3838

39-
test('all English country names should contain only A-Z characters', () => {
39+
test('all English country names should contain only Latin letters, spaces, and common punctuation', () => {
4040
const nameReg = /^[a-z\u00C0-\u024F\s.()-]+$/i
4141
const nonAZ: string[] = []
4242
for (const c of Object.values(source.countries)) {

0 commit comments

Comments
 (0)