Hide exceptionHandler on pubsub

Author: tolyo

src/services/pubsub/pubsub.spec.js

@@ -17,7 +17,7 @@ describe("PubSub", function () {
   let pubsub;
 
   beforeEach(function () {
-    pubsub = new PubSub();
+    pubsub = new PubSub(() => undefined);
   });
 
   afterEach(function () {
@@ -31,7 +31,7 @@ describe("PubSub", function () {
   });
 
   it("should provide injecables", function () {
-    expect(pubsub.$exceptionHandler).not.toBeNull();
+    expect(pubsub._exceptionHandler).not.toBeNull();
   });
 
   it("should dispose of the PubSub instance", function () {
@@ -429,23 +429,23 @@ describe("PubSub", function () {
 
     it("should delegate to exception handler if an error is thrown", async function () {
       let thrown = false;
-      let throwErro = new Error();
+      let thrownError = new Error();
       let receivedErr;
 
-      pubsub.$exceptionHandler = (err) => {
+      pubsub = new PubSub((err) => {
         thrown = true;
         receivedErr = err;
-      };
+      });
 
       pubsub.subscribe(SOME_TOPIC, () => {
-        throw throwErro;
+        throw thrownError;
       });
 
       pubsub.publish(SOME_TOPIC);
       await wait();
 
       expect(thrown).toBe(true);
-      expect(receivedErr).toBe(throwErro);
+      expect(receivedErr).toBe(thrownError);
     });
   });
 });

src/services/pubsub/pubsub.ts

@@ -36,8 +36,8 @@ export class PubSub {
   private _topics: Record<string, ListenerEntry[]>;
   /** @internal */
   private _disposed: boolean;
-  /** Exception handler used when a subscriber throws during async delivery. */
-  public $exceptionHandler: ng.ExceptionHandlerService;
+  /** @internal */
+  private _exceptionHandler: ng.ExceptionHandlerService;
 
   /**
    * Create a publish/subscribe event bus.
@@ -50,7 +50,7 @@ export class PubSub {
   constructor($exceptionHandler: ng.ExceptionHandlerService) {
     this._topics = nullObject() as Record<string, ListenerEntry[]>;
     this._disposed = false;
-    this.$exceptionHandler = $exceptionHandler;
+    this._exceptionHandler = $exceptionHandler;
   }
 
   /**
@@ -204,7 +204,7 @@ export class PubSub {
         try {
           fn.apply(context, args);
         } catch (err) {
-          this.$exceptionHandler(err);
+          this._exceptionHandler(err);
         }
       }
     });