Skip to content

Commit 50567fb

Browse files
authored
Merge pull request #488 from angeles-bilbao6/issue487/jetsnack
[Jetsnack] UI Polish
2 parents e830e63 + 266195e commit 50567fb

File tree

7 files changed

+69
-11
lines changed

7 files changed

+69
-11
lines changed

Jetsnack/app/src/main/java/com/example/jetsnack/ui/components/Snacks.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,18 +122,18 @@ private fun HighlightedSnacks(
122122
modifier: Modifier = Modifier
123123
) {
124124
val scroll = rememberScrollState(0)
125-
val gradient = when (index % 2) {
125+
val gradient = when ((index / 2) % 2) {
126126
0 -> JetsnackTheme.colors.gradient6_1
127127
else -> JetsnackTheme.colors.gradient6_2
128128
}
129129
// The Cards show a gradient which spans 3 cards and scrolls with parallax.
130130
val gradientWidth = with(LocalDensity.current) {
131-
(3 * (HighlightCardWidth + HighlightCardPadding).toPx())
131+
(6 * (HighlightCardWidth + HighlightCardPadding).toPx())
132132
}
133133
LazyRow(
134134
modifier = modifier,
135135
horizontalArrangement = Arrangement.spacedBy(16.dp),
136-
contentPadding = PaddingValues(start = 16.dp, end = 16.dp)
136+
contentPadding = PaddingValues(start = 24.dp, end = 24.dp)
137137
) {
138138
itemsIndexed(snacks) { index, snack ->
139139
HighlightSnackItem(

Jetsnack/app/src/main/java/com/example/jetsnack/ui/home/Profile.kt

Lines changed: 34 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,51 @@
1616

1717
package com.example.jetsnack.ui.home
1818

19+
import androidx.compose.foundation.Image
20+
import androidx.compose.foundation.layout.Column
21+
import androidx.compose.foundation.layout.Spacer
1922
import androidx.compose.foundation.layout.fillMaxSize
23+
import androidx.compose.foundation.layout.fillMaxWidth
24+
import androidx.compose.foundation.layout.height
25+
import androidx.compose.foundation.layout.padding
2026
import androidx.compose.foundation.layout.wrapContentSize
27+
import androidx.compose.material.MaterialTheme
2128
import androidx.compose.material.Text
2229
import androidx.compose.runtime.Composable
30+
import androidx.compose.ui.Alignment
2331
import androidx.compose.ui.Modifier
32+
import androidx.compose.ui.res.painterResource
2433
import androidx.compose.ui.res.stringResource
34+
import androidx.compose.ui.text.style.TextAlign
35+
import androidx.compose.ui.unit.dp
2536
import com.example.jetsnack.R
2637

2738
@Composable
2839
fun Profile(modifier: Modifier = Modifier) {
29-
Text(
30-
text = stringResource(R.string.home_profile),
40+
Column(
41+
horizontalAlignment = Alignment.CenterHorizontally,
3142
modifier = modifier
3243
.fillMaxSize()
3344
.wrapContentSize()
34-
)
45+
.padding(24.dp)
46+
) {
47+
Image(
48+
painterResource(R.drawable.empty_state_search),
49+
contentDescription = null
50+
)
51+
Spacer(Modifier.height(24.dp))
52+
Text(
53+
text = stringResource(R.string.work_in_progress),
54+
style = MaterialTheme.typography.subtitle1,
55+
textAlign = TextAlign.Center,
56+
modifier = Modifier.fillMaxWidth()
57+
)
58+
Spacer(Modifier.height(16.dp))
59+
Text(
60+
text = stringResource(R.string.grab_beverage),
61+
style = MaterialTheme.typography.body2,
62+
textAlign = TextAlign.Center,
63+
modifier = Modifier.fillMaxWidth()
64+
)
65+
}
3566
}

Jetsnack/app/src/main/java/com/example/jetsnack/ui/home/cart/Cart.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ import androidx.compose.ui.graphics.RectangleShape
4848
import androidx.compose.ui.layout.LastBaseline
4949
import androidx.compose.ui.platform.LocalContext
5050
import androidx.compose.ui.res.stringResource
51+
import androidx.compose.ui.text.style.TextAlign
5152
import androidx.compose.ui.text.style.TextOverflow
5253
import androidx.compose.ui.tooling.preview.Preview
5354
import androidx.compose.ui.unit.dp
@@ -373,7 +374,10 @@ private fun CheckoutBar(modifier: Modifier = Modifier) {
373374
.weight(1f)
374375
) {
375376
Text(
376-
text = stringResource(id = R.string.cart_checkout)
377+
text = stringResource(id = R.string.cart_checkout),
378+
modifier = Modifier.fillMaxWidth(),
379+
textAlign = TextAlign.Left,
380+
maxLines = 1
377381
)
378382
}
379383
}

Jetsnack/app/src/main/java/com/example/jetsnack/ui/home/search/Categories.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ private fun SearchCategoryCollection(
7979
VerticalGrid(Modifier.padding(horizontal = 16.dp)) {
8080
val gradient = when (index % 2) {
8181
0 -> JetsnackTheme.colors.gradient2_2
82-
else -> JetsnackTheme.colors.gradient3_2
82+
else -> JetsnackTheme.colors.gradient2_3
8383
}
8484
collection.categories.forEach { category ->
8585
SearchCategory(

Jetsnack/app/src/main/java/com/example/jetsnack/ui/snackdetail/SnackDetail.kt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ import androidx.compose.ui.graphics.graphicsLayer
5050
import androidx.compose.ui.layout.Layout
5151
import androidx.compose.ui.platform.LocalDensity
5252
import androidx.compose.ui.res.stringResource
53+
import androidx.compose.ui.text.style.TextAlign
5354
import androidx.compose.ui.tooling.preview.Preview
5455
import androidx.compose.ui.unit.Constraints
5556
import androidx.compose.ui.unit.dp
@@ -110,7 +111,7 @@ private fun Header() {
110111
modifier = Modifier
111112
.height(280.dp)
112113
.fillMaxWidth()
113-
.background(Brush.horizontalGradient(JetsnackTheme.colors.interactivePrimary))
114+
.background(Brush.horizontalGradient(JetsnackTheme.colors.tornado1))
114115
)
115116
}
116117

@@ -163,7 +164,7 @@ private fun Body(
163164
color = JetsnackTheme.colors.textHelp,
164165
modifier = HzPadding
165166
)
166-
Spacer(Modifier.height(4.dp))
167+
Spacer(Modifier.height(16.dp))
167168
Text(
168169
text = stringResource(R.string.detail_placeholder),
169170
style = MaterialTheme.typography.body1,
@@ -328,6 +329,8 @@ private fun CartBottomBar(modifier: Modifier = Modifier) {
328329
) {
329330
Text(
330331
text = stringResource(R.string.add_to_cart),
332+
modifier = Modifier.fillMaxWidth(),
333+
textAlign = TextAlign.Center,
331334
maxLines = 1
332335
)
333336
}

Jetsnack/app/src/main/java/com/example/jetsnack/ui/theme/Theme.kt

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import com.example.jetsnack.ui.utils.LocalSysUiController
3333

3434
private val LightColorPalette = JetsnackColors(
3535
brand = Shadow5,
36+
brandSecondary = Ocean3,
3637
uiBackground = Neutral0,
3738
uiBorder = Neutral4,
3839
uiFloated = FunctionalGrey,
@@ -50,11 +51,14 @@ private val LightColorPalette = JetsnackColors(
5051
gradient3_2 = listOf(Rose2, Lavender3, Rose4),
5152
gradient2_1 = listOf(Shadow4, Shadow11),
5253
gradient2_2 = listOf(Ocean3, Shadow3),
54+
gradient2_3 = listOf(Lavender3, Rose2),
55+
tornado1 = listOf(Shadow4, Ocean3),
5356
isDark = false
5457
)
5558

5659
private val DarkColorPalette = JetsnackColors(
5760
brand = Shadow1,
61+
brandSecondary = Ocean2,
5862
uiBackground = Neutral8,
5963
uiBorder = Neutral3,
6064
uiFloated = FunctionalDarkGrey,
@@ -73,7 +77,9 @@ private val DarkColorPalette = JetsnackColors(
7377
gradient3_1 = listOf(Shadow9, Ocean7, Shadow5),
7478
gradient3_2 = listOf(Rose8, Lavender7, Rose11),
7579
gradient2_1 = listOf(Ocean3, Shadow3),
76-
gradient2_2 = listOf(Ocean7, Shadow7),
80+
gradient2_2 = listOf(Ocean4, Shadow2),
81+
gradient2_3 = listOf(Lavender3, Rose3),
82+
tornado1 = listOf(Shadow4, Ocean3),
7783
isDark = true
7884
)
7985

@@ -118,7 +124,9 @@ class JetsnackColors(
118124
gradient3_2: List<Color>,
119125
gradient2_1: List<Color>,
120126
gradient2_2: List<Color>,
127+
gradient2_3: List<Color>,
121128
brand: Color,
129+
brandSecondary: Color,
122130
uiBackground: Color,
123131
uiBorder: Color,
124132
uiFloated: Color,
@@ -130,6 +138,7 @@ class JetsnackColors(
130138
textHelp: Color,
131139
textInteractive: Color,
132140
textLink: Color,
141+
tornado1: List<Color>,
133142
iconPrimary: Color = brand,
134143
iconSecondary: Color,
135144
iconInteractive: Color,
@@ -150,8 +159,12 @@ class JetsnackColors(
150159
private set
151160
var gradient2_2 by mutableStateOf(gradient2_2)
152161
private set
162+
var gradient2_3 by mutableStateOf(gradient2_3)
163+
private set
153164
var brand by mutableStateOf(brand)
154165
private set
166+
var brandSecondary by mutableStateOf(brandSecondary)
167+
private set
155168
var uiBackground by mutableStateOf(uiBackground)
156169
private set
157170
var uiBorder by mutableStateOf(uiBorder)
@@ -172,6 +185,8 @@ class JetsnackColors(
172185
private set
173186
var textInteractive by mutableStateOf(textInteractive)
174187
private set
188+
var tornado1 by mutableStateOf(tornado1)
189+
private set
175190
var textLink by mutableStateOf(textLink)
176191
private set
177192
var iconPrimary by mutableStateOf(iconPrimary)
@@ -196,7 +211,9 @@ class JetsnackColors(
196211
gradient3_2 = other.gradient3_2
197212
gradient2_1 = other.gradient2_1
198213
gradient2_2 = other.gradient2_2
214+
gradient2_3 = other.gradient2_3
199215
brand = other.brand
216+
brandSecondary = other.brandSecondary
200217
uiBackground = other.uiBackground
201218
uiBorder = other.uiBorder
202219
uiFloated = other.uiFloated
@@ -208,6 +225,7 @@ class JetsnackColors(
208225
textHelp = other.textHelp
209226
textInteractive = other.textInteractive
210227
textLink = other.textLink
228+
tornado1 = other.tornado1
211229
iconPrimary = other.iconPrimary
212230
iconSecondary = other.iconSecondary
213231
iconInteractive = other.iconInteractive

Jetsnack/app/src/main/res/values/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,7 @@
5858
<!-- Quantity Selector -->
5959
<string name="label_increase">Increase</string>
6060
<string name="label_decrease">Decrease</string>
61+
<string name="work_in_progress">This is currently work in progress</string>
62+
<string name="grab_beverage">Grab a beverage and check back later!</string>
6163

6264
</resources>

0 commit comments

Comments
 (0)