Refactor command return values to use Command.SINGLE_SUCCESS for consistency

Author: duzos

src/main/java/dev/amble/lib/client/command/ClientScriptCommand.java

@@ -1,5 +1,6 @@
 package dev.amble.lib.client.command;
 
+import com.mojang.brigadier.Command;
 import com.mojang.brigadier.CommandDispatcher;
 import com.mojang.brigadier.arguments.StringArgumentType;
 import com.mojang.brigadier.context.CommandContext;
@@ -248,6 +249,6 @@ private static int listAvailable(CommandContext<FabricClientCommandSource> conte
 					statusIcon.copy().append(Text.literal(id.getNamespace() + ":" + displayId).formatted(Formatting.WHITE))
 			);
 		}
-		return 1;
+		return Command.SINGLE_SUCCESS;
 	}
 }

src/main/java/dev/amble/lib/command/PlayAnimationCommand.java

@@ -1,5 +1,6 @@
 package dev.amble.lib.command;
 
+import com.mojang.brigadier.Command;
 import com.mojang.brigadier.CommandDispatcher;
 import com.mojang.brigadier.arguments.BoolArgumentType;
 import com.mojang.brigadier.arguments.StringArgumentType;
@@ -45,6 +46,6 @@ private static int execute(CommandContext<ServerCommandSource> context) {
 
 		String name = target.getEntityName();
 		context.getSource().sendFeedback(() -> Text.literal("Playing animation "+ animationId +" on "+ name), true);
-		return 1;
+		return Command.SINGLE_SUCCESS;
 	}
 }

src/main/java/dev/amble/lib/command/ServerScriptCommand.java

@@ -33,10 +33,6 @@ public class ServerScriptCommand {
 	private static final String SCRIPT_PREFIX = "script/";
 	private static final String SCRIPT_SUFFIX = ".lua";
 
-	private static String translationKey(String key) {
-		return "command." + AmbleKit.MOD_ID + ".script." + key;
-	}
-
 	/**
 	 * Converts a full script identifier to a display-friendly format.
 	 * Removes the "script/" prefix and ".lua" suffix.
@@ -116,9 +112,8 @@ private static int execute(CommandContext<ServerCommandSource> context, String a
 		try {
 			LuaScript script = ServerScriptManager.getInstance().getCache().get(fullScriptId);
 
-			if (script == null) {
-				context.getSource().sendError(Text.translatable(translationKey("error.not_found"), scriptId));
-				return 0;
+			if (script == null) context.getSource().sendError(Text.translatable("command.amblekit.script.error.not_found", scriptId));
+				context.getSource().sendError(Text.literal("Server script '" + scriptId + "' not found"));
 			}
 
 			if (script.onExecute() == null || script.onExecute().isnil()) {
@@ -252,6 +247,6 @@ private static int listAvailable(CommandContext<ServerCommandSource> context) {
 			context.getSource().sendFeedback(() ->
 					statusIcon.copy().append(Text.literal(id.getNamespace() + ":" + displayId).formatted(Formatting.WHITE)), false);
 		}
-		return 1;
+		return Command.SINGLE_SUCCESS;
 	}
 }

src/main/java/dev/amble/lib/command/SetSkinCommand.java

@@ -164,6 +164,6 @@ private static int executeWithSlim(CommandContext<ServerCommandSource> context)
 		String username = entity.getEntityName();
 		context.getSource().sendFeedback(() -> Text.translatable(translationKey("set"), username, value), true);
 
-		return 1;
+		return Command.SINGLE_SUCCESS;
 	}
 }