Lenovo T14s G7 AMD audio issues

[mrhpearson]

We're working on Linux enablement for the Lenovo T14s G7 AMD and having issues with getting the microphone working.

AMD engineers recommended having a ticket upstream for better collaboration - there are some issues with ACP PDM controller and volume support capabilities that need discussion.

alsa-info content: http://alsa-project.org/db/?f=9082b76bc281046ae2b719cf89123fc174862864

I'll let the AMD folk know this has been created so they can explain the technical details of the issue more effectively

Thanks
Mark

[vijendarmukunda]

ACP PDM controller support was introduced starting with the Renoir generation (driver path: sound/soc/amd/renoir). In the initial implementation, a separate sound card was created for the ACP PDM capture endpoint.
Since the ACP PDM controller does not provide any hardware volume or mute controls, ALSA UCM changes were implemented by @perexg to logically associate the ACP PDM sound card with the HDA UCM, thereby enabling Mic Mute functionality.

Link: #30

On newer platforms, the audio configuration supports a SoundWire + ACP PDM combination. In this case, no separate sound card is created for the ACP PDM capture PCM endpoint.
We now need assistance from @perexg to define appropriate ALSA UCM entries for the internal DMIC endpoint when ACP PDM is used, while ensuring that this does not introduce regressions on platforms where the DMIC is connected via a SoundWire codec instead of ACP PDM.
For platforms using a SoundWire‑attached DMIC, the codec already exposes dedicated mixer controls for volume and mute, and these should continue to be used without interference from ACP PDM–specific UCM logic.
Please let us know if any additional information or platform details are required to move this forward.

[perexg]

The current mechanism for SOF and SoundWire based drivers is to propagate the hardware detaiils through the components string:

Card sysdefault:1 'amdsoundwire'/'LENOVO-21YWSIT007-ThinkPadT14sGen7'
  Mixer name	: ''
  Components	: ' cfg-amp:1 spk:rt1320 hs:rt722'
  Controls      : 28
  Simple ctrls  : 23

I suggest to advertise the ACP PDM microphone there. Eventually, we can look for the specific PCM name [1], but the components mechanism is preferred.

So, please, add this identifier to the components string in the driver: mic:acp-dmic , so we can put UCM configuration to ucm2/sof-soundwire/acp-dmic.conf file.

[1] card 1: amdsoundwire [amd-soundwire], device 4: acp-dmic-codec dmic-hifi-4 []

[vijendarmukunda]

@perexg will make the required code changes to propagate component name for DMIC as suggested.

[superm1]

Mostly because of the structure you pointed out I do want to note that SOF is not used in these current AMD designs.

It may be used in future ones though so we should ensure that we don't pigeonhole anything if we can avoid it.

[vijendarmukunda]

@superm1: if we need to support for SOF stack where it uses Soundwire + ACP PDM, similar fix needs to be populated for ACP PDM component name. Key difference will be Soundcard name will be different compared to legacy stack.

[vijendarmukunda]

@perexg : we have modified code to update the component name correctly for ACP PDM DMIC. Below is the output of mixer info on the target.

Card sysdefault:1 'amdsoundwire'/'LENOVO-21YWSIT006-ThinkPadT14sGen7'
Mixer name : ''
Components : ' cfg-amp:1 mic:acp-dmic cfg-mics:1 spk:rt1320 hs:rt722'
Controls : 27
Simple ctrls : 22
Does this information is enough? let us know if something is missing?

[vijendarmukunda]

After adding acp-dmic component string, audio is not heard on speaker, when we try audio playback through UI, whereas through aplay we are able to hear audio on speaker endpoint. @perexg : Could you please share your inputs to further debug this issue?

[perexg]

As I wrote, ucm2/sof-soundwire/acp-dmic.conf configuration file must be added to the ucm2 configuration tree with configuration like:

SectionDevice."Mic" {
        Comment "Digital Microphone"

        Value {
                CapturePriority 100
                CapturePCM "hw:${CardId},4"
        }
}

You can create PR when you test this. Also, if there is a problem, show output from alsaucm -c hw:amdsoundwire dump text.

[ChaitanyaKrishna001]

@perexg : we have done the changes as per your suggestion. After inclusion of ucm2/sof-soundwire/acp-dmic.conf file, DMIC endpoint is listed and we are able to run capture use case using ACP DMIC and speaker also working fine. Attached dump text output.

amdsoundwire_dump_text.txt

we have observed different issue. Even though Jack detection is fine in Sound settings Endpoint switching is not happening from Speaker -> Headphone and Internal mic -> headset mic.

[perexg]

If jack state change is correctly detected at the ALSA level (you may check this using amixer -c amdsoundwire events command, then it's pipewire issue. You may report this problem there. Don't forget to create PR for acp-dmic.conf, so I can apply it to repository.

[ChaitanyaKrishna001]

I have created a Pull Request for the ACP DMIC changes.
Please find the link below:
#732

[mrhpearson]

I confirmed the same findings for the ACP DMIC - audio working well (yay!) except for switching to headset when plugged in (the headset is detected correctly).

@vijendarmukunda & @ChaitanyaKrishna001 - do you want me to raise the pipewire ticket or will you do that?

Thanks for the great progress on this!