Null safety support

[stepanzalis]

Hello 👋

first of all, thank you for the package, it helped me a lot with sharing translation with others. Do you consider to maintain it and migrate it to null-safety?

Thank you 🙏

[stepanzalis]

Oh, I found the related issue already. #33
Sorry

[Dokotela]

I've tried to migrate this to null safety, and opened a PR. But if anyone wanted to test it and let me know, that would be helpful. https://github.com/Dokotela/flutter_sheet_localization

[aloisdeniel]

In the meanwhile, I published a 3.0.0 version yesterday with null-safety (for the main package) support and upgraded dependencies.

Let me know after upgrading if it works for you!

[4mitabh]

@aloisdeniel the 3.0.0 version is supposed to produce null safe localizations.g.dart, right?

It seems to generate the same code for me- the same as 2.x versions.
Perhaps I'm missing something...

[stepanzalis]

@aloisdeniel Thanks. I'll check it out.

[rtoshmukhamedov]

@aloisdeniel Can you upgrade to the latest source_gen: ^1.0.0 and dart_style: ^2.0.0. Because other packages are requiring them.

[stepanzalis]

@aloisdeniel Can you please update source_gen: ^1.0.0 and dart_style: ^2.0.0? Seems that generating does not change anything and got some errors.
I got this error: Error: The parameter 'ok' can't have a value of 'null' because of its type 'String', but the implicit default value is 'null'.

[stepanzalis]

Generator produces the same code as version 2.x as mentioned @4mitabh. Build crashes when you use Dart 2.12.

[aloisdeniel]

Sorry for the delay, I was on a big refactoring pass.

A new version is available. Please tell me if it works better on your side!

Note that there are a few changes to do to your delegate class implementation (see the README for more details).

[mboe]

I tried the new version (and made the changes in localization.dart file) but AppLocalizations is not a valid class anymore.

[aloisdeniel]

Ah yes, I forgot this part of the documentation.

The new recommended way for accessing localizations is :

extension AppLocalizationsExtensions on BuildContext {
  AppLocalizationsData get localizations {
    return Localizations.of<AppLocalizationsData>(this, AppLocalizationsData)!;
  }
}

If you want to keep support in your code base you can define this class in localization.dart :

abstract class AppLocalizations {
  static AppLocalizationsData of(BuildContext context) {
    return Localizations.of<AppLocalizationsData>(context, AppLocalizationsData)!;
  }
}

[mboe]

Yes, thank you for the clarification but that not sufficient. There is no .languages property (on both classes) but according to your documentation it should (see Part 4 'Configure your App') and I do miss the getByKey function. I used it a lot because the actual key was determined during runtime.

[aloisdeniel]

Il do a full pass on documentation by the end of the week to make sure everything is up to date.

In the meantime, you can refer to the provided example.

I'll see if I can introduce back the getByKey. I would be interested to know more about your use case! For me, runtime values can be managed with conditions (therefore enums). Why do you need a String value?

[mboe]

Hi. Thanks a lot. I was able to make my code run again. The only issue remaining is the absence of the getByKey function (or anything similar). I use this in a generic class where the actual field keys were derived from database responses. This was very dynamic and slim and I'd like to have a similar functionality again. Can you please check?