style(feh,upgradepkg,valgrind): remove unnecessary @(...)

scop#1297 (comment)

Author: akinomyoga

completions/feh

@@ -29,13 +29,13 @@ _comp_cmd_feh()
             fi
             local font_path
             # font_path="$(imlib2-config --prefix 2>/dev/null)/share/imlib2/data/fonts"
-            # _comp_compgen -C "$font_path" -- -f -X "!*.@([tT][tT][fF])" -S /
+            # _comp_compgen -C "$font_path" -- -f -X "!*.[tT][tT][fF]" -S /
             for ((i = ${#words[@]} - 2; i > 0; i--)); do
                 if [[ ${words[i]} == -@(C|-fontpath) ]]; then
                     font_path="${words[i + 1]}"
                     if [[ -d $font_path ]]; then
                         _comp_compgen -aC "$font_path" -- \
-                            -f -X "!*.@([tT][tT][fF])" -S /
+                            -f -X "!*.[tT][tT][fF]" -S /
                     fi
                 fi
             done

completions/upgradepkg

@@ -15,7 +15,7 @@ _comp_cmd_upgradepkg()
         cur="${cur#*%}"
         local nofiles=""
         compopt -o filenames
-        _comp_compgen -- -P "$prev%" -f -X "!*.@(t[bgxl]z)" || nofiles=set
+        _comp_compgen -- -P "$prev%" -f -X "!*.t[bgxl]z" || nofiles=set
         _comp_compgen -a -- -P "$prev%" -S '/' -d
         [[ $nofiles ]] && compopt -o nospace
         return

completions/valgrind

@@ -7,7 +7,7 @@ _comp_cmd_valgrind()
 
     local i
     for ((i = 1; i <= cword; i++)); do
-        if [[ ${words[i]} != @([-=])* ]]; then
+        if [[ ${words[i]} != [-=]* ]]; then
             _comp_command_offset $i
             return
         fi

test/runLint

@@ -52,6 +52,9 @@ gitgrep '(?<!command)'"$cmdstart"'(grep|ls|sed|cd)(\s|$)' \
 gitgrep '(?<!command)'"$cmdstart"'awk(\s|$)' \
     'invoke awk through "_comp_awk"'
 
+gitgrep '@\([^()|$]+\)' \
+    '@(...) may not be needed when ... does not contain |.'
+
 #------------------------------------------------------------------------------
 # Bash pitfalls/styles/compatibilities (which are not detected by shellcheck)