sanity

Author: rodireich

airbyte-cdk/bulk/toolkits/extract-jdbc/src/main/kotlin/io/airbyte/cdk/read/JdbcPartitionsCreator.kt

@@ -227,7 +227,7 @@ class JdbcConcurrentPartitionsCreator<
         }
         val rowByteSizeSample: Sample<Long> = sample.map { (_, rowByteSize: Long) -> rowByteSize }
         streamState.fetchSize = sharedState.jdbcFetchSizeEstimator().apply(rowByteSizeSample)
-        val expectedTableByteSize: Long = rowByteSizeSample.sampledValues.sum() * sample.valueWeight /*1_000L * 1_000 * 1_000 * 1_000*/ // TEMP
+        val expectedTableByteSize: Long = rowByteSizeSample.sampledValues.sum() * sample.valueWeight
         log.info { "Table memory size estimated at ${expectedTableByteSize shr 20} MiB." }
         // Handle edge case where the table can't be split.
         if (partition !is JdbcSplittablePartition<*>) {

airbyte-cdk/bulk/toolkits/extract-jdbc/src/main/kotlin/io/airbyte/cdk/read/SelectQuerier.kt

@@ -94,7 +94,6 @@ class JdbcSelectQuerier(
         /** Initializes a connection and readies the resultset. */
         fun initQueryExecution() {
             conn = jdbcConnectionFactory.get()
-//            conn?.autoCommit = false // TEMP
             stmt = conn!!.prepareStatement(q.sql)
             parameters.statementFetchSize?.let { fetchSize: Int ->
                 log.info { "Setting Statement fetchSize to $fetchSize." }
@@ -143,7 +142,7 @@ class JdbcSelectQuerier(
                 val jdbcFieldType: JdbcFieldType<*> = column.type as JdbcFieldType<*>
                 try {
                     if (column is NonEmittedField) {
-                        @Suppress("UNCHECKED_CAST")
+                        @Suppress("UNCHECKED_CAST") // TODO: See if we can avoid an unchecked cast
                         resultRow.nonEmittedData[column.id] =
                             FieldValueEncoder(
                                 jdbcFieldType.jdbcGetter.get(rs!!, colIdx),

airbyte-integrations/connectors/source-postgres/src/main/kotlin/io/airbyte/integrations/source/postgres/PostgresSourceJdbcV2CompatibilityStreamStateValue.kt

@@ -51,7 +51,7 @@ data class PostgresSourceJdbcV2CompatibilityStreamStateValue(
                                     cursorField,
                                     incrementalState.cursorValue!!.asText()
                                 )
-                            ) // TODO: check here
+                            )
                         }
                         else -> mapOf()
                     }