fix(source-slack): skip joining archived channels rejected by Slack API (#76052)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: bot_apk <apk@cognition.ai>

Author: devin-ai-integration[bot]

airbyte-integrations/connectors/source-slack/CONTRIBUTING.md

@@ -2,7 +2,7 @@
 
 ## 1. Auto-Joining Channels During Sync
 
-When `join_channels` is enabled in the config, the `ChannelsRetriever` automatically joins Slack channels by making POST requests to `conversations.join` during the channels stream read. For each channel where the bot's `is_member` property is false, the connector fires a side-effect API call to join that channel before yielding the record. This means reading the channels stream can modify the Slack workspace state.
+When `join_channels` is enabled in the config, the `ChannelsRetriever` automatically joins Slack channels by making POST requests to `conversations.join` during the channels stream read. For each non-archived channel where the bot's `is_member` property is false, the connector fires a side-effect API call to join that channel before yielding the record. Archived channels are always skipped because the Slack API rejects `conversations.join` for archived channels. This means reading the channels stream can modify the Slack workspace state.
 
 **Why this matters:** The channels stream is not read-only when `join_channels` is enabled. It actively modifies the workspace by joining channels, which is a side effect that no other connector stream produces. The Slack API only returns messages from channels the bot has joined, so this behavior exists to ensure the messages and threads streams can actually retrieve data. If the bot lacks permission to join a channel, it logs a warning but does not fail the sync.
 

airbyte-integrations/connectors/source-slack/components.py

@@ -106,6 +106,8 @@ def should_join_to_channel(self, config: Mapping[str, Any], record: Record) -> b
         The `is_member` property indicates whether the API Bot is already assigned / joined to the channel.
         https://api.slack.com/types/conversation#booleans
         """
+        if record.get("is_archived"):
+            return False  # Slack API rejects conversations.join for archived channels
         return config["join_channels"] and not record.get("is_member")
 
     def make_join_channel_slice(self, channel: Mapping[str, Any]) -> Mapping[str, Any]:

airbyte-integrations/connectors/source-slack/metadata.yaml

@@ -10,7 +10,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: c2281cee-86f9-4a86-bb48-d23286b4c7bd
-  dockerImageTag: 3.1.15
+  dockerImageTag: 3.1.16
   dockerRepository: airbyte/source-slack
   documentationUrl: https://docs.airbyte.com/integrations/sources/slack
   externalDocumentationUrls:

airbyte-integrations/connectors/source-slack/unit_tests/test_components.py

@@ -51,10 +51,21 @@ def get_channels_retriever_instance(token_config, components_module):
     )
 
 
-def test_join_channels_should_join_to_channel(token_config, components_module):
-    retriever = get_channels_retriever_instance(token_config, components_module)
-    assert retriever.should_join_to_channel(token_config, {"is_member": False}) is True
-    assert retriever.should_join_to_channel(token_config, {"is_member": True}) is False
+@pytest.mark.parametrize(
+    "join_channels,record,expected",
+    [
+        pytest.param(True, {"is_member": False, "is_archived": False}, True, id="join_enabled_non_member_non_archived"),
+        pytest.param(True, {"is_member": True, "is_archived": False}, False, id="join_enabled_already_member"),
+        pytest.param(True, {"is_member": False, "is_archived": True}, False, id="join_enabled_archived_channel_rejected"),
+        pytest.param(False, {"is_member": False, "is_archived": False}, False, id="join_disabled"),
+        pytest.param(True, {"is_member": False}, True, id="join_enabled_missing_is_archived"),
+        pytest.param(True, {"is_member": True, "is_archived": True}, False, id="archived_and_already_member"),
+    ],
+)
+def test_should_join_to_channel(token_config, components_module, join_channels, record, expected):
+    config = {**token_config, "join_channels": join_channels}
+    retriever = get_channels_retriever_instance(config, components_module)
+    assert retriever.should_join_to_channel(config, record) is expected
 
 
 def test_join_channels_make_join_channel_slice(token_config, components_module):

airbyte-integrations/connectors/source-slack/unit_tests/test_config_migrations.py

@@ -12,7 +12,6 @@
 CMD = "check"
 TEST_CONFIG_LEGACY_PATH = f"{os.path.dirname(__file__)}/configs/legacy_config.json"
 TEST_CONFIG_ACTUAL_PATH = f"{os.path.dirname(__file__)}/configs/actual_config.json"
-
 SOURCE_INPUT_ARGS_LEGACY = [CMD, "--config", TEST_CONFIG_LEGACY_PATH]
 SOURCE_INPUT_ARGS_ACTUAL = [CMD, "--config", TEST_CONFIG_ACTUAL_PATH]