fix: archive only closed positions, add filters/pagination/detail modal

Archive logic:
- Only archives trades for CLOSED positions (failed, rejected, cancelled, no_wallet)
- Filled trades for positions still held on-chain stay in Trade History
- Filled trades only move to archive when position is sold or market resolved
- Stops emptying the Trade History tab

Archive GET endpoint:
- Added pagination (page, pageSize params)
- Added filters (side, status, search)
- Returns totalPages for pagination UI

Archive display:
- Uses renderFilteredTable with search, filters (Side, Outcome, Status), sort by date
- Clicking a row opens the standard detail modal (same as live trading)
- Shows P&L and Cost columns
- Proper empty state message explaining when trades get archived

Author: Ope Olatunji

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agenticmail/enterprise",
-  "version": "0.5.532",
+  "version": "0.5.533",
   "description": "AgenticMail Enterprise — cloud-hosted AI agent identity, email, auth & compliance for organizations",
   "type": "module",
   "bin": {

src/admin/routes.ts

@@ -4286,29 +4286,39 @@ export function createAdminRoutes(db: DatabaseAdapter) {
 
   // ── Archive System ──────────────────────────────────────────
 
-  // Get archived data for a specific tab
+  // Get archived data for a specific tab (with pagination and filters)
   api.get('/polymarket/:agentId/archive/:tab', requireRole('admin'), async (c) => {
     try {
       const agentId = c.req.param('agentId');
       const tab = c.req.param('tab');
       const e = edb();
-      const limit = parseInt(c.req.query('limit') || '100');
+      const page = parseInt(c.req.query('page') || '1');
+      const pageSize = parseInt(c.req.query('pageSize') || '20');
+      const side = c.req.query('side') || '';
+      const status = c.req.query('status') || '';
+      const search = c.req.query('search') || '';
+      const offset = (page - 1) * pageSize;
 
       let tableName = '';
       if (tab === 'trades') tableName = 'poly_trade_log_archive';
       else if (tab === 'exits') tableName = 'poly_exit_rules_archive';
       else if (tab === 'alerts') tableName = 'poly_price_alerts_archive';
       else if (tab === 'events') tableName = 'poly_watcher_events_archive';
-      else return c.json({ rows: [], total: 0, message: 'Unknown archive tab: ' + tab });
+      else return c.json({ rows: [], total: 0, page, pageSize, message: 'Unknown archive tab: ' + tab });
 
-      // Check if archive table exists
       try {
-        const rows = await e?.all(`SELECT * FROM ${tableName} WHERE agent_id = ? ORDER BY created_at DESC LIMIT ?`, [agentId, limit]) || [];
-        const countRow = await e?.get(`SELECT COUNT(*) as cnt FROM ${tableName} WHERE agent_id = ?`, [agentId]) as any;
-        return c.json({ rows, total: countRow?.cnt || rows.length });
+        let where = `agent_id = ?`;
+        const params: any[] = [agentId];
+        if (side) { where += ` AND side = ?`; params.push(side.toUpperCase()); }
+        if (status) { where += ` AND status = ?`; params.push(status); }
+        if (search) { where += ` AND (market_question LIKE ? OR outcome LIKE ?)`; params.push(`%${search}%`, `%${search}%`); }
+
+        const countRow = await e?.get(`SELECT COUNT(*) as cnt FROM ${tableName} WHERE ${where}`, params) as any;
+        const total = countRow?.cnt || 0;
+        const rows = await e?.all(`SELECT * FROM ${tableName} WHERE ${where} ORDER BY created_at DESC LIMIT ? OFFSET ?`, [...params, pageSize, offset]) || [];
+        return c.json({ rows, total, page, pageSize, totalPages: Math.ceil(total / pageSize) });
       } catch {
-        // Archive table doesn't exist yet — no archived data
-        return c.json({ rows: [], total: 0, message: 'No archived data yet. Use the Archive action to move old data here.' });
+        return c.json({ rows: [], total: 0, page, pageSize, totalPages: 0, message: 'No archived data yet.' });
       }
     } catch (e: any) { return c.json({ rows: [], total: 0, error: e.message }); }
   });
@@ -4331,13 +4341,16 @@ export function createAdminRoutes(db: DatabaseAdapter) {
       }
 
       if (tab === 'trades' || tab === 'all') {
-        // Archive non-active trades (filled, failed, rejected, cancelled, no_position, no_wallet)
+        // Only archive trades that are truly closed:
+        // 1. Failed, rejected, cancelled, no_position, no_wallet — these never executed
+        // 2. Filled trades ONLY if the position is no longer held on-chain (sold or market resolved)
+        // Do NOT archive filled trades for positions we still hold!
         await e?.run(`
-          INSERT INTO poly_trade_log_archive SELECT * FROM poly_trade_log 
-          WHERE agent_id = $1 AND status NOT IN ('placed', 'pending')
+          INSERT INTO poly_trade_log_archive SELECT * FROM poly_trade_log
+          WHERE agent_id = $1 AND status IN ('failed', 'rejected', 'cancelled', 'no_position', 'no_wallet')
         `, [agentId]).catch(() => {});
         await e?.run(`
-          DELETE FROM poly_trade_log WHERE agent_id = $1 AND status NOT IN ('placed', 'pending')
+          DELETE FROM poly_trade_log WHERE agent_id = $1 AND status IN ('failed', 'rejected', 'cancelled', 'no_position', 'no_wallet')
         `, [agentId]).catch(() => {});
 
         // Also archive 'placed' trades for positions that no longer exist on-chain

src/dashboard/pages/polymarket.js

@@ -2024,22 +2024,30 @@ export function PolymarketPage() {
       showArchive.trades ? (
         archiveLoading ? h('div', { style: { textAlign: 'center', padding: 40, color: 'var(--text-muted)' } }, 'Loading archive...') :
         h('div', null,
-          h('div', { style: { fontSize: 13, fontWeight: 600, marginBottom: 12, color: 'var(--text-muted)' } }, I('database'), ' Archived Trades (', (showArchive.trades_data?.total || 0), ')'),
-          (showArchive.trades_data?.rows || []).length === 0 ? h('div', { style: { textAlign: 'center', padding: 40, color: 'var(--text-muted)' } }, 'No archived trades yet.') :
-          h('div', { className: 'table-container' }, h('table', { className: 'data-table' },
-            h('thead', null, h('tr', null, ['Market','Side','Outcome','Shares','Price','Status','Date'].map(function(hd) { return h('th', { key: hd }, hd); }))),
-            h('tbody', null, (showArchive.trades_data?.rows || []).map(function(t) {
-              return h('tr', { key: t.id },
-                h('td', null, h('div', { style: { maxWidth: 220 } }, t.market_question || '')),
-                h('td', null, sideBadge(t.side)),
-                h('td', null, t.outcome ? h('span', { className: 'badge badge-' + (t.outcome.toLowerCase() === 'yes' ? 'success' : 'danger') }, t.outcome) : '--'),
-                h('td', null, (t.size || 0).toFixed(1)),
-                h('td', null, ((t.price || 0) * 100).toFixed(1) + '\u00a2'),
-                h('td', null, h('span', { className: 'badge badge-' + (t.status === 'filled' ? 'success' : t.status === 'failed' ? 'danger' : 'secondary') }, t.status)),
-                h('td', null, fmtDate(t.created_at))
-              );
-            }))
-          ))
+          h('div', { style: { fontSize: 13, fontWeight: 600, marginBottom: 12, color: 'var(--text-muted)', display: 'flex', alignItems: 'center', gap: 8 } },
+            I('database'), ' Archived Trades (', (showArchive.trades_data?.total || 0), ')',
+            showArchive.trades_data?.message && h('span', { style: { fontWeight: 400, fontStyle: 'italic' } }, ' — ', showArchive.trades_data.message)
+          ),
+          renderFilteredTable('archive', showArchive.trades_data?.rows || [], 'No archived trades yet. Only trades for closed positions (sold or resolved markets) are archived.',
+          ['Market', 'Side', 'Outcome', 'Shares', 'Price', 'Cost', 'Status', 'P&L', 'Date'],
+          function(t) { return [
+            h('td', null, h('div', { style: { maxWidth: "220px" } }, t.market_question || shortId(t.token_id))),
+            h('td', null, sideBadge(t.side)),
+            h('td', null, t.outcome
+              ? h('span', { className: 'badge ' + (t.outcome.toLowerCase() === 'yes' ? 'badge-success' : t.outcome.toLowerCase() === 'no' ? 'badge-danger' : 'badge-secondary') }, t.outcome)
+              : '--'),
+            h('td', null, (t.size || 0).toFixed(1)),
+            h('td', null, ((t.fill_price || t.price || 0) * 100).toFixed(1) + '\u00a2'),
+            h('td', null, '$' + ((t.fill_price || t.price || 0) * (t.size || 0)).toFixed(2)),
+            h('td', null, h('span', { className: 'badge badge-' + (t.status === 'filled' ? 'success' : t.status === 'failed' || t.status === 'no_wallet' ? 'danger' : 'secondary') }, t.status)),
+            h('td', null, t.pnl != null ? pnlCell(t.pnl) : '--'),
+            h('td', null, fmtDate(t.created_at)),
+          ]; },
+          { searchFields: ['market_question', 'token_id', 'outcome'], filters: [
+            { key: 'side', label: 'Side', options: ['BUY', 'SELL'] },
+            { key: 'outcome', label: 'Outcome', options: ['Yes', 'No'] },
+            { key: 'status', label: 'Status', options: ['filled', 'failed', 'cancelled', 'rejected', 'no_wallet'] }
+          ], sortFn: function(a, b) { return new Date(b.created_at || 0).getTime() - new Date(a.created_at || 0).getTime(); } })
         )
       ) :
       renderFilteredTable('history', tradeHistory, 'No trade history',