-
-
Notifications
You must be signed in to change notification settings - Fork 280
Description
In PR3470 there was a change to Ensure CCache disabled for all reproducible jdk-17 & jdk-19+ builds.
In reality this seems to have prevented the use of ccache for all builds using the scripts in this repository and not only when the user has elected to perform a reproducible build as it actively squashes any --enable-ccache passed in as a configure arg.
This is perhaps not the right approach. I hadn't realised until now that this was always taking effect since the configureReproducibleBuildParameter() function in build.sh is always called, so the user cannot currently override this behavior. While I'm ok with a default of not using ccache I feel it shouldn't be squashed if it was explicitly requested by a developer invoking our scripts who may not have an interest in reproducibility and just need improved build performance.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status