Skip to content

[Digital Quality Documents] Invalid Qualifier Specification #277

Description

@empwilli

The DigitalQualityDocuments submodel template violates the specification by specifying a qualifier multiple times for the submodel element Submodels.DigitalQualityDocuments$DocumentInstances[0].AdministrativeData.Statements[0].Conformity.

Image

Furthermore, to the best of my knowledge there is no SMT/Value qualifier (at least wrt. to How to write a Submodel Template Specification v1.1), maybe what is meant instead is SMT/AllowedValue or FormChoices (or, ideally both)?

I'd suggest to adapt the qualifiers instead like the following. (Please note, that I've also adapted the qualifier kind).

"qualifiers": [
  ...
  {
    "kind": "TemplateQualifier",
    "type": "SMT/AllowedValue",
    "valueType": "xs:string",
    "value": "(pass|fail)"
  },
  {
    "kind": "TemplateQualifier",
    "type": "FormChoices",
    "valueType": "xs:string",
    "value": "pass;fail"
  }
]

Note: IMHO the qualifiers also use the wrong qualifier kind. The allowed values are (in my interpretation) a static information that does not change over time; hence "SMT/AllowedValue" should be a TemplateQualifier. IMHO, this would also be an improvement for "How to write a Submodel Template Specification" to include the respective qualifier kind, as I see a lot of divergence in different SMTs.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions