You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The extended-card precondition tests can silently skip a genuine MUST violation, and CARD-EXT-001 still carries the false-failure class that PR #186 fixed for CARD-EXT-002.
Background
PR #186 re-routed CARD-EXT-002 to a dedicated probe-and-skip test (TestExtendedCardNotConfigured in tests/compatibility/core_operations/test_error_handling.py) because the precondition — a server that declaresextendedAgentCard support but has not configured one — is not observable from the agent card. That fix is correct and merged-ready.
Problems
Test can pass or skip, never fail. When a server declares support, leaves the extended card unconfigured, but returns the wrong error code (not -32007 / EXTENDED_AGENT_CARD_NOT_CONFIGURED_ERROR), the test pytest.skips instead of failing. A real conformance violation goes unreported. The skip heuristic should be tightened — e.g. only skip on an auth-shaped/precondition-shaped error, and fail on other A2A error codes.
CARD-EXT-001 has the same false-failure class. In tck/requirements/agent_card.py, CARD-EXT-001 still carries operation= with no expected_error and expects an AgentCard success response. Against a server that declares-but-doesn't-configure the extended card, it will produce the same false failure fix: skip CARD-EXT-002 when extended card is configured #186 just eliminated for CARD-EXT-002.
Suggested work
Tighten TestExtendedCardNotConfigured so a wrong-but-present error code fails rather than skips.
Apply the same probe-and-skip routing to CARD-EXT-001.
Summary
The extended-card precondition tests can silently skip a genuine MUST violation, and CARD-EXT-001 still carries the false-failure class that PR #186 fixed for CARD-EXT-002.
Background
PR #186 re-routed CARD-EXT-002 to a dedicated probe-and-skip test (
TestExtendedCardNotConfiguredintests/compatibility/core_operations/test_error_handling.py) because the precondition — a server that declaresextendedAgentCardsupport but has not configured one — is not observable from the agent card. That fix is correct and merged-ready.Problems
Test can pass or skip, never fail. When a server declares support, leaves the extended card unconfigured, but returns the wrong error code (not
-32007/EXTENDED_AGENT_CARD_NOT_CONFIGURED_ERROR), the testpytest.skips instead of failing. A real conformance violation goes unreported. The skip heuristic should be tightened — e.g. only skip on an auth-shaped/precondition-shaped error, and fail on other A2A error codes.CARD-EXT-001 has the same false-failure class. In
tck/requirements/agent_card.py, CARD-EXT-001 still carriesoperation=with noexpected_errorand expects anAgentCardsuccess response. Against a server that declares-but-doesn't-configure the extended card, it will produce the same false failure fix: skip CARD-EXT-002 when extended card is configured #186 just eliminated for CARD-EXT-002.Suggested work
TestExtendedCardNotConfiguredso a wrong-but-present error code fails rather than skips.Follow-up from review of #186.