Can a static password for MODHEX keyboard be appended with CR?

[h2dden]

MODHEX keyboard is missing a character \n but this does not prevent appending a CR via append_cr(True)

Should MODHEX keyboard include \n?

[dainnilsson]

As modhex is not a keyboard layout in itself, but an encoding of binary data, I would probably say that the lack of CR is correct, and the appended CR is separate from the value. It's really just a matter of semantics though, and you could probably argue for it to be included as well.

As it isn't included now, I would only consider adding it if there is a very clear use case for it, where it solves a real-world problem.