Skip to content

Commit effb91a

Browse files
author
Aethermor
committed
v1.0.1: peer review response — package restructure, calibration study, docs overhaul
Structural: - Move all modules under aethermor/ namespace (aethermor.physics, etc.) - Remove all 20 sys.path.insert hacks - Split monolithic app.py into aethermor/app/ (6 tab modules) - Add CLI entry point: aethermor dashboard|validate|version - Add python -m aethermor support Documentation: - Calibration case study: 15 real chips vs model (A100, H100, i9-13900K, etc.) - Datacenter GPU case study: 8-GPU node air vs liquid vs substrate - Uncertainty/sensitivity analysis with Monte Carlo propagation - README: Start Here guide, validation table, error bounds, failure modes, CFD comparison, reproducibility section, academic references - Consistency audit: test counts, import paths, app.py refs across all docs Version bump to 1.0.1.
1 parent 6774967 commit effb91a

120 files changed

Lines changed: 1793 additions & 1148 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
run: python -m pytest tests/ -q
3131

3232
- name: Run validation suite
33-
run: python -m validation.validate_all
33+
run: python -m aethermor.validation.validate_all
3434

3535
- name: Run literature validation
3636
run: python benchmarks/literature_validation.py

CHANGELOG.md

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,37 @@ All notable changes to this project are documented in this file.
44

55
## [Unreleased]
66

7+
## [1.0.1] - 2026-03-31
8+
9+
### Added — Peer Review Response
10+
- **Package restructure**: All modules moved under `aethermor/` namespace
11+
(`aethermor.physics`, `aethermor.analysis`, `aethermor.validation`,
12+
`aethermor.simulation`). Proper installable package with `pip install -e .`.
13+
- **CLI entry point**: `aethermor dashboard`, `aethermor validate`,
14+
`aethermor version` via `[project.scripts]` in pyproject.toml.
15+
- **Dashboard split**: Monolithic `app.py` (730 lines) replaced with modular
16+
`aethermor/app/` package — 6 tab modules + shared utils + main entry point.
17+
- **Calibration case study**: `docs/calibration_case_study.md` — 15 real
18+
production chips (A100, H100, MI300X, i9-13900K, Ryzen 7950X, RTX 4090, etc.)
19+
validated against datasheet Tj_max values.
20+
- **Datacenter GPU case study**: `docs/case_study_datacenter_gpu.md` — 8-GPU
21+
node cooling decision matrix (air vs liquid vs substrate).
22+
- **Uncertainty & sensitivity analysis**: `docs/uncertainty_sensitivity.md`
23+
Monte Carlo uncertainty propagation, OAT sensitivity, transient roadmap.
24+
- **README enhancements**: "Start Here" evaluation guide, validation summary
25+
table, expected accuracy section, "When This Model Breaks" failure modes,
26+
CFD comparison table, reproducibility section, academic references.
27+
28+
### Changed
29+
- All 65+ source files updated from `physics.*``aethermor.physics.*` imports.
30+
- All `sys.path.insert` hacks removed (20 files).
31+
- All documentation updated for new package paths and consistent test counts.
32+
- pyproject.toml: `packages.find` now includes only `aethermor*`.
33+
34+
### Removed
35+
- Monolithic `app.py` — replaced by `aethermor/app/` modular architecture.
36+
- All `sys.path` manipulation from `tests/conftest.py`.
37+
738
## [1.0.0] - 2026-03-25
839

940
### Added — Experimental Measurement Validation
@@ -94,7 +125,7 @@ All notable changes to this project are documented in this file.
94125
- `thermal_map.py`: Hotspot detection, cooling efficiency maps
95126

96127
### Added — Interactive Explorer UI
97-
- `app.py`: Dash-based interactive explorer with 6 tabs:
128+
- `aethermor/app/`: Modular Dash-based interactive explorer with 6 tabs:
98129
- Material Ranking, Cooling Analysis, Paradigm Comparison,
99130
Technology Roadmap, SoC Thermal Map, Custom Material registration
100131

@@ -119,7 +150,7 @@ All notable changes to this project are documented in this file.
119150

120151
### Added — Validation & Testing
121152
- 254 unit, integration, regression, and performance tests (pytest)
122-
- 133 physics cross-checks (`python -m validation.validate_all`) against
153+
- 133 physics cross-checks (`python -m aethermor.validation.validate_all`) against
123154
CODATA 2018, CRC Handbook, ITRS/IRDS, analytical solutions
124155
- 43 registry-specific tests covering all three extensible registries
125156

CITATION.cff

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ abstract: >
1717
power redistribution), technology roadmap projection (130 nm to 1.4 nm),
1818
and an interactive explorer dashboard. All models are cross-validated against
1919
CODATA 2018, the CRC Handbook, and ITRS/IRDS roadmaps (133 physics checks,
20-
254 tests).
20+
277 tests).
2121
keywords:
2222
- thermal analysis
2323
- chip thermal modeling

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ pip install -e ".[all]" # core + dashboard + dev tools
3939
Run tests:
4040

4141
```bash
42-
python -m pytest tests/ -v # 254 tests
43-
python -m validation.validate_all # 133 physics cross-checks
42+
python -m pytest tests/ -v # 277 tests
43+
python -m aethermor.validation.validate_all # 133 physics cross-checks
4444
```
4545

4646
Run examples:
4747

4848
```bash
4949
python examples/custom_material.py # extensibility walkthrough
50-
python app.py # interactive explorer UI
50+
aethermor dashboard # interactive explorer UI
5151
```
5252

5353
## Pull Request Requirements

HONEST_REVIEW.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ These are questions hardware researchers currently answer through manual
2727
COMSOL sweeps, HotSpot configurations, or custom scripts. Aethermor integrates
2828
them into a single API and interactive dashboard.
2929

30-
**Test suite**: 254 tests passing, 1 skipped (dashboard requires optional `dash`).
30+
**Test suite**: 277 tests passing, 1 skipped (dashboard requires optional `dash`).
3131
**Energy conservation**: 0.00 % error in 3D Fourier solver (tolerance: 5 %).
3232

3333
---
@@ -135,7 +135,7 @@ cross-checks every physics model against published reference data, analytical
135135
solutions, conservation laws, and internal self-consistency.
136136

137137
```bash
138-
python -m validation.validate_all # 133 checks, ~13 seconds
138+
python -m aethermor.validation.validate_all # 133 checks, ~13 seconds
139139
```
140140

141141
| Validation Area | Checks | Reference Source |
@@ -162,27 +162,27 @@ and interpretation guide.
162162
### 2.3 Code Structure
163163

164164
```
165-
physics/ # SI-unit models
165+
aethermor/physics/ # SI-unit models
166166
constants.py # k_B, Planck, Boltzmann, landauer_limit()
167167
materials.py # 9 substrates + extensible registry with validation
168168
energy_models.py # 4 paradigms + extensible registry with protocol checking
169169
thermal.py # FourierThermalTransport (3D solver)
170170
cooling.py # CoolingStack + extensible layer registry
171171
chip_floorplan.py # ChipFloorplan, FunctionalBlock
172172
173-
analysis/ # Research tools
173+
aethermor/analysis/ # Research tools
174174
thermal_optimizer.py # Inverse design (8 capabilities)
175175
design_space.py # Pareto sweeps
176176
landauer_gap.py # Gap analysis
177177
regime_map.py # Operating regime classification
178178
thermal_map.py # Temperature field analysis
179179
tech_roadmap.py # Node projection (130nm to 1.4nm)
180180
181-
simulation/ # Legacy Monte Carlo / evolutionary simulation engine
181+
aethermor/simulation/ # Monte Carlo / evolutionary simulation engine
182182
examples/ # 7 runnable research scripts
183183
experiments/ # Reproducibility scripts (ablations, scaling, fault sweeps)
184184
tests/ # 277 tests (pytest)
185-
validation/ # 133 physics cross-checks (validate_all.py)
185+
aethermor/validation/ # 133 physics cross-checks (validate_all.py)
186186
```
187187

188188
### 2.4 Reproducibility

0 commit comments

Comments
 (0)