Skip to content

Commit 8dd215c

Browse files
author
Aethermor
committed
peer-review: align validation language, add Python 3.11/3.12 CI matrix
- VALIDATION.md: replace 'the physics is correct' with scoped statement referencing LIMITATIONS.md for evidence boundary - validate_all.py: replace 'trust these results' with 'internally consistent and agrees with published reference data' - ci.yml: expand test matrix to Python 3.10, 3.11, 3.12 (matches pyproject.toml classifiers) - GitHub Release: deleted orphaned draft release (sidebar now shows v0.1.0) Addresses reviewer feedback items 2, 3, 4 from latest audit.
1 parent 719478a commit 8dd215c

3 files changed

Lines changed: 19 additions & 12 deletions

File tree

.github/workflows/ci.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,17 @@ jobs:
99
test:
1010
runs-on: ubuntu-latest
1111
timeout-minutes: 45
12+
strategy:
13+
matrix:
14+
python-version: ["3.10", "3.11", "3.12"]
1215
steps:
1316
- name: Checkout
1417
uses: actions/checkout@v4
1518

16-
- name: Set up Python
19+
- name: Set up Python ${{ matrix.python-version }}
1720
uses: actions/setup-python@v5
1821
with:
19-
python-version: "3.10"
22+
python-version: ${{ matrix.python-version }}
2023

2124
- name: Install dependencies
2225
run: |

VALIDATION.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -342,13 +342,17 @@ require proprietary floorplan data and direct thermal measurement).
342342
## Interpretation
343343

344344
- **133/133 PASS** (physics) + **20/20 PASS** (literature) + **33/33 PASS**
345-
(real-world chips) means every model agrees with published data, analytical
346-
solutions, conservation laws, and real chip specifications.
345+
(real-world chips) means every model agrees with published reference data,
346+
analytical solutions, conservation laws, and real chip specifications
347+
within the scope of the tests listed above.
347348

348349
- **Any FAIL** means something is wrong. The failure message tells you
349350
exactly which model, what was expected, and what was observed. File an
350351
issue or investigate before using results from that model.
351352

352-
- **The validation suite is the contract.** If it passes on your machine,
353-
the physics is correct. If it fails, something in the environment or
354-
code has changed and needs investigation.
353+
- **The validation suite is a necessary but not sufficient check.** If it
354+
passes on your machine, the models are internally consistent and agree
355+
with the published references listed above. This does not substitute
356+
for validation against direct hardware measurement or proprietary
357+
simulation tools, which remains outside the current scope
358+
(see [LIMITATIONS.md](LIMITATIONS.md)).

validation/validate_all.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
5. Constraint satisfaction (optimizer respects its own contracts)
1919
6. Monotonicity & limit checks (correct qualitative behaviour)
2020
21-
If every check reads PASS, a researcher can trust that Aethermor's
22-
predictions are grounded in validated physics — not just code that runs.
21+
If every check reads PASS, the models are internally consistent and
22+
agree with the published references listed in each section.
2323
2424
Exit code: 0 if all checks pass, 1 if any fail.
2525
"""
@@ -884,9 +884,9 @@ def main():
884884
print()
885885
print(" ✓ ALL CHECKS PASSED")
886886
print()
887-
print(" Every model has been validated against published reference data,")
888-
print(" analytical solutions, conservation laws, and internal consistency.")
889-
print(" Researchers can trust these results.")
887+
print(" Every model is internally consistent and agrees with published")
888+
print(" reference data, analytical solutions, and conservation laws.")
889+
print(" See LIMITATIONS.md for scope of validation.")
890890
print()
891891
else:
892892
print()

0 commit comments

Comments
 (0)