Skip to content

Commit 5e97222

Browse files
authored
Merge pull request #61 from WishWesee/develop
[DEPLOY]
2 parents 579100c + 1d07235 commit 5e97222

File tree

3 files changed

+13
-18
lines changed

3 files changed

+13
-18
lines changed

src/main/java/depth/main/wishwesee/global/config/security/OAuth2Config.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,31 @@
11
package depth.main.wishwesee.global.config.security;
22

3+
import lombok.Data;
34
import lombok.Getter;
4-
import lombok.Setter;
55
import org.springframework.boot.context.properties.ConfigurationProperties;
66
import org.springframework.context.annotation.Configuration;
77

88
import java.util.ArrayList;
99
import java.util.List;
1010

11+
@Getter
1112
@Configuration
1213
@ConfigurationProperties(prefix = "app")
13-
@Getter
1414
public class OAuth2Config {
1515
private final Auth auth = new Auth();
1616
private final OAuth2 oauth2 = new OAuth2();
1717

18-
@Getter
19-
@Setter
18+
@Data
2019
public static class Auth {
2120
private String tokenSecret;
2221
private long accessTokenExpirationMsec;
2322
private long refreshTokenExpirationMsec;
2423
}
2524

2625
@Getter
27-
@Setter
2826
public static final class OAuth2 {
2927
private List<String> authorizedRedirectUris = new ArrayList<>();
3028

31-
public List<String> getAuthorizedRedirectUris() {
32-
return authorizedRedirectUris;
33-
}
34-
3529
public OAuth2 authorizedRedirectUris(List<String> authorizedRedirectUris) {
3630
this.authorizedRedirectUris = authorizedRedirectUris;
3731
return this;

src/main/java/depth/main/wishwesee/global/config/security/auth/OAuth2UserInfo.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
package depth.main.wishwesee.global.config.security.auth;
22

3+
import lombok.Getter;
4+
35
import java.util.Map;
46

7+
@Getter
58
public abstract class OAuth2UserInfo {
69
protected Map<String, Object> attributes;
710

811
public OAuth2UserInfo(Map<String, Object> attributes) {
912
this.attributes = attributes;
1013
}
1114

12-
public Map<String, Object> getAttributes() {
13-
return attributes;
14-
}
15-
1615
public abstract String getProvider();
1716

1817
public abstract String getId();

src/main/java/depth/main/wishwesee/global/config/security/handler/CustomSimpleUrlAuthenticationSuccessHandler.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ public void onAuthenticationSuccess(HttpServletRequest request, HttpServletRespo
3939
DefaultAssert.isAuthentication(!response.isCommitted());
4040

4141
String targetUrl = determineTargetUrl(request, response, authentication);
42-
4342
UserPrincipal userPrincipal = (UserPrincipal) authentication.getPrincipal();
4443
TokenMapping token = customTokenProviderService.createToken(userPrincipal.getEmail());
4544
CustomCookie.addCookie(response, "Authorization", "Bearer_" + token.getAccessToken(), (int) oAuth2Config.getAuth().getAccessTokenExpirationMsec());
@@ -52,7 +51,7 @@ public void onAuthenticationSuccess(HttpServletRequest request, HttpServletRespo
5251
protected String determineTargetUrl(HttpServletRequest request, HttpServletResponse response, Authentication authentication) {
5352
Optional<String> redirectUri = CustomCookie.getCookie(request, REDIRECT_URI_PARAM_COOKIE_NAME).map(Cookie::getValue);
5453

55-
DefaultAssert.isAuthentication( !(redirectUri.isPresent() && !isAuthorizedRedirectUri(redirectUri.get())) );
54+
DefaultAssert.isAuthentication(!(redirectUri.isPresent() && !isAuthorizedRedirectUri(redirectUri.get())));
5655

5756
String targetUrl = redirectUri.orElse(getDefaultTargetUrl());
5857

@@ -64,12 +63,15 @@ protected String determineTargetUrl(HttpServletRequest request, HttpServletRespo
6463
.build();
6564
tokenRepository.save(token);
6665

67-
return UriComponentsBuilder.fromUriString(targetUrl)
66+
URI uri = URI.create(targetUrl);
67+
return UriComponentsBuilder.fromUri(uri)
68+
.host("localhost:3000")
6869
.queryParam("token", tokenMapping.getAccessToken())
69-
.build().toUriString();
70+
.build()
71+
.toUriString();
7072
}
7173

72-
protected void clearAuthenticationAttributes(HttpServletRequest request, HttpServletResponse response) {
74+
protected void clearAuthenticationAttributes(HttpServletRequest request, HttpServletResponse response) {
7375
super.clearAuthenticationAttributes(request);
7476
customAuthorizationRequestRepository.removeAuthorizationRequestCookies(request, response);
7577
}

0 commit comments

Comments
 (0)