Skip to content

Commit 6d20566

Browse files
committed
more clarifications
1 parent a946d9b commit 6d20566

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

src/api/wayfire/toplevel-view.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ class toplevel_view_interface_t : public virtual wf::view_interface_t
6969
*
7070
* Note: xdg-popups / Xwayland menus associated with a view can be found by iterating through all
7171
* available views, fetching the associated wlroots surfaces (@get_wlr_surface()) and then checking for
72-
* potential relations between any pair of views by looking at the specific wlr_xdg_surface / wlr_xwayland
73-
* surface interfaces, which provide information about parent xdg surfaces or transient_for relations.
72+
* potential relations between any pair of views by looking at shell-specific information, for example
73+
* wlr_xdg_popup::parent / wlr_xwayland_surface::parent.
7474
*/
7575
std::vector<wayfire_toplevel_view> children;
7676

src/api/wayfire/unstable/wlr-surface-controller.hpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@ struct node_recheck_constraints_signal
1515
class wlr_surface_controller_t
1616
{
1717
public:
18+
/**
19+
* Create a new controller for the surface. It will automatically add, remove and update subsurfaces of
20+
* the given surface.
21+
*
22+
* Each subsurface's node will be added as a child of @root_node, and is positioned relative to the
23+
* parent surface.
24+
*/
1825
static void create_controller(wlr_surface *surface, scene::floating_inner_ptr root_node);
1926
static void try_free_controller(wlr_surface *surface);
2027

src/api/wayfire/view.hpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,9 @@ class view_interface_t : public wf::signal::provider_t, public wf::object_base_t
9191
* by plugins such as wrot, animate, etc.
9292
*
9393
* Note: the coordinate system expected by the root node is relative to the output the view is currently
94-
* associated with, otherwise undefined.
94+
* associated with, otherwise undefined. The coordinate system for children of the surface root node can
95+
* be different for each view type, but Wayfire's built-in view types make each subsurface node relative
96+
* to its parent surface (see wlr-surface-node.hpp / wlr-surface-controller.hpp for more details).
9597
*/
9698
const scene::floating_inner_ptr& get_surface_root_node() const;
9799

0 commit comments

Comments
 (0)