fix: Enhance category filtering by adding user group support in category retrieval

https://github.com/WWBN/AVideo/security/advisories/GHSA-73gr-r64q-7jh4#event-597450

Author: Daniel Neto

objects/categories.json.php

@@ -15,14 +15,16 @@
 $_REQUEST['current'] = getCurrentPage();
 
 $onlyWithVideos = false;
-$sameUserGroupAsMe = false;
 if(!empty($_GET['user'])){
     $onlyWithVideos = true;
-    $sameUserGroupAsMe = true;
 }
+// Always apply user-group filtering using the logged-in user's real ID.
+// Guests get -1 so getUserGroups returns [], leaving only unrestricted categories visible.
+$currentUserId = User::getId();
+$sameUserGroupAsMe = !empty($currentUserId) ? intval($currentUserId) : -1;
 
 $categories = Category::getAllCategories(true, $onlyWithVideos, false, $sameUserGroupAsMe);
-$total = Category::getTotalCategories(true, $onlyWithVideos);
+$total = Category::getTotalCategories(true, $onlyWithVideos, false, $sameUserGroupAsMe);
 //$breaks = array('<br />', '<br>', '<br/>');
 foreach ($categories as $key => $value) {
     $categories[$key]['iconHtml'] = "<span class='$value[iconClass]'></span>";

objects/category.php

@@ -975,7 +975,7 @@ public function delete()
         return sqlDAL::writeSql($sql, "i", [$this->id]);
     }
 
-    public static function getTotalCategories($filterCanAddVideoOnly = false, $onlyWithVideos = false, $onlySuggested = false)
+    public static function getTotalCategories($filterCanAddVideoOnly = false, $onlyWithVideos = false, $onlySuggested = false, $sameUserGroupAsMe = false)
     {
         global $global, $config;
 
@@ -1023,6 +1023,17 @@ public static function getTotalCategories($filterCanAddVideoOnly = false, $onlyW
             }
             $sql .= ")";
         }
+        if ($sameUserGroupAsMe) {
+            $users_groups = UserGroups::getUserGroups($sameUserGroupAsMe);
+            $users_groups_id = array(0);
+            foreach ($users_groups as $value) {
+                $users_groups_id[] = $value['id'];
+            }
+            $sql .= " AND ("
+                . "(SELECT count(*) FROM categories_has_users_groups chug WHERE c.id = chug.categories_id) = 0 OR "
+                . "(SELECT count(*) FROM categories_has_users_groups chug2 WHERE c.id = chug2.categories_id AND users_groups_id IN (" . implode(',', $users_groups_id) . ")) >= 1 "
+                . ")";
+        }
         $sql .= BootGrid::getSqlSearchFromPost(['name']);
         //echo $sql;exit;
         $res = sqlDAL::readSql($sql);