ci(release): publish latest release

hello-happy-puppy · hello-happy-puppy · commit b9b5ab9a5274 · 2025-11-21T20:33:11.000Z
diff --git a/RELEASE b/RELEASE
@@ -1,6 +1,6 @@
 IPFS hash of the deployment:
-- CIDv0: `QmTc9oJFYAwPhhTQi5NnPteHcvSYp7ZWiQ2V1WoanZjHU3`
-- CIDv1: `bafybeicoime5g2ighwvdo4r4x32cc3zpa7khfzrke4aym7gv7wbnl2jika`
+- CIDv0: `QmSuyBts5bYKUUmyvJymu3umtqsPx2JM2vyitDAowreoFj`
+- CIDv1: `bafybeicd67hq3fop37jiroeheeas66epmbb3g62e7qwvgpx2h5nivtbdmy`
 
 The latest release is always mirrored at [app.uniswap.org](https://app.uniswap.org).
 
@@ -10,14 +10,14 @@ You can also access the Uniswap Interface from an IPFS gateway.
 Your Uniswap settings are never remembered across different URLs.
 
 IPFS gateways:
-- https://bafybeicoime5g2ighwvdo4r4x32cc3zpa7khfzrke4aym7gv7wbnl2jika.ipfs.dweb.link/
-- [ipfs://QmTc9oJFYAwPhhTQi5NnPteHcvSYp7ZWiQ2V1WoanZjHU3/](ipfs://QmTc9oJFYAwPhhTQi5NnPteHcvSYp7ZWiQ2V1WoanZjHU3/)
+- https://bafybeicd67hq3fop37jiroeheeas66epmbb3g62e7qwvgpx2h5nivtbdmy.ipfs.dweb.link/
+- [ipfs://QmSuyBts5bYKUUmyvJymu3umtqsPx2JM2vyitDAowreoFj/](ipfs://QmSuyBts5bYKUUmyvJymu3umtqsPx2JM2vyitDAowreoFj/)
 
-### 5.119.1 (2025-11-20)
+### 5.119.2 (2025-11-21)
 
 
 ### Bug Fixes
 
-* **web:** show txns hash on activity table for all swaps until protocol data improves (#25649) 8571bc3
+* **web:** portfolio balance chart match/mismatch logic (#25687) e2596db
 
 
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-web/5.119.1
+web/5.119.2
diff --git a/apps/web/src/components/Charts/PriceChart/index.tsx b/apps/web/src/components/Charts/PriceChart/index.tsx
@@ -34,6 +34,7 @@ export type PriceChartData = CandlestickData<UTCTimestamp> & AreaData<UTCTimesta
 interface PriceChartModelParams extends ChartModelParams<PriceChartData> {
   type: PriceChartType
   timePeriod?: GraphQLApi.HistoryDuration
+  hideYAxis?: boolean
 }
 
 const LOW_PRICE_RANGE_THRESHOLD = 0.2
@@ -157,7 +158,7 @@ export class PriceChartModel extends ChartModel<PriceChartData> {
   }
 
   updateOptions(params: PriceChartModelParams) {
-    const { data, colors, type, locale, format, tokenFormatType } = params
+    const { data, colors, type, locale, format, tokenFormatType, hideYAxis } = params
     const { min, max } = getCandlestickPriceBounds(data)
 
     // Handles changes in time period
@@ -192,11 +193,13 @@ export class PriceChartModel extends ChartModel<PriceChartData> {
           )
         },
       },
-      ...(scaleMargins && {
-        rightPriceScale: {
+      rightPriceScale: {
+        borderVisible: false,
+        ...(hideYAxis && { visible: false, minimumWidth: 0 }),
+        ...(scaleMargins && {
           scaleMargins,
-        },
-      }),
+        }),
+      },
     })
 
     // Handles changing between line/candlestick view
@@ -372,6 +375,8 @@ interface PriceChartProps {
   timePeriod?: GraphQLApi.HistoryDuration
   pricePercentChange24h?: number
   overrideColor?: string
+  headerTotalValueOverride?: number
+  hideYAxis?: boolean
 }
 
 const CandlestickTooltipRow = styled(Flex, {
@@ -414,6 +419,8 @@ export function PriceChart({
   timePeriod,
   pricePercentChange24h,
   overrideColor,
+  headerTotalValueOverride,
+  hideYAxis,
 }: PriceChartProps) {
   const startingPrice = data[0]
   const lastPrice = data[data.length - 1]
@@ -427,31 +434,36 @@ export function PriceChart({
   return (
     <Chart
       Model={PriceChartModel}
-      params={useMemo(() => ({ data, type, stale, timePeriod }), [data, stale, type, timePeriod])}
+      params={useMemo(() => ({ data, type, stale, timePeriod, hideYAxis }), [data, stale, type, timePeriod, hideYAxis])}
       height={height}
       overrideColor={overrideColor}
       TooltipBody={type === PriceChartType.CANDLESTICK ? CandlestickTooltip : undefined}
       showDottedBackground={true}
       showLeftFadeOverlay={type === PriceChartType.LINE}
       showCustomHoverMarker={type === PriceChartType.LINE}
     >
-      {(crosshairData) => (
-        <ChartHeader
-          value={(crosshairData ?? lastPrice).value}
-          additionalFields={
-            <PriceChartDelta
-              startingPrice={startingPrice.close}
-              endingPrice={(crosshairData ?? lastPrice).close}
-              shouldIncludeFiatDelta
-              shouldTreatAsStablecoin={shouldTreatAsStablecoin}
-              pricePercentChange24h={pricePercentChange24h}
-              isHovering={!!crosshairData}
-            />
-          }
-          valueFormatterType={NumberType.FiatTokenPrice}
-          time={crosshairData?.time}
-        />
-      )}
+      {(crosshairData) => {
+        // Use override value when provided, otherwise use chart data value
+        const headerValue = crosshairData ? crosshairData.value : (headerTotalValueOverride ?? lastPrice.value)
+
+        return (
+          <ChartHeader
+            value={headerValue}
+            additionalFields={
+              <PriceChartDelta
+                startingPrice={startingPrice.close}
+                endingPrice={(crosshairData ?? lastPrice).close}
+                shouldIncludeFiatDelta
+                shouldTreatAsStablecoin={shouldTreatAsStablecoin}
+                pricePercentChange24h={pricePercentChange24h}
+                isHovering={!!crosshairData}
+              />
+            }
+            valueFormatterType={NumberType.FiatTokenPrice}
+            time={crosshairData?.time}
+          />
+        )
+      }}
     </Chart>
   )
 }
diff --git a/apps/web/src/pages/Portfolio/Overview/Overview.tsx b/apps/web/src/pages/Portfolio/Overview/Overview.tsx
@@ -1,20 +1,26 @@
+import { ChartPeriod } from '@uniswap/client-data-api/dist/data/v1/api_pb'
 import { EmptyWalletCards } from 'components/emptyWallet/EmptyWalletCards'
 import { usePortfolioRoutes } from 'pages/Portfolio/Header/hooks/usePortfolioRoutes'
 import { usePortfolioAddresses } from 'pages/Portfolio/hooks/usePortfolioAddresses'
 import { OverviewActionTiles } from 'pages/Portfolio/Overview/ActionTiles'
 import { OVERVIEW_RIGHT_COLUMN_WIDTH } from 'pages/Portfolio/Overview/constants'
+import { useIsPortfolioZero } from 'pages/Portfolio/Overview/hooks/useIsPortfolioZero'
 import { PortfolioOverviewTables } from 'pages/Portfolio/Overview/OverviewTables'
 import { PortfolioChart } from 'pages/Portfolio/Overview/PortfolioChart'
 import { OverviewStatsTiles } from 'pages/Portfolio/Overview/StatsTiles'
-import { memo, useMemo } from 'react'
+import { checkBalanceDiffWithinRange } from 'pages/Portfolio/Overview/utils/checkBalanceDiffWithinRange'
+import { memo, useMemo, useState } from 'react'
 import { Flex, Separator, styled, useMedia } from 'ui/src'
+import { useGetPortfolioHistoricalValueChartQuery } from 'uniswap/src/data/rest/getPortfolioChart'
 import { useActivityData } from 'uniswap/src/features/activity/hooks/useActivityData'
 import { useEnabledChains } from 'uniswap/src/features/chains/hooks/useEnabledChains'
 import { usePortfolioTotalValue } from 'uniswap/src/features/dataApi/balances/balancesRest'
 import { ElementName, InterfacePageName, SectionName } from 'uniswap/src/features/telemetry/constants'
 import { Trace } from 'uniswap/src/features/telemetry/Trace'
 import { filterDefinedWalletAddresses } from 'utils/filterDefinedWalletAddresses'
 
+const BALANCE_PERCENT_DIFFERENCE_THRESHOLD = 2
+
 const ActionsAndStatsContainer = styled(Flex, {
   width: OVERVIEW_RIGHT_COLUMN_WIDTH,
   gap: '$spacing16',
@@ -35,18 +41,50 @@ export const PortfolioOverview = memo(function PortfolioOverview() {
   const isFullWidth = media.xl
   const { chainId } = usePortfolioRoutes()
   const portfolioAddresses = usePortfolioAddresses()
-  const { isTestnetModeEnabled } = useEnabledChains()
+  const { chains: allChainIds } = useEnabledChains()
+
+  const isPortfolioZero = useIsPortfolioZero()
+
+  const [selectedPeriod, setSelectedPeriod] = useState<ChartPeriod>(ChartPeriod.DAY)
+
+  const filterChainIds = useMemo(() => (chainId ? [chainId] : allChainIds), [chainId, allChainIds])
 
-  // Fetch portfolio total value to determine if portfolio is zero
   const { data: portfolioData } = usePortfolioTotalValue({
     evmAddress: portfolioAddresses.evmAddress,
     svmAddress: portfolioAddresses.svmAddress,
+    chainIds: filterChainIds,
   })
 
-  const { balanceUSD } = portfolioData || {}
+  // Fetch portfolio historical value chart data
+  const {
+    data: portfolioChartData,
+    isPending: isChartPending,
+    error: chartError,
+  } = useGetPortfolioHistoricalValueChartQuery({
+    input: {
+      evmAddress: portfolioAddresses.evmAddress,
+      svmAddress: portfolioAddresses.svmAddress,
+      chainIds: filterChainIds,
+      chartPeriod: selectedPeriod,
+    },
+    enabled: !!(portfolioAddresses.evmAddress || portfolioAddresses.svmAddress),
+  })
+
+  // Get the latest value from chart endpoint (last point in the array) for comparison
+  const chartTotalBalanceUSD = useMemo(() => {
+    if (!portfolioChartData?.points || portfolioChartData.points.length === 0) {
+      return undefined
+    }
+    const lastPoint = portfolioChartData.points[portfolioChartData.points.length - 1]
+    return lastPoint.value
+  }, [portfolioChartData])
 
-  // Calculate isPortfolioZero - denominated portfolio balance on testnet is always 0
-  const isPortfolioZero = useMemo(() => !isTestnetModeEnabled && balanceUSD === 0, [isTestnetModeEnabled, balanceUSD])
+  // Compare portfolio balance (EVM + Solana) with chart endpoint balance (for debugging/validation)
+  const isTotalValueMatch = checkBalanceDiffWithinRange({
+    chartTotalBalanceUSD,
+    portfolioTotalBalanceUSD: portfolioData?.balanceUSD,
+    percentDifferenceThreshold: BALANCE_PERCENT_DIFFERENCE_THRESHOLD,
+  })
 
   // Fetch activity data once at the top level to share between useSwapsThisWeek and MiniActivityTable
   const activityData = useActivityData({
@@ -63,7 +101,16 @@ export const PortfolioOverview = memo(function PortfolioOverview() {
       <Flex gap="$spacing40" mb="$spacing40">
         <Flex row gap="$spacing40" $xl={{ flexDirection: 'column' }}>
           <Trace section={SectionName.PortfolioOverviewTab} element={ElementName.PortfolioChart}>
-            <PortfolioChart isPortfolioZero={isPortfolioZero} />
+            <PortfolioChart
+              portfolioTotalBalanceUSD={portfolioData?.balanceUSD}
+              isPortfolioZero={isPortfolioZero}
+              chartData={portfolioChartData}
+              isPending={isChartPending}
+              error={chartError}
+              selectedPeriod={selectedPeriod}
+              setSelectedPeriod={setSelectedPeriod}
+              isTotalValueMatch={isTotalValueMatch}
+            />
           </Trace>
           {isPortfolioZero ? (
             <ActionsAndStatsContainer minHeight={120} fullWidth={isFullWidth}>
diff --git a/apps/web/src/pages/Portfolio/Overview/PortfolioChart.tsx b/apps/web/src/pages/Portfolio/Overview/PortfolioChart.tsx
@@ -1,12 +1,10 @@
-import { ChartPeriod } from '@uniswap/client-data-api/dist/data/v1/api_pb'
+import { ChartPeriod, GetPortfolioChartResponse } from '@uniswap/client-data-api/dist/data/v1/api_pb'
 import { GraphQLApi } from '@universe/api'
 import { ChartSkeleton } from 'components/Charts/LoadingState'
 import { PriceChart, PriceChartData } from 'components/Charts/PriceChart'
 import { ChartType, PriceChartType } from 'components/Charts/utils'
 import { UTCTimestamp } from 'lightweight-charts'
-import { usePortfolioRoutes } from 'pages/Portfolio/Header/hooks/usePortfolioRoutes'
-import { usePortfolioAddresses } from 'pages/Portfolio/hooks/usePortfolioAddresses'
-import { useMemo, useState } from 'react'
+import { useMemo } from 'react'
 import { useTranslation } from 'react-i18next'
 import {
   Flex,
@@ -18,8 +16,6 @@ import {
   useMedia,
   useSporeColors,
 } from 'ui/src'
-import { useGetPortfolioHistoricalValueChartQuery } from 'uniswap/src/data/rest/getPortfolioChart'
-import { useEnabledChains } from 'uniswap/src/features/chains/hooks/useEnabledChains'
 import { useLocalizationContext } from 'uniswap/src/features/language/LocalizationContext'
 import { NumberType } from 'utilities/src/format/types'
 
@@ -70,17 +66,29 @@ function convertPortfolioChartDataToPriceChartData(
 
 interface PortfolioChartProps {
   isPortfolioZero: boolean
+  chartData?: GetPortfolioChartResponse
+  isPending: boolean
+  error?: Error | null
+  selectedPeriod: ChartPeriod
+  setSelectedPeriod: (period: ChartPeriod) => void
+  portfolioTotalBalanceUSD?: number
+  isTotalValueMatch: boolean
 }
 
-export function PortfolioChart({ isPortfolioZero }: PortfolioChartProps): JSX.Element {
+export function PortfolioChart({
+  isPortfolioZero,
+  chartData: portfolioChartData,
+  isPending,
+  error,
+  portfolioTotalBalanceUSD,
+  selectedPeriod,
+  setSelectedPeriod,
+  isTotalValueMatch,
+}: PortfolioChartProps): JSX.Element {
   const { t } = useTranslation()
   const media = useMedia()
   const colors = useSporeColors()
-  const { chainId } = usePortfolioRoutes()
-  const portfolioAddresses = usePortfolioAddresses()
-  const { chains: chainIds } = useEnabledChains()
   const { convertFiatAmountFormatted } = useLocalizationContext()
-  const [selectedPeriod, setSelectedPeriod] = useState<ChartPeriod>(ChartPeriod.DAY)
 
   const periodOptions = useMemo<Array<SegmentedControlOption<string>>>(() => {
     const options: Array<[ChartPeriod, string]> = [
@@ -100,22 +108,12 @@ export function PortfolioChart({ isPortfolioZero }: PortfolioChartProps): JSX.El
     }))
   }, [selectedPeriod, t])
 
-  const { data, isPending, error } = useGetPortfolioHistoricalValueChartQuery({
-    input: {
-      evmAddress: portfolioAddresses.evmAddress,
-      svmAddress: portfolioAddresses.svmAddress,
-      chainIds: chainId ? [chainId] : chainIds,
-      chartPeriod: selectedPeriod,
-    },
-    enabled: !!(portfolioAddresses.evmAddress || portfolioAddresses.svmAddress),
-  })
-
   const chartData = useMemo(() => {
-    if (!data?.points) {
+    if (!portfolioChartData?.points) {
       return []
     }
-    return convertPortfolioChartDataToPriceChartData(data.points)
-  }, [data])
+    return convertPortfolioChartDataToPriceChartData(portfolioChartData.points)
+  }, [portfolioChartData])
 
   // Determine color based on portfolio balance change
   const chartColor = useMemo(() => {
@@ -163,14 +161,18 @@ export function PortfolioChart({ isPortfolioZero }: PortfolioChartProps): JSX.El
           <Separator borderBottomWidth={3} borderColor="$surface3" position="absolute" top="60%" left="0" right="0" />
         </Flex>
       ) : (
-        <PriceChart
-          data={chartData}
-          height={CHART_HEIGHT}
-          type={PriceChartType.LINE}
-          stale={false}
-          timePeriod={chartPeriodToHistoryDuration(selectedPeriod)}
-          overrideColor={chartColor}
-        />
+        <Flex pointerEvents={isTotalValueMatch ? 'auto' : 'none'}>
+          <PriceChart
+            data={chartData}
+            height={CHART_HEIGHT}
+            type={PriceChartType.LINE}
+            stale={false}
+            timePeriod={chartPeriodToHistoryDuration(selectedPeriod)}
+            overrideColor={chartColor}
+            headerTotalValueOverride={portfolioTotalBalanceUSD}
+            hideYAxis={!isTotalValueMatch}
+          />
+        </Flex>
       )}
       <Flex
         $md={{ width: '100%' }}
diff --git a/apps/web/src/pages/Portfolio/Overview/hooks/useIsPortfolioZero.ts b/apps/web/src/pages/Portfolio/Overview/hooks/useIsPortfolioZero.ts
@@ -0,0 +1,24 @@
+import { usePortfolioAddresses } from 'pages/Portfolio/hooks/usePortfolioAddresses'
+import { useMemo } from 'react'
+import { useEnabledChains } from 'uniswap/src/features/chains/hooks/useEnabledChains'
+import { usePortfolioTotalValue } from 'uniswap/src/features/dataApi/balances/balancesRest'
+
+/**
+ * Hook to determine if the portfolio balance is zero.
+ * Denominated portfolio balance on testnet is always 0, so we don't consider it zero in testnet mode.
+ */
+export function useIsPortfolioZero(): boolean {
+  const portfolioAddresses = usePortfolioAddresses()
+  const { isTestnetModeEnabled } = useEnabledChains()
+
+  // Fetch portfolio total value to determine if portfolio is zero
+  const { data: portfolioData } = usePortfolioTotalValue({
+    evmAddress: portfolioAddresses.evmAddress,
+    svmAddress: portfolioAddresses.svmAddress,
+  })
+
+  const { balanceUSD } = portfolioData || {}
+
+  // Calculate isPortfolioZero - denominated portfolio balance on testnet is always 0
+  return useMemo(() => !isTestnetModeEnabled && balanceUSD === 0, [isTestnetModeEnabled, balanceUSD])
+}
diff --git a/apps/web/src/pages/Portfolio/Overview/utils/checkBalanceDiffWithinRange.ts b/apps/web/src/pages/Portfolio/Overview/utils/checkBalanceDiffWithinRange.ts
