Replies: 7 comments 12 replies
-
|
Yeah, this seems to be a bug. As noted in the code, I am aware of the parted shrinking not being 100%, and a hack, Try adding You can also try to uncomment the first line and comment out the second. I'll see if I can figure out a way to setup an environment to test this locally, but for the moment, I am not able to. Edit
Note that I refrained from transferring this to an issue until we know if there is a possibility to fix this without me being able to test this locally. Edit 2 |
Beta Was this translation helpful? Give feedback.
-
|
I'll give that a try when I get a moment. Luckily, for that one, the image was small enough and I could burn with -atlz (no "s") and it was fine. |
Beta Was this translation helpful? Give feedback.
-
|
I saw your post on armbian forums and assume it has to do with your devices having the same PTUUID. I created a branch from testing called "gpt" that you can use for testing in this situation. Change to it the same way you change to testing, ie: Feel free to fork on github and use that branch to test your changes. If you then make a pr (pull request) and if all looks good, I will accept it and you become a contributor. :) Edit If none of above works, I have further ideas that can be tried. |
Beta Was this translation helpful? Give feedback.
-
|
I'll hopefully have some time next week to continue this. Thank you for all your efforts! |
Beta Was this translation helpful? Give feedback.
-
|
I'll keep working on the other stuff in the meantime, but keep in mind, if I am ready for a new release and nothing has been done about this, it is very likely I will remove support for gpt. The things needed should not take more than a few minutes to test if you have the hardware for it. It all boils down to what I can verify is working or not with the hardware I own. |
Beta Was this translation helpful? Give feedback.
-
|
Understood. Do what you have to do (of course)! My struggle right now is with the unreliability of this new Radxa cubie a5e. It has OS, driver and possibly hardware issues that cause lockups and kernel panics, so I'm trying to sort through these larger issues to allow me to test shrink-backup knowing that the hardware will keep working for at least the time it takes to make a backup. :-) It's the only device I have with an NVME and gpt filesystem (I think). I'm not sure if the e20 or e25 use gpt, I'll have to check, they have eMMC's, but ATM my focus is on getting this a5e working reliably, if that's even possible! I have downloaded the gpt version of shrink-backup and will use it for testing and report back. |
Beta Was this translation helpful? Give feedback.
-
|
Got one test done. |
Beta Was this translation helpful? Give feedback.
-
|
2nd test done. Shows this output: |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
It was giving the answer "Yes" to the question "Fix/Ignore". Which answer do you want? Do you want it to fix or ignore? |
Beta Was this translation helpful? Give feedback.
-
|
Did it give the answer yes, even though you added option -f? |
Beta Was this translation helpful? Give feedback.
-
|
No, I had heard that parted will ALWAYS prompt when doing something possibly damaging, like shrinking a partition, and the only way around it is with |
Beta Was this translation helpful? Give feedback.
-
|
That has been true in the past yes, I don't know if it's fixed or not, you are the one doing the testing and have to test every single way.
If you can provide proof of that that is the situation on every single device in every single operation then sure, an if statement could suffice. So is expanding with -a in an update working? shrinking in update? Manual expanding in update? If you want this to be in the script, you have to test every single possibility and provide that info or I can not provide support or change anything in the code. The only reason I have that very specific hack in the script is because I have tested every single possible way I can think of to end up in that part of the script running, you have to do the same for gpt. Another possible way that might solve this is to do what is done at creation, delete the partition and then recreate it, but I don't know if this will fix this situation or screw anything up. |
Beta Was this translation helpful? Give feedback.
-
|
I'd be happy if it works just for me, but I understand that you'll want additional testing before you add it to your build. My e25 also uses GPT, so I can do some testing with it. Output: using ---pretend-input-tty: Output: Weird that it needs the Partition # and End passed to it again, even though they're specified in the commandline already? |
Beta Was this translation helpful? Give feedback.
-
Well, if this is just for you, I wish you good luck. If your goal is to get this into shrink-backup, then I have other ideas but for me to spend time typing out info about that, I will need confirmation we both are on the same page. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, I thought you'd be happy that I took many hours of time I really don't have, to do additional testing and report back, including finding a solution that worked, but I really don't know what page you're on. You're a difficult read. |
Beta Was this translation helpful? Give feedback.
-
|
I really do appreciate your feedback, if you do it for the sake of the project, not for personal gain. As far as I'm concerned, all supported operating systems use mbr, so all I have to do is remove the mention of gpt, say it requires mbr and be done with it. I'm sorry if that is not acceptable for you. That is why I created the issue request asking for help, NOT to put all pressure on you. I have to set a limit on my time at some point. I hope you understand. If you want to pick this up, feel free to let me know by acknowledging this is for the sake of shrink-backup. |
Beta Was this translation helpful? Give feedback.
-
|
If it wasn't for your benefit and the for the greater good, I never would have bothered to report the issue and would simply have come up with my own fix, and nobody would ever have known. Reporting and testing means I want to help. For now, anyway. As a programmer myself, the MOST valuable thing any user has to offer is their time and feedback. It's incredibly precious to me and never taken for granted. If I'm ever lucky enough to have even one person report a bug or actually do some testing, I'm overjoyed. It's incredibly rare and for me, extremely frustrating to get no feedback, even though I know full well that 100's if not 1000's of people are using my software, that I often spend years creating, just for the greater good. |
Beta Was this translation helpful? Give feedback.
-
|
I DO appreciate feedback, even this. 👍 You have helped me multiple times by pointing out issues, giving ideas and providing general feedback, again, thank you for that. Heck, the -s option was your idea and I could implement it for you within a day or two. BTW you should probably choose ignore on the first parted question, the img file is not yet truncated so the partition will not cover the whole size, therefore things are exactly as they should and no "fix" is required in that regard. The "fix" needed is to repair/move the backup database for the gpt partition table. Maybe a corrupt table is acceptable for you, but it is definitely not acceptable for shrink-backup to be considered supported. The final solution should probably be done similarly as when creating the img, ie resize fs > remove partition > shrink img file > recreate partition. But an overhaul on a core system in shrink-backup like that would require lots of testing, hence, very low on the list. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
This is a Radxa cubie a5e, running armbin trixie. It has an sd card and nvme. I'm trying to image the sd card to my usb stick, mounted at
/media/usbThe process gets as far as the shrinking section, then has a Parted error. Let me know if you think this is something wrong with my system or something else?
Here's the main error:
Here's the full log:
Beta Was this translation helpful? Give feedback.
All reactions