Fix stale constant references left over from merge

Constants.java's UPPER_SNAKE_CASE rename (PR #192, merged from main) landed
after the motorized intake arm's CAN ports and current-limit/voltage constants
were written against the old names, so they never got renamed. Update the two
Spark IO files to match.

Author: nlaverdure

src/main/java/frc/robot/subsystems/intake/IntakeArmIOSimSpark.java

@@ -40,8 +40,8 @@ public class IntakeArmIOSimSpark implements IntakeArmIO {
   private final SparkMaxConfig followerConfig;
 
   public IntakeArmIOSimSpark() {
-    maxRight = new SparkMax(CAN2.intakeArmRight, MotorType.kBrushless);
-    maxLeft = new SparkMax(CAN2.intakeArmLeft, MotorType.kBrushless);
+    maxRight = new SparkMax(CAN2.INTAKE_ARM_RIGHT, MotorType.kBrushless);
+    maxLeft = new SparkMax(CAN2.INTAKE_ARM_LEFT, MotorType.kBrushless);
 
     controller = maxRight.getClosedLoopController();
 
@@ -50,8 +50,8 @@ public IntakeArmIOSimSpark() {
     armConfig
         .inverted(false)
         .idleMode(IdleMode.kBrake)
-        .smartCurrentLimit(NEOConstants.kDefaultSupplyCurrentLimit)
-        .voltageCompensation(RobotConstants.kNominalVoltage);
+        .smartCurrentLimit(NEOConstants.DEFAULT_SUPPLY_CURRENT_LIMIT)
+        .voltageCompensation(RobotConstants.NOMINAL_VOLTAGE);
 
     armConfig
         .encoder
@@ -69,7 +69,7 @@ public IntakeArmIOSimSpark() {
 
     followerConfig = new SparkMaxConfig();
 
-    followerConfig.apply(armConfig).follow(CAN2.intakeArmRight);
+    followerConfig.apply(armConfig).follow(CAN2.INTAKE_ARM_RIGHT);
 
     maxRight.configure(armConfig, ResetMode.kResetSafeParameters, PersistMode.kPersistParameters);
     maxSim = new SparkMaxSim(maxRight, gearbox);
@@ -108,13 +108,13 @@ public void updateInputs(IntakeArmIOInputs inputs) {
 
   @Override
   public void setOpenLoop(Voltage volts) {
-    maxSim.setAppliedOutput(volts.in(Volts) / RobotConstants.kNominalVoltage);
+    maxSim.setAppliedOutput(volts.in(Volts) / RobotConstants.NOMINAL_VOLTAGE);
   }
 
   @Override
   public void setPosition(Angle rotation, AngularVelocity velocity) {
     double feedforward =
-        RobotConstants.kNominalVoltage
+        RobotConstants.NOMINAL_VOLTAGE
             * velocity.in(RadiansPerSecond)
             / maxAngularVelocity.in(RadiansPerSecond);
     controller.setSetpoint(

src/main/java/frc/robot/subsystems/intake/IntakeArmIOSpark.java

@@ -49,8 +49,8 @@ public class IntakeArmIOSpark implements IntakeArmIO {
   private boolean relativeEncoderSeeded = false;
 
   public IntakeArmIOSpark() {
-    intakeArmLeft = new SparkMax(CAN2.intakeArmLeft, MotorType.kBrushless);
-    intakeArmRight = new SparkMax(CAN2.intakeArmRight, MotorType.kBrushless);
+    intakeArmLeft = new SparkMax(CAN2.INTAKE_ARM_LEFT, MotorType.kBrushless);
+    intakeArmRight = new SparkMax(CAN2.INTAKE_ARM_RIGHT, MotorType.kBrushless);
     absoluteEncoder = intakeArmLeft.getAbsoluteEncoder();
     encoderSpark = intakeArmLeft.getEncoder();
     intakeArmController = intakeArmLeft.getClosedLoopController();
@@ -67,8 +67,8 @@ public IntakeArmIOSpark() {
     leftArmConfig
         .inverted(false)
         .idleMode(IdleMode.kBrake)
-        .smartCurrentLimit(NEOConstants.kDefaultSupplyCurrentLimit)
-        .voltageCompensation(RobotConstants.kNominalVoltage);
+        .smartCurrentLimit(NEOConstants.DEFAULT_SUPPLY_CURRENT_LIMIT)
+        .voltageCompensation(RobotConstants.NOMINAL_VOLTAGE);
 
     leftArmConfig
         .encoder
@@ -92,7 +92,7 @@ public IntakeArmIOSpark() {
 
     rightArmConfig = new SparkMaxConfig();
 
-    rightArmConfig.apply(leftArmConfig).follow(CAN2.intakeArmRight, true);
+    rightArmConfig.apply(leftArmConfig).follow(CAN2.INTAKE_ARM_RIGHT, true);
 
     leftArmConfig
         .signals
@@ -140,7 +140,7 @@ public void setOpenLoop(Voltage volts) {
   @Override
   public void setPosition(Angle rotation, AngularVelocity velocity) {
     double feedforward =
-        RobotConstants.kNominalVoltage
+        RobotConstants.NOMINAL_VOLTAGE
             * velocity.in(RadiansPerSecond)
             / maxAngularVelocity.in(RadiansPerSecond);
     double setpoint = MathUtil.clamp(rotation.magnitude(), minPosRad, maxPosRad);