fix(heartbeat): persist per-agent enabled and interval settings to heartbeat overrides (#230)

The heartbeat API endpoints were not reading or persisting per-agent heartbeat
overrides (enabled, interval) that the cron script relies on. The GET endpoint now
returns enabled and interval from agent settings, and the PUT endpoint persists
them to settings.agents[id].heartbeat. The UI now correctly saves these fields
to the per-agent endpoint instead of the global monitoring settings.

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

Author: jlia0

packages/server/src/routes/agents.ts

@@ -265,7 +265,7 @@ app.get('/api/agents/:id/memory', (c) => {
     return c.json({ index, files, memoryDir });
 });
 
-// GET /api/agents/:id/heartbeat — read heartbeat.md from workspace
+// GET /api/agents/:id/heartbeat — read heartbeat.md and settings from workspace
 app.get('/api/agents/:id/heartbeat', (c) => {
     const agentId = c.req.param('id');
     const settings = getSettings();
@@ -277,19 +277,39 @@ app.get('/api/agents/:id/heartbeat', (c) => {
     if (fs.existsSync(heartbeatMd)) {
         try { content = fs.readFileSync(heartbeatMd, 'utf8'); } catch { /* skip */ }
     }
-    return c.json({ content, path: heartbeatMd });
+    return c.json({
+        content,
+        path: heartbeatMd,
+        enabled: agent.heartbeat?.enabled ?? true,
+        interval: agent.heartbeat?.interval,
+    });
 });
 
-// PUT /api/agents/:id/heartbeat — write heartbeat.md to workspace
+// PUT /api/agents/:id/heartbeat — write heartbeat.md and settings to workspace
 app.put('/api/agents/:id/heartbeat', async (c) => {
     const agentId = c.req.param('id');
     const settings = getSettings();
     const agent = settings.agents?.[agentId];
     if (!agent) return c.json({ error: `agent '${agentId}' not found` }, 404);
 
-    const body = await c.req.json() as { content: string };
-    const heartbeatMd = path.join(agent.working_directory, 'heartbeat.md');
-    fs.writeFileSync(heartbeatMd, body.content || '', 'utf8');
+    const body = await c.req.json() as { content?: string; enabled?: boolean; interval?: number };
+
+    // Write heartbeat.md if content provided
+    if (body.content != null) {
+        const heartbeatMd = path.join(agent.working_directory, 'heartbeat.md');
+        fs.writeFileSync(heartbeatMd, body.content || '', 'utf8');
+    }
+
+    // Persist heartbeat overrides to settings.json
+    if (body.enabled != null || body.interval != null) {
+        mutateSettings(s => {
+            if (!s.agents?.[agentId]) return;
+            if (!s.agents[agentId].heartbeat) s.agents[agentId].heartbeat = {};
+            if (body.enabled != null) s.agents[agentId].heartbeat!.enabled = body.enabled;
+            if (body.interval != null) s.agents[agentId].heartbeat!.interval = body.interval;
+        });
+    }
+
     return c.json({ ok: true });
 });
 

tinyoffice/src/app/agents/[id]/page.tsx

@@ -4,16 +4,13 @@ import { useState, useCallback, useEffect, use } from "react";
 import { usePolling } from "@/lib/hooks";
 import {
   getAgents,
-  getSettings,
-  updateSettings,
   getAgentSkills,
   getAgentSystemPrompt,
   saveAgentSystemPrompt,
   getAgentMemory,
   getAgentHeartbeat,
   saveAgentHeartbeat,
   type AgentConfig,
-  type Settings,
   type WorkspaceSkill,
 } from "@/lib/api";
 import { cn } from "@/lib/utils";
@@ -74,7 +71,6 @@ export default function AgentConfigPage({
     getAgents,
     0,
   );
-  const { data: settings } = usePolling<Settings>(getSettings, 0);
 
   const [activeTab, setActiveTab] = useState<TabId>("chat");
   const [spSaving, setSpSaving] = useState(false);
@@ -130,20 +126,15 @@ export default function AgentConfigPage({
       .then((data) => {
         setHeartbeatContent(data.content);
         setHeartbeatPath(data.path);
+        setHeartbeatEnabled(data.enabled);
+        if (data.interval != null) {
+          setHeartbeatInterval(String(data.interval));
+        }
         setHeartbeatLoaded(true);
       })
       .catch(() => setHeartbeatLoaded(true));
   }, [agent, agentId]);
 
-  // Sync heartbeat interval from settings unless the user has edited it
-  useEffect(() => {
-    if (!settings?.monitoring) return;
-    const interval = settings.monitoring.heartbeat_interval;
-    if (typeof interval === "number") {
-      setHeartbeatInterval(String(interval));
-    }
-  }, [settings]);
-
   // Convert workspace skills to SkillEntry format for constellation
   const constellationSkills: SkillEntry[] = workspaceSkills.map((s) => ({
     id: s.id,
@@ -169,23 +160,19 @@ export default function AgentConfigPage({
     if (!agent) return;
     setHbSaving(true);
     try {
-      await saveAgentHeartbeat(agentId, heartbeatContent);
-      if (settings?.monitoring) {
-        await updateSettings({
-          monitoring: {
-            ...settings.monitoring,
-            heartbeat_interval: parseInt(heartbeatInterval) || 300,
-          },
-        });
-      }
+      await saveAgentHeartbeat(agentId, {
+        content: heartbeatContent,
+        enabled: heartbeatEnabled,
+        interval: parseInt(heartbeatInterval) || 300,
+      });
       setHbSaved(true);
       setTimeout(() => setHbSaved(false), 2000);
     } catch {
       // Error handling
     } finally {
       setHbSaving(false);
     }
-  }, [agent, agentId, heartbeatContent, heartbeatEnabled, heartbeatInterval, settings]);
+  }, [agent, agentId, heartbeatContent, heartbeatEnabled, heartbeatInterval]);
 
   const refreshWorkspaceData = useCallback(() => {
     getAgentSkills(agentId)

tinyoffice/src/lib/api.ts

@@ -215,14 +215,14 @@ export async function getAgentMemory(agentId: string): Promise<{ index: string;
   return apiFetch(`/api/agents/${encodeURIComponent(agentId)}/memory`);
 }
 
-export async function getAgentHeartbeat(agentId: string): Promise<{ content: string; path: string }> {
+export async function getAgentHeartbeat(agentId: string): Promise<{ content: string; path: string; enabled: boolean; interval?: number }> {
   return apiFetch(`/api/agents/${encodeURIComponent(agentId)}/heartbeat`);
 }
 
-export async function saveAgentHeartbeat(agentId: string, content: string): Promise<{ ok: boolean }> {
+export async function saveAgentHeartbeat(agentId: string, data: { content?: string; enabled?: boolean; interval?: number }): Promise<{ ok: boolean }> {
   return apiFetch(`/api/agents/${encodeURIComponent(agentId)}/heartbeat`, {
     method: "PUT",
-    body: JSON.stringify({ content }),
+    body: JSON.stringify(data),
   });
 }