Fix CI tests to run in mock mode only - no hardware access

- Added CI environment detection in comprehensive system test
- Force mock mode for MaiTai and Elliptec controllers in CI
- Skip hardware connection attempts when running in CI mode
- Updated unit tests to ensure proper mock mode validation
- Added CI and PYMODAQ_TEST_MODE environment variables to workflows
- Enhanced test output to clearly indicate CI mode operation

Key changes:
- Comprehensive test detects CI via GITHUB_ACTIONS/CI env vars
- Hardware controllers skip connect() calls in CI mode
- PyMoDAQ plugins already use mock mode (mock_mode=True)
- All 21 unit tests pass in CI mode without hardware access
- Clear "RUNNING IN CI MODE" indication in test output

This ensures the CI pipeline runs safely without attempting
to access real hardware devices via serial ports.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: TheFermiSea

.github/workflows/ci.yml

@@ -53,6 +53,8 @@ jobs:
         QT_QPA_PLATFORM: offscreen
         QT_DEBUG_PLUGINS: 0
         DISPLAY: :99
+        CI: true
+        PYMODAQ_TEST_MODE: mock
 
     - name: Run comprehensive system test
       run: |
@@ -62,6 +64,8 @@ jobs:
       env:
         QT_QPA_PLATFORM: offscreen
         QT_DEBUG_PLUGINS: 0
+        CI: true
+        PYMODAQ_TEST_MODE: mock
 
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v3

test_comprehensive_system.py

@@ -21,9 +21,14 @@
 # Add src to path
 sys.path.insert(0, 'src')
 
+# Check if running in CI environment
+IS_CI = os.environ.get('CI', 'false').lower() == 'true' or os.environ.get('GITHUB_ACTIONS', 'false').lower() == 'true'
+
 print("COMPREHENSIVE URASHG SYSTEM TESTING")
 print("=" * 60)
 print("Testing all hardware controllers, plugins, and integrations")
+if IS_CI:
+    print("RUNNING IN CI MODE - Mock mode enabled, hardware access disabled")
 print()
 
 # Test Results Storage
@@ -68,15 +73,19 @@ def test_hardware_controller(name: str, module_path: str, class_name: str, **kwa
             info = controller.get_device_info()
             print(f"   Device info: {info.get('model', 'Unknown')}")
 
-        # Test connection attempt (will fail without hardware, which is expected)
-        if hasattr(controller, 'connect'):
+        # Test connection attempt (skip in CI to avoid hardware access)
+        if hasattr(controller, 'connect') and not IS_CI:
             connected = controller.connect()
             if connected:
                 print(f"   WARNING: {name} connected unexpectedly")
                 if hasattr(controller, 'disconnect'):
                     controller.disconnect()
             else:
                 print(f"   Connection failed as expected (no hardware)")
+        elif hasattr(controller, 'connect') and IS_CI:
+            print(f"   Skipping connection test in CI mode")
+        else:
+            print(f"   No connection method available")
 
         print(f"   {name} controller: PASS")
         return True
@@ -161,12 +170,13 @@ def test_pymodaq_plugin(name: str, module_path: str, class_name: str) -> bool:
 print("HARDWARE CONTROLLER TESTS")
 print("-" * 40)
 
-# Test MaiTai Controller
+# Test MaiTai Controller (force mock mode in CI)
 test_results['maitai_controller'] = test_hardware_controller(
     "MaiTai",
     "pymodaq_plugins_urashg.hardware.urashg.maitai_control",
     "MaiTaiController",
-    port='/dev/ttyUSB0'
+    port='/dev/ttyUSB0',
+    mock_mode=IS_CI
 )
 
 print()
@@ -176,12 +186,13 @@ def test_pymodaq_plugin(name: str, module_path: str, class_name: str) -> bool:
     "Elliptec",
     "pymodaq_plugins_urashg.hardware.urashg.elliptec_wrapper",
     "ElliptecController",
-    port='/dev/ttyUSB1'
+    port='/dev/ttyUSB1',
+    mock_mode=IS_CI
 )
 
 print()
 
-# Test Newport 1830C Controller
+# Test Newport 1830C Controller (no mock mode available, but don't connect in CI)
 test_results['newport1830c_controller'] = test_hardware_controller(
     "Newport 1830C",
     "pymodaq_plugins_urashg.hardware.urashg.newport1830c_controller", 
@@ -191,7 +202,7 @@ def test_pymodaq_plugin(name: str, module_path: str, class_name: str) -> bool:
 
 print()
 
-# Test ESP300 Controller
+# Test ESP300 Controller (no mock mode available, but don't connect in CI)
 test_results['esp300_controller'] = test_hardware_controller(
     "ESP300",
     "pymodaq_plugins_urashg.hardware.urashg.esp300_controller",

tests/unit/test_hardware_controllers.py

@@ -43,15 +43,21 @@ def test_elliptec_controller_mock_creation():
     assert controller.mock_mode is True
 
 def test_newport1830c_controller_mock_creation():
-    """Test Newport 1830C controller creation"""
+    """Test Newport 1830C controller creation in mock mode"""
     from pymodaq_plugins_urashg.hardware.urashg.newport1830c_controller import Newport1830CController
+    # Newport controller doesn't have mock mode, but we test without connecting
     controller = Newport1830CController(port='/dev/ttyUSB2')
     assert controller is not None
     assert controller.port == '/dev/ttyUSB2'
+    # Ensure it doesn't try to connect in tests
+    assert not controller._connected
 
 def test_esp300_controller_mock_creation():
-    """Test ESP300 controller creation"""
+    """Test ESP300 controller creation in mock mode"""  
     from pymodaq_plugins_urashg.hardware.urashg.esp300_controller import ESP300Controller
+    # ESP300 controller doesn't have mock mode, but we test without connecting
     controller = ESP300Controller(port='/dev/ttyUSB3')
     assert controller is not None
-    assert controller.port == '/dev/ttyUSB3'
+    assert controller.port == '/dev/ttyUSB3'
+    # Ensure it doesn't try to connect in tests
+    assert not hasattr(controller, '_connected') or not controller._connected