Fix(rebar): use shell geometry if rebars are not exported as SweptDiskSolids (#156)

* docs: document ItemDataConfig and full-property examples

* fix(rebar): use shell geometry if rebars are not exported as SweptDiskSolids

* chore: clean up debug logs

* fix: reset attributesToExclude to ensure all attributes are processed

* revert: remove attributesToExclude clearing from active PR

Author: MiguelG97

packages/fragments/src/FragmentsModels/src/multithreading/connection-handlers.ts

@@ -13,6 +13,7 @@ export class ConnectionHandlers {
     this._list.set(id, handler);
   }
 
+  // It resolves the awaited model.threads.fetch(...)
   run(data: any) {
     const handler = this._list.get(data.requestId) as ThreadHandler;
     this._list.delete(data.requestId);

packages/fragments/src/FragmentsModels/src/multithreading/fragments-connection.ts

@@ -29,15 +29,22 @@ export class FragmentsConnection extends Connection {
     return response.result;
   }
 
-  protected override async fetchConnection(input: any) {
+  protected override async fetchConnection(input: any): Promise<MessagePort> {
     const thread = this._data.getAndCheckThread(input.modelId);
     if (thread) {
       return this._data.getPort(thread);
     }
     return this.setupNewThread(input);
   }
 
-  private setupNewThread(input: any) {
+  /**
+   * This method either:
+   * - creates a new worker thread (if CPU cores are available)
+   * - assigns the task to an existing worker with the lowest load.
+   * @param input
+   * @returns
+   */
+  private setupNewThread(input: any): MessagePort {
     const helper = MultithreadingHelper;
     this._data.usePlaceholder(input.modelId);
     const currentThreads = this._data.getThreadAmount();
@@ -47,7 +54,13 @@ export class FragmentsConnection extends Connection {
     }
     return this._data.balanceThreadLoad(input);
   }
-
+  /**
+   * Creates a `MessageChannel` to establish a bidirectional
+   * communication link between the main thread and the worker.
+   * - `port1` is kept on the main thread
+   * - `port2` is transferred to the worker via `postMessage`
+   * @param newThread
+   */
   private setupThread(newThread: Thread) {
     const threadChannel = new MessageChannel();
     const p1 = threadChannel.port1;

packages/fragments/src/FragmentsModels/src/multithreading/fragments-thread.ts

@@ -5,6 +5,8 @@ import { ThreadControllerManager } from "./thread-controllers/thread-controller-
 export class FragmentsThread {
   readonly actions: { [index: number]: any } = {};
   readonly list = new Map<string, VirtualFragmentsModel>();
+
+  // It registers all actions from multithreadingRequestClass
   readonly controllerManager = new ThreadControllerManager(this);
 
   private _connection?: Connection;

packages/fragments/src/Importers/IfcImporter/index.ts

@@ -97,7 +97,7 @@ export class IfcImporter {
       ...ifcClasses.base,
       ...ifcClasses.materials,
       ...ifcClasses.properties,
-      ...ifcClasses.units
+      ...ifcClasses.units,
     ]),
   };
 

packages/fragments/src/Importers/IfcImporter/src/geometry/ifc-file-reader.ts

@@ -209,22 +209,30 @@ export class IfcFileReader {
       }
 
       for (let i = 0; i < geometryCount; i++) {
+        let geometryMode: "Shell" | "CircleExtrusion" = "Shell";
+
         if (element.type === WEBIFC.IFCREINFORCINGBAR) {
-          this.loadCircleExtrusionGeometry(
+          // Rebars can be SweptDiskSolid, FacetedBrep, Tessellated, ...
+          // if it doesn't have a directrix, it's not a SweptDiskSolid shape representation
+          if (this.hasSweptDiskDirectrix(modelID, mesh, i))
+            geometryMode = "CircleExtrusion";
+        }
+        if (geometryMode === "Shell") {
+          this.loadShellGeometry(
             modelID,
             element,
             mesh,
             i,
             transformWithoutScale.elements,
+            currentCategory,
           );
-        } else {
-          this.loadShellGeometry(
+        } else if (geometryMode === "CircleExtrusion") {
+          this.loadCircleExtrusionGeometry(
             modelID,
             element,
             mesh,
             i,
             transformWithoutScale.elements,
-            currentCategory,
           );
         }
       }
@@ -314,6 +322,7 @@ export class IfcFileReader {
     this._problematicGeometriesHashes.clear();
   }
 
+  // @ts-ignore
   private loadCircleExtrusionGeometry(
     modelID: number,
     element: IfcElement,
@@ -370,7 +379,6 @@ export class IfcFileReader {
 
     // @ts-ignore
     const circleExtrusion = geometry.GetSweptDiskSolid();
-
     const circleCurves: number[][] = [];
     const axisPoints: any[][] = [];
 
@@ -1068,4 +1076,30 @@ export class IfcFileReader {
       angle: (angle * 180) / Math.PI, // Convert to degrees
     };
   }
+
+  private hasSweptDiskDirectrix(
+    modelID: number,
+    mesh: any,
+    geometryIndex: number,
+  ): boolean {
+    try {
+      if (!this._ifcAPI) return false;
+
+      const geometryRef = mesh.geometries.get(geometryIndex);
+      if (!geometryRef) return false;
+
+      const geometry = this._ifcAPI.GetGeometry(
+        modelID,
+        geometryRef.geometryExpressID,
+      );
+
+      if (!geometry?.GetSweptDiskSolid) return false;
+
+      const swept = geometry.GetSweptDiskSolid();
+      // @ts-ignore
+      return !!swept?.axis && swept.axis.size() > 0;
+    } catch {
+      return false;
+    }
+  }
 }