Skip to content

Commit 166c522

Browse files
authored
Merge pull request #3 from wilsonccccc/log1
Use parameterized logging to avoid issues if the error message contai…
2 parents ac49732 + 9542451 commit 166c522

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

app/services/provider_service.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,8 @@ async def _list_models_helper(
443443

444444
return provider_models
445445
except Exception as e:
446-
# In case of API errors, return empty list
447-
logger.error(f"Error fetching models for {provider_name}: {str(e)}")
446+
# Use parameterized logging to avoid issues if the error message contains braces
447+
logger.error("Error fetching models for {}: {}", provider_name, str(e))
448448
return []
449449

450450
provider_adapter_cls = ProviderAdapterFactory.get_adapter_cls(provider_name)
@@ -498,7 +498,8 @@ async def process_request(
498498
f"API key is not permitted to use provider '{provider_name}'."
499499
)
500500
except ValueError as e:
501-
logger.error(f"Error getting provider info for model {model}: {str(e)}")
501+
# Use parameterized logging to avoid issues if the error message contains braces
502+
logger.error("Error getting provider info for model {}: {}", model, str(e))
502503
raise ValueError(
503504
f"Invalid model ID: {model}. Please check your model configuration."
504505
)
@@ -674,9 +675,8 @@ async def token_counting_stream() -> AsyncGenerator[bytes, None]:
674675
)
675676

676677
except Exception as e:
677-
logger.error(
678-
f"Error in streaming response: {str(e)}", exc_info=True
679-
)
678+
# Use parameterized logging to avoid issues if the error message contains braces
679+
logger.error("Error in streaming response: {}", str(e), exc_info=True)
680680
# Re-raise to propagate the error
681681
raise
682682
finally:
@@ -759,6 +759,8 @@ def create_default_tensorblock_provider_for_user(user_id: int, db: Session) -> N
759759
except Exception as e:
760760
db.rollback()
761761
logger.error(
762-
f"Error creating default TensorBlock provider for user {user_id}: {e}"
762+
"Error creating default TensorBlock provider for user {}: {}",
763+
user_id,
764+
e,
763765
)
764766
# Don't raise the exception - this is optional functionality

0 commit comments

Comments
 (0)