No more warnings

Author: patchzyy

.editorconfig

@@ -12,6 +12,15 @@ indent_size = 2
 [*.cs]
 max_line_length = 140
 
+# Transitional analyzer levels while legacy filesystem/settings migration is in progress.
+dotnet_diagnostic.CS0618.severity = suggestion
+dotnet_diagnostic.IO0002.severity = suggestion
+dotnet_diagnostic.IO0003.severity = suggestion
+dotnet_diagnostic.IO0004.severity = suggestion
+dotnet_diagnostic.IO0005.severity = suggestion
+dotnet_diagnostic.IO0006.severity = suggestion
+dotnet_diagnostic.IO0007.severity = suggestion
+
 #### Core EditorConfig Options ####
 
 # Indentation and spacing

WheelWizard.Test/Features/MiiDbServiceTests.cs

@@ -1,5 +1,4 @@
 using NSubstitute.ExceptionExtensions;
-using Testably.Abstractions;
 using WheelWizard.Shared;
 using WheelWizard.WiiManagement.MiiManagement;
 using WheelWizard.WiiManagement.MiiManagement.Domain.Mii;
@@ -9,16 +8,14 @@ namespace WheelWizard.Test.Features
     public class MiiDbServiceTests
     {
         private readonly IMiiRepositoryService _repositoryService;
-        private readonly IRandomSystem _randomSystemService;
         private readonly MiiDbService _service;
 
         // --- Test Setup ---
 
         public MiiDbServiceTests()
         {
             _repositoryService = Substitute.For<IMiiRepositoryService>();
-            _randomSystemService = Substitute.For<IRandomSystem>();
-            _service = new(_repositoryService, _randomSystemService);
+            _service = new(_repositoryService);
         }
 
         // --- Helper Methods ---
@@ -188,7 +185,7 @@ public void GetAllMiis_ShouldSkipInvalidBlocks_AndReturnOnlyValidMiis()
             Assert.True(mii1Result.IsSuccess, "Setup Failed: Could not create valid Mii");
             var mii1Bytes = GetSerializedBytes(mii1Result.Value);
             var invalidBytesShort = new byte[10]; // Invalid length
-            var invalidBytesNull = (byte[])null; // Null entry (if possible from repo)
+            byte[]? invalidBytesNull = null; // Null entry (if possible from repo)
             // Simulate a block that's the right size but contains garbage data causing deserialization failure
             var potentiallyBadBytes = new byte[MiiSerializer.MiiBlockSize];
             _repositoryService.LoadAllBlocks().Returns([invalidBytesShort, mii1Bytes, potentiallyBadBytes, invalidBytesNull!]);

WheelWizard/Features/WiiManagement/GameLicense/Domain/LicenseProfile.cs

@@ -7,5 +7,5 @@ public class LicenseProfile : PlayerProfileBase
     public required uint TotalRaceCount { get; set; }
     public required uint TotalWinCount { get; set; }
     public List<FriendProfile> Friends { get; set; } = [];
-    public LicenseStatistics Statistics { get; set; }
+    public LicenseStatistics Statistics { get; set; } = new();
 }

WheelWizard/Features/WiiManagement/MiiManagement/MiiDbService.cs

@@ -1,5 +1,4 @@
-using Testably.Abstractions;
-using WheelWizard.Shared.MessageTranslations;
+using WheelWizard.Shared.MessageTranslations;
 using WheelWizard.WiiManagement.MiiManagement.Domain.Mii;
 
 namespace WheelWizard.WiiManagement.MiiManagement;
@@ -55,7 +54,7 @@ public interface IMiiDbService
     bool Exists();
 }
 
-public class MiiDbService(IMiiRepositoryService repository, IRandomSystem randomSystem) : IMiiDbService
+public class MiiDbService(IMiiRepositoryService repository) : IMiiDbService
 {
     public List<Mii> GetAllMiis()
     {

WheelWizard/Features/WiiManagement/MiiManagement/MiiRepositoryService.cs

@@ -54,7 +54,6 @@ public interface IMiiRepositoryService
 
 public class MiiRepositoryServiceService(IFileSystem fileSystem) : IMiiRepositoryService
 {
-    private readonly IFileSystem _fileSystem;
     private const int MiiLength = 74;
     private const int MaxMiiSlots = 100;
     private const int CrcOffset = 0x1F1DE;

WheelWizard/Helpers/Humanizer.cs

@@ -55,9 +55,6 @@ public static string HumanizeTimeSpan(TimeSpan timeSpan)
         }
 
         return ReplaceDynamic(Phrases.Time_Seconds_x, timeSpan.Seconds)!;
-
-        // internal method to simplify the pluralization of words
-        string P(int count) => Math.Abs(count) != 1 ? "s" : "";
     }
 
     public static string HumanizeSeconds(int seconds) => HumanizeTimeSpan(TimeSpan.FromSeconds(seconds));

WheelWizard/Services/Installation/ModInstallation.cs

@@ -135,10 +135,11 @@ public static void ProcessFile(string file, string destinationDirectory, Progres
                 });
 
                 // Normalize entry path by removing empty folder segments
+                var entryKey = entry.Key ?? string.Empty;
                 var sanitizedKey = string.Join(
                     Path.DirectorySeparatorChar.ToString(),
-                    entry
-                        .Key.Split(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar)
+                    entryKey
+                        .Split(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar)
                         .Where(segment => !string.IsNullOrWhiteSpace(segment))
                 );
 
@@ -176,7 +177,7 @@ public static void ProcessFile(string file, string destinationDirectory, Progres
         }
     }
 
-    private static IArchive OpenArchive(string filePath, string extension)
+    private static IArchive? OpenArchive(string filePath, string extension)
     {
         try
         {
@@ -201,7 +202,7 @@ private static IArchive OpenArchive(string filePath, string extension)
     /// </summary>
     public static async Task InstallModFromFileAsync(string filePath, string givenModName, string author = "-1", int modID = -1)
     {
-        ProgressWindow progressWindow = null;
+        ProgressWindow? progressWindow = null;
         try
         {
             if (!File.Exists(filePath))

WheelWizard/Services/ModManager.cs

@@ -101,7 +101,7 @@ public void RemoveMod(Mod mod)
         OnPropertyChanged(nameof(Mods));
     }
 
-    private void Mod_PropertyChanged(object sender, PropertyChangedEventArgs e)
+    private void Mod_PropertyChanged(object? sender, PropertyChangedEventArgs e)
     {
         if (_isBatchUpdating)
             return;
@@ -161,7 +161,7 @@ private async Task CombineFilesIntoSingleModAsync(string[] filePaths)
             .SetPlaceholderText("Enter mod name...")
             .SetValidation(ValidateModName)
             .ShowDialog();
-        if (!IsValidName(modName))
+        if (string.IsNullOrWhiteSpace(modName) || !IsValidName(modName))
             return;
 
         var tempZipPath = Path.Combine(Path.GetTempPath(), $"{modName}.zip");
@@ -230,7 +230,7 @@ public void ToggleAllMods(bool enable)
     // TODO: Use this validation method when refactoring the ModManager
     public OperationResult ValidateModName(string? oldName, string newName)
     {
-        newName = newName?.Trim();
+        newName = (newName ?? string.Empty).Trim();
         if (string.IsNullOrWhiteSpace(newName))
             return Fail("Mod name cannot be empty.");
 
@@ -423,7 +423,7 @@ private void ErrorOccurred(string? errorMessage)
         new MessageBoxWindow()
             .SetMessageType(MessageBoxWindow.MessageType.Error)
             .SetTitleText("An error occurred")
-            .SetInfoText(errorMessage)
+            .SetInfoText(errorMessage ?? "An unknown error occurred.")
             .Show();
     }
 

WheelWizard/Services/Storage/FilePickerHelper.cs

@@ -25,6 +25,8 @@ public static async Task<List<string>> OpenFilePickerAsync(
         var storageProvider = Application.Current?.ApplicationLifetime as IClassicDesktopStyleApplicationLifetime;
         if (storageProvider == null)
             return [];
+        if (storageProvider.MainWindow?.StorageProvider == null)
+            return [];
 
         var options = new FilePickerOpenOptions
         {
@@ -71,37 +73,15 @@ public static async Task<List<string>> OpenFilePickerAsync(
         return null;
     }
 
-    public static async Task<List<string>> OpenMultipleFilesAsync(string title, IEnumerable<FilePickerFileType> fileTypes)
-    {
-        var storageProvider = Application.Current?.ApplicationLifetime as IClassicDesktopStyleApplicationLifetime;
-        if (storageProvider == null)
-            return null;
-
-        var topLevel = TopLevel.GetTopLevel(storageProvider.MainWindow);
-        if (topLevel?.StorageProvider == null)
-            return [];
-
-        var files = await topLevel.StorageProvider.OpenFilePickerAsync(
-            new()
-            {
-                Title = title,
-                AllowMultiple = true,
-                FileTypeFilter = fileTypes.ToList(),
-            }
-        );
-
-        return files?.Select(TryResolveLocalPath).Where(path => !string.IsNullOrWhiteSpace(path)).Select(path => path!).ToList() ?? [];
-    }
-
     public static async Task<IReadOnlyList<IStorageFolder?>> SelectFolderAsync(string title, IStorageFolder? suggestedStartLocation = null)
     {
         var storageProvider = Application.Current?.ApplicationLifetime as IClassicDesktopStyleApplicationLifetime;
         if (storageProvider == null)
-            return null;
+            return [];
 
         var topLevel = TopLevel.GetTopLevel(storageProvider.MainWindow);
         if (topLevel?.StorageProvider == null)
-            return null;
+            return [];
 
         var folders = await topLevel.StorageProvider.OpenFolderPickerAsync(
             new()

WheelWizard/Utilities/Mockers/MockingDataFactory.cs

@@ -8,7 +8,7 @@ public abstract class MockingDataFactory<T, U>
     public static U Instance { get; } = new();
     public abstract T Create(int? seed = null);
 
-    protected virtual string DictionaryKeyGenerator(T value) => value.ToString();
+    protected virtual string DictionaryKeyGenerator(T value) => value is null ? string.Empty : value.ToString() ?? string.Empty;
 
     public T[] CreateMultiple(int count = 5, int? seed = null)
     {