Skip to content

Commit 2a0015b

Browse files
committed
Enable ruff pandas ruleset
Unfortunately with bugs in ruff (e.g. 2143) that requires noqa statements where they really should not be - ruff mistakes polars objects as pandas objects.
1 parent 15c825e commit 2a0015b

5 files changed

Lines changed: 6 additions & 5 deletions

File tree

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ select = [
216216
"ISC",
217217
"LOG", # logging
218218
"NPY", # numpy specific rules
219+
"PD",
219220
"PIE", # flake8-pie
220221
"PL", # pylint
221222
"PLE",

src/ert/dark_storage/endpoints/responses.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ def data_for_response(
177177
assert "report_step" in filter_on
178178
report_step = int(filter_on["report_step"])
179179
vals = data.filter(pl.col("report_step").eq(report_step))
180-
pivoted = vals.drop("response_key", "report_step").pivot(
180+
pivoted = vals.drop("response_key", "report_step").pivot( # noqa: PD010
181181
on="index", values="values"
182182
)
183183
data = pivoted.to_pandas().set_index("realization")

src/ert/plugins/hook_implementations/workflows/csv_export.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def run(
111111
summary_data = pl.DataFrame({})
112112

113113
if not summary_data.is_empty():
114-
pivoted_summary = summary_data.pivot(
114+
pivoted_summary = summary_data.pivot( # noqa: PD010
115115
index=["realization", "time"], on="response_key", values="values"
116116
).to_pandas()
117117

src/ert/storage/local_ensemble.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1054,7 +1054,7 @@ def get_observations_and_responses(
10541054
pl.col(col).is_in(observed_values.implode())
10551055
)
10561056

1057-
pivoted = responses.collect(engine="streaming").pivot(
1057+
pivoted = responses.collect(engine="streaming").pivot( # noqa: PD010
10581058
on="realization",
10591059
index=["response_key", *response_cls.primary_key],
10601060
values="values",
@@ -1230,7 +1230,7 @@ def all_parameters_and_gen_data(self) -> pl.DataFrame | None:
12301230
how="horizontal",
12311231
)
12321232

1233-
responses_wide = responses["realization", "response_key", "values"].pivot(
1233+
responses_wide = responses["realization", "response_key", "values"].pivot( # noqa: PD010
12341234
on="response_key", values="values"
12351235
)
12361236

tests/ert/performance_tests/test_dark_storage_performance.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ def get_record_observations(storage, ensemble_id, keyword: str, poly_ran):
103103
assert len(obs) == num_summary_obs
104104
assert np.isclose(obs[0].errors[0], 0.1)
105105
assert obs[0].x_axis[0].startswith("2010-01-02T00:00:00")
106-
assert np.isclose(obs[0].values[0], 2.6357)
106+
assert np.isclose(obs[0].values[0], 2.6357) # noqa: PD011
107107
assert len(obs[0].errors) == 1
108108
assert len(obs[0].x_axis) == 1
109109
assert len(obs[0].values) == 1

0 commit comments

Comments
 (0)