Records aren't renamed correctly

[jonesdevelopment]

The renamer seems to be causing issues with Java 17+ records.

https://mclo.gs/UML5OlM

Any ideas what could solve this except for not using records for the time being?

[SpartanB312]

How about automatically renaming the generated method(like getter) for those field?

[moeyinlo]

This error seems to be caused by reflection calls from Gson, and Grunt does not support any reflections yet. In my opinion, you are not supposed to obfuscate record classes used in serialization or deserialization.

[jonesdevelopment]

This error seems to be caused by reflection calls from Gson, and Grunt does not support any reflections yet. In my opinion, you are not supposed to obfuscate record classes used in serialization or deserialization.

Since it does not happen with normal classes, we are likely breaking something somewhere. I think it has to do with how records work with their automatically-generated getters, as SpartanB312 mentioned.

[jonesdevelopment]

This is the record that caused issues. As previously mentioned, this error occurs because Gson can't find the required methods. It works fine when converted to a normal class.

import com.google.gson.annotations.SerializedName;

import java.util.Map;

public record Int2IntMapping(@SerializedName("name") String name,
                             @SerializedName("ids") Map<Integer, Integer> ids) {
}

Working version:

import com.google.gson.annotations.SerializedName;
import lombok.Getter;
import lombok.RequiredArgsConstructor;

import java.util.Map;

@Getter
@RequiredArgsConstructor
public final class Int2IntMapping {
  @SerializedName("name")
  private final String name;
  @SerializedName("ids")
  private final Map<Integer, Integer> ids;
}

[moeyinlo]

This is the record that caused issues. As previously mentioned, this error occurs because Gson can't find the required methods. It works fine when converted to a normal class.

import com.google.gson.annotations.SerializedName;

import java.util.Map;

public record Int2IntMapping(@SerializedName("name") String name,
                             @SerializedName("ids") Map<Integer, Integer> ids) {
}

I see, so a straight fix is to make the obfuscated names of getter/setter to be consistent with the field name. This should be easy to implement.

[moeyinlo]

You can determine a record class by checking its superclass, and the names of getter/setter is simply the name of the field they operates.

[DanilGnedin]

About json 1 file you can rename in shadowjar or not use checks obf to break.(Reverse and others) Exclude that class in grunt its simple complete problem.Maybe its fixed in next time