-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
public function downloadFile($fileUri, $locale = '', DownloadFileParameters $params = null)
{
$this->isDownload = TRUE;
...
$response = $this->sendRequest("locales/{$locale}/file", $params, self::HTTP_METHOD_GET, FALSE);
$this->isDownload = FALSE;
...
}If exception happens in the middle of the method then $this->isDownload will still TRUE.
Proposed options
- Use
try finally - Use different methods for GET request with smartling response and GET requests for downloading files