Skip to content

Commit 7bf1fe2

Browse files
Merge pull request #747 from Sitecore/bcn/bf/carousel-react-select-bugfix
fix: restore carousel nav arrows and Select React menu visibility
2 parents 015451c + 39cf976 commit 7bf1fe2

4 files changed

Lines changed: 9 additions & 4 deletions

File tree

src/app/content/ui/carousel/carousel-negative-margin.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export default function CarouselNegativeMarginDemo() {
1818
{Array.from({ length: 5 }).map((_, index) => (
1919
<CarouselItem key={index} className="pl-1 md:basis-1/2">
2020
<div className="p-1">
21-
<Card className="bg-subtle-bg border-subtle-bg">
21+
<Card className="bg-subtle-bg border-subtle-bg p-0">
2222
<CardContent className="flex aspect-square items-center justify-center p-6">
2323
<span className="text-2xl font-semibold text-body-text">
2424
{index + 1}

src/app/content/ui/carousel/carousel-start-aligned.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99

1010
export default function CarouselStartAlignedDemo() {
1111
return (
12-
<div className="w-full max-w-sm mx-auto">
12+
<div className="w-full max-w-sm mx-auto px-20">
1313
<Carousel
1414
className="w-full"
1515
aria-label="Responsive cards carousel with start alignment"
@@ -21,7 +21,7 @@ export default function CarouselStartAlignedDemo() {
2121
{Array.from({ length: 5 }).map((_, index) => (
2222
<CarouselItem key={index} className="md:basis-1/2 lg:basis-1/3">
2323
<div className="p-1">
24-
<Card className="bg-subtle-bg border-subtle-bg">
24+
<Card className="bg-subtle-bg border-subtle-bg p-0">
2525
<CardContent className="flex aspect-square items-center justify-center p-6">
2626
<span className="text-3xl font-semibold text-body-text">
2727
{index + 1}

src/app/content/ui/carousel/carousel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export default function CarouselDemo() {
1818
{Array.from({ length: 5 }).map((_, index) => (
1919
<CarouselItem key={index}>
2020
<div className="p-1">
21-
<Card className="bg-subtle-bg border-subtle-bg">
21+
<Card className="bg-subtle-bg border-subtle-bg p-0">
2222
<CardContent className="flex aspect-square items-center justify-center p-6">
2323
<span className="text-4xl font-semibold text-body-text">
2424
{index + 1}

src/components/ui/select-react.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,10 @@ function SelectReact<
227227
...base,
228228
backgroundColor: undefined,
229229
}),
230+
menuPortal: (base) => ({
231+
...base,
232+
zIndex: 50,
233+
}),
230234
menuList: (base) => ({
231235
...base,
232236
padding: undefined,
@@ -298,6 +302,7 @@ function SelectReact<
298302
components={mergedComponents}
299303
isDisabled={isDisabled}
300304
isOptionDisabled={(option) => !!(option as SelectReactOption).disabled}
305+
menuPortalTarget={typeof document !== "undefined" ? document.body : null}
301306
{...props}
302307
/>
303308
);

0 commit comments

Comments
 (0)