Bugfix: Build issue with fix teams screen share

Author: Sigurs

openspec/changes/fix-screen-share-handler-types/.openspec.yaml

@@ -0,0 +1,2 @@
+schema: spec-driven
+created: 2026-04-03

openspec/changes/fix-screen-share-handler-types/design.md

@@ -0,0 +1,36 @@
+## Context
+
+The Electron 41 `Streams` interface:
+```
+video?: Video | WebFrameMain      // 'loopback' NOT valid
+audio?: 'loopback' | 'loopbackWithMute' | WebFrameMain   // 'loopback' valid
+```
+
+`'loopback'` for audio means "provide system audio via PipeWire loopback". There is no `'loopback'` equivalent for video — video must be a `DesktopCapturerSource`-shaped object (`Video`) or a `WebFrameMain`.
+
+On Wayland we cannot use `desktopCapturer.getSources()` (it does not work under Ozone), so we cannot manually supply a `Video` object. Instead, `useSystemPicker: true` tells Electron to show the OS-native picker; on Linux with xdg-desktop-portal this is the portal picker. Electron then supplies the selected stream to the webview without requiring the handler to manually specify a `Video` source.
+
+The `setDisplayMediaRequestHandler` must still be called (without any handler Electron 20+ rejects all `getDisplayMedia` calls). Setting `useSystemPicker: true` handles video via portal; passing `audio: 'loopback'` in the callback provides system audio via PipeWire.
+
+## Goals / Non-Goals
+
+**Goals:**
+- Fix the TypeScript build error
+- Correctly route video to portal picker and audio to PipeWire loopback on Wayland
+
+**Non-Goals:**
+- Changing X11 screen sharing (not affected — handler is gated on `isWayland()`)
+
+## Decisions
+
+**Decision: `{ audio: 'loopback' }` + `{ useSystemPicker: true }`**
+
+Rationale: `'loopback'` is only type-valid for audio. `useSystemPicker: true` is the documented mechanism for delegating video source selection to the OS (portal on Linux). This is the only TypeScript-valid approach that correctly handles both video and audio on Wayland.
+
+Alternative: `callback({})` with no video — `getDisplayMedia` would resolve with no video track, which breaks screen sharing.
+
+Alternative: Remove the handler entirely — Electron 20+ rejects `getDisplayMedia` when no handler is set.
+
+## Risks / Trade-offs
+
+- [`useSystemPicker` is documented as "macOS Experimental"] → The option is present in the type definition and Electron's picker logic is cross-platform; on Linux it delegates to xdg-desktop-portal when available. Worth verifying manually after the fix.

openspec/changes/fix-screen-share-handler-types/proposal.md

@@ -0,0 +1,22 @@
+## Why
+
+The previous implementation of `setDisplayMediaRequestHandler` passes `video: 'loopback'`, but the Electron 41 TypeScript types only accept `Video | WebFrameMain` for `video` — `'loopback'` is only valid for `audio`. The build fails with a `TS2322` type error. Additionally, the approach was conceptually wrong: to get portal-sourced video on Wayland, the handler needs `useSystemPicker: true`, which tells Electron to show the system's native picker (xdg-desktop-portal on Linux) for video source selection.
+
+## What Changes
+
+- Replace `callback({ video: 'loopback', audio: 'loopback' })` with `callback({ audio: 'loopback' })` and add `{ useSystemPicker: true }` as the second argument to `setDisplayMediaRequestHandler`
+- `useSystemPicker: true` triggers the xdg-desktop-portal video picker on Linux; `audio: 'loopback'` provides system audio via PipeWire
+
+## Capabilities
+
+### New Capabilities
+
+_(none)_
+
+### Modified Capabilities
+
+_(none — this is a build fix; the intended runtime behavior is unchanged)_
+
+## Impact
+
+- `src/main/window.ts` (`applySessionPermissions`): one-line fix to the `setDisplayMediaRequestHandler` callback

openspec/changes/fix-screen-share-handler-types/specs/.keep

@@ -0,0 +1,2 @@
+<!-- No spec-level changes. This change is a build fix only. -->
+<!-- The intended behavior is already covered by the screen-sharing spec. -->

openspec/changes/fix-screen-share-handler-types/specs/screen-sharing/spec.md

@@ -0,0 +1,8 @@
+## 1. Fix
+
+- [x] 1.1 In `src/main/window.ts`, change `callback({ video: 'loopback', audio: 'loopback' })` to `callback({ audio: 'loopback' })` and add `{ useSystemPicker: true }` as the second argument to `setDisplayMediaRequestHandler`
+
+## 2. Verify
+
+- [x] 2.1 Run `npm run build` — confirm no TypeScript errors
+- [ ] 2.2 Test screen sharing in Teams on Wayland — confirm portal picker appears and sharing works

openspec/changes/fix-screen-share-handler-types/tasks.md

@@ -84,7 +84,7 @@ export function applySessionPermissions(
   // WebRTCPipeWireCapturer feature can route them to xdg-desktop-portal.
   if (isWayland()) {
     sess.setDisplayMediaRequestHandler((_request, callback) => {
-      callback({ video: 'loopback', audio: 'loopback' });
-    });
+      callback({ audio: 'loopback' });
+    }, { useSystemPicker: true });
   }
 }