Skip to content

Improve migration by including find&replace regex for deprecated props#2054

Closed
audn wants to merge 2 commits intoShopify:mainfrom
audn:patch-1
Closed

Improve migration by including find&replace regex for deprecated props#2054
audn wants to merge 2 commits intoShopify:mainfrom
audn:patch-1

Conversation

@audn
Copy link

@audn audn commented Jan 10, 2026

Added regex instructions for removing deprecated props.

Description

Fixes (issue #)

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)

Added regex instructions for removing deprecated props.
@naqvitalha naqvitalha force-pushed the main branch 4 times, most recently from ada29af to 660b77d Compare January 30, 2026 19:35
@naqvitalha
Copy link
Collaborator

Thanks for the contribution! We're going to pass on this one though — the regex approach is a bit fragile since it won't handle cases like nested braces (e.g., estimatedListSize={{ height: 100, width: 200 }}) or multi-line prop values, and we'd rather not add something to the migration guide that might give users a false sense of completeness. The list of deprecated props is short enough that removing them manually is straightforward. Appreciate you thinking about ways to make the migration easier!

@naqvitalha naqvitalha closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants