Improve migration by including find&replace regex for deprecated props#2054
Closed
audn wants to merge 2 commits intoShopify:mainfrom
Closed
Improve migration by including find&replace regex for deprecated props#2054audn wants to merge 2 commits intoShopify:mainfrom
audn wants to merge 2 commits intoShopify:mainfrom
Conversation
Added regex instructions for removing deprecated props.
ada29af to
660b77d
Compare
Collaborator
|
Thanks for the contribution! We're going to pass on this one though — the regex approach is a bit fragile since it won't handle cases like nested braces (e.g., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added regex instructions for removing deprecated props.
Description
Fixes (issue #)
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)