Skip to content

Commit 602b9fc

Browse files
authored
refactor: standardize MethodImplOptions with named constants (#566)
Replace magic numbers with self-documenting named constants: - (MethodImplOptions)768 → OptimizeAndInline - (MethodImplOptions)512 → Optimize - MethodImplOptions.AggressiveInlining → Inline Add MethodImplOptionsConstants class with: - OptimizeAndInline: AggressiveInlining | AggressiveOptimization (768) - Optimize: AggressiveOptimization (512) - Inline: AggressiveInlining (256) Exposed via global using static for direct access without prefix. Files changed: 128 Replacements: ~2579 occurrences
1 parent 4726bfd commit 602b9fc

File tree

134 files changed

+2633
-2596
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

134 files changed

+2633
-2596
lines changed

src/NumSharp.Core/Backends/Default/ArrayManipulation/Default.Transpose.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ namespace NumSharp.Backends
99
{
1010
public partial class DefaultEngine
1111
{
12-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
12+
[MethodImpl(Inline)]
1313
public static int check_and_adjust_axis(NDArray nd, int axis)
1414
{
1515
return check_and_adjust_axis(nd.ndim, axis);
1616
}
1717

18-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
18+
[MethodImpl(Inline)]
1919
public static int check_and_adjust_axis(int ndims, int axis)
2020
{
2121
int adjusted = axis >= 0 ? axis : ndims + axis;

src/NumSharp.Core/Backends/Default/Helpers/DefaultEngine.ResolveUnaryReturnType.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ namespace NumSharp.Backends
55
{
66
public partial class DefaultEngine
77
{
8-
[MethodImpl((MethodImplOptions)768)]
8+
[MethodImpl(OptimizeAndInline)]
99
public NPTypeCode ResolveUnaryReturnType(in NDArray nd, Type @override) => ResolveUnaryReturnType(nd, @override?.GetTypeCode());
1010

11-
[MethodImpl((MethodImplOptions)768)]
11+
[MethodImpl(OptimizeAndInline)]
1212
public NPTypeCode ResolveUnaryReturnType(in NDArray nd, NPTypeCode? @override)
1313
{
1414
if (!@override.HasValue)

src/NumSharp.Core/Backends/Default/Math/Add/Default.Add.Boolean.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NumSharp.Backends
2020
//v2
2121
public partial class DefaultEngine
2222
{
23-
[MethodImpl((MethodImplOptions)768)]
23+
[MethodImpl(OptimizeAndInline)]
2424
[SuppressMessage("ReSharper", "JoinDeclarationAndInitializer")]
2525
[SuppressMessage("ReSharper", "CompareOfFloatsByEqualityOperator")]
2626
public unsafe NDArray AddBoolean(in NDArray lhs, in NDArray rhs)

src/NumSharp.Core/Backends/Default/Math/Add/Default.Add.Byte.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NumSharp.Backends
2020
//v2
2121
public partial class DefaultEngine
2222
{
23-
[MethodImpl((MethodImplOptions)768)]
23+
[MethodImpl(OptimizeAndInline)]
2424
[SuppressMessage("ReSharper", "JoinDeclarationAndInitializer")]
2525
[SuppressMessage("ReSharper", "CompareOfFloatsByEqualityOperator")]
2626
public unsafe NDArray AddByte(in NDArray lhs, in NDArray rhs)

src/NumSharp.Core/Backends/Default/Math/Add/Default.Add.Char.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NumSharp.Backends
2020
//v2
2121
public partial class DefaultEngine
2222
{
23-
[MethodImpl((MethodImplOptions)768)]
23+
[MethodImpl(OptimizeAndInline)]
2424
[SuppressMessage("ReSharper", "JoinDeclarationAndInitializer")]
2525
[SuppressMessage("ReSharper", "CompareOfFloatsByEqualityOperator")]
2626
public unsafe NDArray AddChar(in NDArray lhs, in NDArray rhs)

src/NumSharp.Core/Backends/Default/Math/Add/Default.Add.Decimal.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NumSharp.Backends
2020
//v2
2121
public partial class DefaultEngine
2222
{
23-
[MethodImpl((MethodImplOptions)768)]
23+
[MethodImpl(OptimizeAndInline)]
2424
[SuppressMessage("ReSharper", "JoinDeclarationAndInitializer")]
2525
[SuppressMessage("ReSharper", "CompareOfFloatsByEqualityOperator")]
2626
public unsafe NDArray AddDecimal(in NDArray lhs, in NDArray rhs)

src/NumSharp.Core/Backends/Default/Math/Add/Default.Add.Double.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NumSharp.Backends
2020
//v2
2121
public partial class DefaultEngine
2222
{
23-
[MethodImpl((MethodImplOptions)768)]
23+
[MethodImpl(OptimizeAndInline)]
2424
[SuppressMessage("ReSharper", "JoinDeclarationAndInitializer")]
2525
[SuppressMessage("ReSharper", "CompareOfFloatsByEqualityOperator")]
2626
public unsafe NDArray AddDouble(in NDArray lhs, in NDArray rhs)

src/NumSharp.Core/Backends/Default/Math/Add/Default.Add.Int16.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NumSharp.Backends
2020
//v2
2121
public partial class DefaultEngine
2222
{
23-
[MethodImpl((MethodImplOptions)768)]
23+
[MethodImpl(OptimizeAndInline)]
2424
[SuppressMessage("ReSharper", "JoinDeclarationAndInitializer")]
2525
[SuppressMessage("ReSharper", "CompareOfFloatsByEqualityOperator")]
2626
public unsafe NDArray AddInt16(in NDArray lhs, in NDArray rhs)

src/NumSharp.Core/Backends/Default/Math/Add/Default.Add.Int32.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NumSharp.Backends
2020
//v2
2121
public partial class DefaultEngine
2222
{
23-
[MethodImpl((MethodImplOptions)768)]
23+
[MethodImpl(OptimizeAndInline)]
2424
[SuppressMessage("ReSharper", "JoinDeclarationAndInitializer")]
2525
[SuppressMessage("ReSharper", "CompareOfFloatsByEqualityOperator")]
2626
public unsafe NDArray AddInt32(in NDArray lhs, in NDArray rhs)

src/NumSharp.Core/Backends/Default/Math/Add/Default.Add.Int64.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NumSharp.Backends
2020
//v2
2121
public partial class DefaultEngine
2222
{
23-
[MethodImpl((MethodImplOptions)768)]
23+
[MethodImpl(OptimizeAndInline)]
2424
[SuppressMessage("ReSharper", "JoinDeclarationAndInitializer")]
2525
[SuppressMessage("ReSharper", "CompareOfFloatsByEqualityOperator")]
2626
public unsafe NDArray AddInt64(in NDArray lhs, in NDArray rhs)

0 commit comments

Comments
 (0)