Upgrade

[ChrisRackauckas]

@tkf is the monkey patching no longer necessary?

[tkf]

It seems that there is no new release yet: https://github.com/robclewley/pydstool/releases. We also need to wait for it to arrive at conda-forge: https://anaconda.org/conda-forge/pydstool

[tkf]

We first try to load it without monkey-patching so I guess/hope current PyDSTool.jl would work even after the new release.

https://github.com/JuliaDiffEq/PyDSTool.jl/blob/1bb9698563ba569a543fcc2ed1bf3db3d4035ca5/src/PyDSTool.jl#L10-L28

[ChrisRackauckas]

Test Summary: |
Linear Solve  | No tests
  3.246448 seconds (8.21 M allocations: 409.825 MiB, 3.24% gc time)
Calcium Direct: Error During Test at C:\Users\Chris\.julia\packages\PyDSTool\nreJ8\test\runtests.jl:5
  Got exception outside of a @test
  LoadError: PyError ($(Expr(:escape, :(ccall(#= C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\pyfncall.jl:101 =# @pysym(:PyObject_Call), PyPtr, (PyPtr, PyPtr, PyPtr), o, pyargsptr, kw))))) <class 'TypeError'>
  TypeError("'float' object cannot be interpreted as an integer",)
    File "C:\Users\Chris\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\PyDSTool\PyCont\Continuation.py", line 1246, in forward
      self._compute(v0=self.initdirec)
    File "C:\Users\Chris\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\PyDSTool\PyCont\Continuation.py", line 1102, in _compute
      self._createTestFuncs()
    File "C:\Users\Chris\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\PyDSTool\PyCont\Continuation.py", line 2035, in _createTestFuncs
      save=True, numpoints=self.MaxNumPoints+1)
    File "C:\Users\Chris\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\PyDSTool\PyCont\TestFunc.py", line 719, in __init__
      BiAltMethod.__init__(self, (F.n, 1), F, C, save=save, numpoints=numpoints)
    File "C:\Users\Chris\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\PyDSTool\PyCont\TestFunc.py", line 381, in __init__
      self.data.P = zeros((n*(n-1)/2, n*(n-1)/2), float)

  Stacktrace:
   [1] pyerr_check at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\exception.jl:60 [inlined]
   [2] pyerr_check at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\exception.jl:64 [inlined]
   [3] macro expansion at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\exception.jl:84 [inlined]
   [4] __pycall!(::PyObject, ::Ptr{PyCall.PyObject_struct}, ::PyObject, ::Ptr{Nothing}) at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\pyfncall.jl:101
   [5] _pycall! at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\pyfncall.jl:62 [inlined]
   [6] macro expansion at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\exception.jl:84 [inlined]
   [7] _pycall!(::PyObject, ::PyObject, ::Tuple{}, ::Int64, ::Ptr{Nothing}) at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\pyfncall.jl:28
   [8] #call#89 at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\pyfncall.jl:16 [inlined]
   [9] (::PyObject)() at C:\Users\Chris\.julia\packages\PyCall\WcrLS\src\pyfncall.jl:147
   [10] #bifurcation_curve#5(::Int64, ::Int64, ::Float64, ::Float64, ::String, ::Bool, ::String, ::Bool, ::Bool, ::Float64, ::Float64, ::Float64, ::Nothing, ::Array{Symbol,1}, ::typeof(bifurcation_curve), ::PyObject, ::String, ::Array{String,1}) at C:\Users\Chris\.julia\packages\PyDSTool\nreJ8\src\bifurcation.jl:107
   [11] (::getfield(PyDSTool, Symbol("#kw##bifurcation_curve")))(::NamedTuple{(:max_num_points, :max_stepsize, :min_stepsize, :stepsize, :loc_bif_points, :save_eigen, :name, :print_info, :calc_stab),Tuple{Int64,Int64,Float64,Float64,String,Bool,String,Bool,Bool}}, ::typeof(bifurcation_curve), ::PyObject, ::String, ::Array{String,1}) at .\none:0
   [12] top-level scope at none:0
   [13] include at .\boot.jl:317 [inlined]
   [14] include_relative(::Module, ::String) at .\loading.jl:1038
   [15] include(::Module, ::String) at .\sysimg.jl:29
   [16] include(::String) at .\client.jl:388
   [17] macro expansion at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.0\Test\src\Test.jl:1085 [inlined]
   [18] macro expansion at C:\Users\Chris\.julia\packages\PyDSTool\nreJ8\test\runtests.jl:4 [inlined]
   [19] macro expansion at .\util.jl:156 [inlined]
   [20] macro expansion at C:\Users\Chris\.julia\packages\PyDSTool\nreJ8\test\runtests.jl:4 [inlined]
   [21] top-level scope at .\util.jl:156 [inlined]
   [22] top-level scope at .\none:0
   [23] include at .\boot.jl:317 [inlined]
   [24] include_relative(::Module, ::String) at .\loading.jl:1038
   [25] include(::Module, ::String) at .\sysimg.jl:29
   [26] include(::String) at .\client.jl:388
   [27] top-level scope at none:0
   [28] eval(::Module, ::Any) at .\boot.jl:319
   [29] macro expansion at .\logging.jl:317 [inlined]
   [30] exec_options(::Base.JLOptions) at .\client.jl:219
   [31] _start() at .\client.jl:421
  in expression starting at C:\Users\Chris\.julia\packages\PyDSTool\nreJ8\test\calcium.jl:35
Test Summary:  | Error  Total
Calcium Direct |     1      1
ERROR: LoadError: Some tests did not pass: 0 passed, 0 failed, 1 errored, 0 broken.
in expression starting at C:\Users\Chris\.julia\packages\PyDSTool\nreJ8\test\runtests.jl:3
ERROR: Package PyDSTool errored during testing

Looks like something else broke then.

[tkf]

Yeah, I guess because

self.data.P = zeros((n*(n-1)/2, n*(n-1)/2), float)

has to be written with integer division // as in

self.data.P = zeros((n*(n-1)//2, n*(n-1)//2), float)

It probably would still work with Python 2 but Conda.jl switched default Python to 3 so I guess that's why you are seeing this error.

[tkf]

Ah, I forgot that I sent a PR for this robclewley/pydstool#125 which is already merged. So this probably would work in the next release...