Skip to content

Connection fails with full FTP username user@subdomain.domain.tld, but works with user@domain.tldΒ #523

@doomslayer86

Description

@doomslayer86

Bug Description
Connection fails when the FTP username is in the form user@subdomain.domain.tld , but the same deploy works when using user@domain.tld. Server and password are unchanged; only the username format differs. So the action appears to mishandle or reject usernames that include a subdomain before the @.

My Action Config

on: push
name: Publish Website
jobs:
  web-deploy:
    name: Deploy website every commit
    runs-on: ubuntu-latest
    environment: prod
    steps:
      - uses: actions/checkout@v4

      - name: Deploy via FTP
        uses: SamKirkland/FTP-Deploy-Action@v4.3.5
        with:
          server: server111.shared.spaceship.host
          username: user@subdomain.domain.tld
          password: ${{ secrets.FTP_PASSWORD }}
          server-dir: ${{ secrets.FTP_REMOTE_PATH }}
          exclude: |
            **/.git*
            **/.git*/**
            **/node_modules/**
          log-level: verbose

My Action Log

----------------------------------------------------------------
πŸš€ Thanks for using ftp-deploy. Let's deploy some stuff!   
----------------------------------------------------------------
If you found this project helpful, please support it
by giving it a ⭐ on Github --> https:***github.com***SamKirkland***FTP-Deploy-Action
or add a badge 🏷️ to your projects readme --> https:***github.com***SamKirkland***FTP-Deploy-Action#badge
Failed to connect, are you sure your server works via FTP or FTPS? Users sometimes get this error when the server only supports SFTP.
----------------------------------------------------------------
--------------  πŸ”₯πŸ”₯πŸ”₯ an error occurred  πŸ”₯πŸ”₯πŸ”₯  --------------
----------------------------------------------------------------
----------------------------------------------------------------
----------------------  full error below  ----------------------
----------------------------------------------------------------
Error: Timeout (control socket)
    at Socket.<anonymous> (***home***runner***work***_actions***SamKirkland***FTP-Deploy-Action***v4.3.5***dist***index.js:5299:33)
    at Object.onceWrapper (node:events:638:28)
    at Socket.emit (node:events:524:28)
    at Socket._onTimeout (node:net:595:8)
    at listOnTimeout (node:internal***timers:581:17)
    at process.processTimers (node:internal***timers:519:7)
Error: Error: Timeout (control socket)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions