Skip to content

netweaver.setup state is not idempotent #57

@MalloZup

Description

@MalloZup

This is a tracker issue in order to improve the idempotency of our formulas

running for the 2nd time

salt-call --local             --log-level=error             --log-file=/var/log/salt-deployment.log             --log-file-level=debug             --retcode-passthrough          state.sls   netweaver.setup saltenv=base
          ID: label_partition
    Function: cmd.run
        Name: /usr/sbin/parted -s /dev/vdb mklabel gpt
      Result: False
     Comment: Command "/usr/sbin/parted -s /dev/vdb mklabel gpt" run
     Started: 20:51:57.973483
    Duration: 108.301 ms
     Changes:   
              ----------
              pid:
                  17175
              retcode:
                  1
              stderr:
                  Error: Partition(s) on /dev/vdb are being used.
              stdout:

and

---------
          ID: clean_nfs_sapmnt_HA1_00
    Function: file.absent
        Name: /sapmnt/HA1
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python3.6/site-packages/salt/modules/file.py", line 3793, in remove
                  shutil.rmtree(path)
                File "/usr/lib64/python3.6/shutil.py", line 486, in rmtree
                  _rmtree_safe_fd(fd, path, onerror)
                File "/usr/lib64/python3.6/shutil.py", line 424, in _rmtree_safe_fd
                  _rmtree_safe_fd(dirfd, fullname, onerror)
                File "/usr/lib64/python3.6/shutil.py", line 424, in _rmtree_safe_fd
                  _rmtree_safe_fd(dirfd, fullname, onerror)
                File "/usr/lib64/python3.6/shutil.py", line 424, in _rmtree_safe_fd
                  _rmtree_safe_fd(dirfd, fullname, onerror)
                File "/usr/lib64/python3.6/shutil.py", line 444, in _rmtree_safe_fd
                  onerror(os.unlink, fullname, sys.exc_info())
                File "/usr/lib64/python3.6/shutil.py", line 442, in _rmtree_safe_fd
                  os.unlink(name, dir_fd=topfd)
              OSError: [Errno 16] Device or resource busy: '.nfs000000000107399d00000001'
              
              During handling of the above exception, another exception occurred:
              
              Traceback (most recent call last):
                File "/usr/lib/python3.6/site-packages/salt/state.py", line 1987, in call
                  ret = self.states[cdata['full']](*cdata['args'], **cdata['kwargs'])
                File "/usr/lib/python3.6/site-packages/salt/loader.py", line 2031, in wrapper
                  return f(*args, **kwargs)
                File "/usr/lib/python3.6/site-packages/salt/states/file.py", line 1974, in absent
                  __salt__['file.remove'](name)
                File "/usr/lib/python3.6/site-packages/salt/modules/file.py", line 3797, in remove
                  'Could not remove \'{0}\': {1}'.format(path, exc)
              salt.exceptions.CommandExecutionError: Could not remove '/sapmnt/HA1': [Errno 16] Device or resource busy: '.nfs000000000107399d00000001'
     Started: 20:51:58.242216
    Duration: 6.282 ms
     Changes:   

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions